From patchwork Sat Nov 17 19:51:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Radoslaw Biernacki X-Patchwork-Id: 151420 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp868868ljp; Sat, 17 Nov 2018 12:17:02 -0800 (PST) X-Google-Smtp-Source: AJdET5fD8wNwQldYdvS1E7B2jj2RVfhtvrgUdeCVeWvO6qTVX+yMsR/i5JC4x+2bNhybG26Cxe6g X-Received: by 2002:ac8:3ae5:: with SMTP id x92mr15612398qte.370.1542485822650; Sat, 17 Nov 2018 12:17:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542485822; cv=none; d=google.com; s=arc-20160816; b=bdK+/w6/qmb2bSeB6TVm+Ld4JcN2T1m5g9spOIk4m7CeZtvAYH0CTpDxOmzpRNvL5L ChqGxwzXYiT0povOffedlq6QX+xnF7ivHsSZcUOF1FdY0pDnU+Fd3okkJc3tU3WV1rER 7gfaB3WkdlrFV5rudrY8HirD68NvKzEK+AvHRcIVj/Q298kSCaifQczljJsJbY6JAzXs fYZKLz2fK5amIDZPXA/TTPRTevgs9y9Y+CY23gXZU4uDj8yCDaB0Ezha7t5QYfivIwmd uWkWIF/m0cecZ5J37/AQ6eHHwjVZaDgwR1KYMe/MlPqb3ahY8iq4AlsaDNm3oLWUyN6y xm0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=m8xvsrj1QQ3U4fdw3LDTLnkeXAKsFKbMkiJ1T6Z4Czc=; b=eMR/QOc7q2c5bzHzCkPLUxGqyYXx0KO8cajcSYwgP7qtxawYO/Zf0i037+X3tlflcu t4Ipdj59cWioDEfRi8gwG8oQTnwofgnbGRmPrAAPAGFFFFyTFHMrVeQTeRFbHkzCOtGj bgtEmHRbSnWUIFhvaPSBNHqmqm92qdLlR1H7y+Se9yCH/RxolXmoUjzSZA02y73GoRqK +oCk7ytEEnYXS9cQGEQzZFbtySOdJPCVOI7hGNEeZJmQxmIrFneSjcUVZc2XBulhLx/a 7NoPkhD8L42+s45P3XUofCE5lF92YdPyahYJ0MwNUG9Qt8s+J7Klev1K6hFfx4NYISfo cO/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=YF82Boqq; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id n69si129661qkn.55.2018.11.17.12.17.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Nov 2018 12:17:02 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=YF82Boqq; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA1BD3082125; Sat, 17 Nov 2018 20:17:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 916D168701; Sat, 17 Nov 2018 20:17:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 15173181B9E5; Sat, 17 Nov 2018 20:17:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wAHJpOvW029176 for ; Sat, 17 Nov 2018 14:51:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6C6B365F4E; Sat, 17 Nov 2018 19:51:24 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 642E060BF1 for ; Sat, 17 Nov 2018 19:51:21 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F401F3082B70 for ; Sat, 17 Nov 2018 19:51:19 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id j6so17301017edp.9 for ; Sat, 17 Nov 2018 11:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2bi8c5JRJVogWes8fe7852+/93v7SR4T96e73luAO5w=; b=YF82Boqq29rzYQW6LPnEh0gtkchRkXeGZKlLR0VSsaFHQh43kWDlvXzkz5RavXt2pN ea9lObNLq4Heu51bxyNKjSzkJ2VD/nFlLkugrDRhZf+uTZ8Qavdtb2qZTNd0JpahKQl2 x7kxfEI7KHGOWjaGkP8p1+r3g9HHJ7EN+6zEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2bi8c5JRJVogWes8fe7852+/93v7SR4T96e73luAO5w=; b=WB9s2ll/K9ujJuvt5MiWJvEclo4BxestPzC3BpT7FIDkHOgdDPOClCbNlK7S05ZRqH bKiXtPqGsmhH1ccMFmk2WIDFN7A6/H0u5htbeIjF1nSDmnZTG5YCShVFbUvrJ2MdmWuU 87EJ+ep8fXXfe8R/P1ugDmK+9ucYm7V+51mzRblxhszCBzwH7XAjbLXDxhMQHs2yXVBd Hl9wkVYFZnVkPo5066p7mvBWY+WfF/wfIKdUjCrN4S9QsQ7oRuaAygmC7fbikrvtsmo7 lNmCpF7s/MLtqYS1/hQhaqM2yv/HQVCjAuLE9L5u7/GIj5Bil8kAOXfo9ke+hsv2ckK1 L7xg== X-Gm-Message-State: AGRZ1gIqQNT7c3+SgOcgALYiQRKyQf5vQnXH4lyFKp7qLhkO7xbyDPnW 3yUG4yZpQqXhUohK5oAzCfiKAvHprE8= X-Received: by 2002:a50:d012:: with SMTP id j18-v6mr14709976edf.289.1542484278264; Sat, 17 Nov 2018 11:51:18 -0800 (PST) Received: from rad-H81M-S1.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id s12sm7887633edb.43.2018.11.17.11.51.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Nov 2018 11:51:17 -0800 (PST) From: Radoslaw Biernacki To: libvir-list@redhat.com, mprivozn@redhat.com Date: Sat, 17 Nov 2018 20:51:09 +0100 Message-Id: <20181117195113.12544-1-radoslaw.biernacki@linaro.org> In-Reply-To: <20181110125624.1168-1-radoslaw.biernacki@linaro.org> References: <20181110125624.1168-1-radoslaw.biernacki@linaro.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 17 Nov 2018 19:51:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 17 Nov 2018 19:51:20 +0000 (UTC) for IP:'209.85.208.66' DOMAIN:'mail-ed1-f66.google.com' HELO:'mail-ed1-f66.google.com' FROM:'radoslaw.biernacki@linaro.org' RCPT:'' X-RedHat-Spam-Score: -0.112 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.208.66 mail-ed1-f66.google.com 209.85.208.66 mail-ed1-f66.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: laine@laine.org Subject: [libvirt] [PATCH v2 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Sat, 17 Nov 2018 20:17:01 +0000 (UTC) ThunderX is Cavium SoC. This platform contain SRIOV NIC. Unlike other commonly known network devices it does not have VF functionality duplicated in its PF. PF is purely management device (on HW level). This creates several problems with existing libvirt code as in many places libvirt assumes that each VF netdev has PF netdev assigned. This patch series trying to address issues which can be easily fixed. (mostly bug fixes found while working on full featured solution) First patch in series is most important as it allows to unblock the netdev detection and use on this platform.i model check removed as STREQ_NULLABLE() follows Radoslaw Biernacki (4): util: fixing wrong assumption that PF has to have netdev assigned util: Code simplification util: Fix for NULL dereference util: Fixing invalid error checking from virPCIGetNetname() src/qemu/qemu_domain_address.c | 13 ++-- src/util/virhostdev.c | 2 +- src/util/virnetdev.c | 62 +++++--------------- 3 files changed, 22 insertions(+), 55 deletions(-) -- 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list