From patchwork Tue Oct 14 07:42:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 38694 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 742CE20549 for ; Tue, 14 Oct 2014 07:45:19 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id ge10sf4914513lab.9 for ; Tue, 14 Oct 2014 00:45:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=lqntL3lFefyJ4IBzO67ePI8XeV8FVdOR4jSpNppMoGQ=; b=GRyslmOJXksDasVPbxIOpYr7i4VLhDDA97vfTN7b1nyZv+VwRhipvE3ROOSJi7V7ip L4s0qUeN4kPngTEuzwM5e61sjInerBvK9GgVyIxL2eDLUX9zG/B3N9qm2d8SjwfUPS2v at8Wa7BhXGYkBPDg72iIPwMWUBuaBkeD3nEwSqn7uT/s7USl2I8ravGFBn/cHA17Rejb 4HxF40FcSr84LsTMICAthTDN71tcJXSXk1cBWLg643SffmqO8TQ+f4HfHoaX2CAfsJHo aPlHeM+k6aZLXJ1bIBEqlgUqGlJWIuXy5BEAwVpl6I2dw2wCZFF5zxVm5s+B1ibBaRrB E0Gw== X-Gm-Message-State: ALoCoQkVFPyoDJhjdMowm+upx8+ouXyav2p5hibzQ7NBEh05Hsgp+WvEeitsXHLQaP7E4lWCKp9f X-Received: by 10.112.26.82 with SMTP id j18mr133034lbg.16.1413272717918; Tue, 14 Oct 2014 00:45:17 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.26.72 with SMTP id j8ls469158lag.105.gmail; Tue, 14 Oct 2014 00:45:17 -0700 (PDT) X-Received: by 10.112.189.10 with SMTP id ge10mr3453085lbc.23.1413272717579; Tue, 14 Oct 2014 00:45:17 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com [209.85.215.47]) by mx.google.com with ESMTPS id qj5si25268370lbb.89.2014.10.14.00.45.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Oct 2014 00:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by mail-la0-f47.google.com with SMTP id pv20so8077307lab.34 for ; Tue, 14 Oct 2014 00:45:17 -0700 (PDT) X-Received: by 10.152.87.98 with SMTP id w2mr3426421laz.27.1413272717252; Tue, 14 Oct 2014 00:45:17 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp348751lbz; Tue, 14 Oct 2014 00:45:16 -0700 (PDT) X-Received: by 10.229.239.74 with SMTP id kv10mr6273310qcb.27.1413272716110; Tue, 14 Oct 2014 00:45:16 -0700 (PDT) Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com. [209.132.183.37]) by mx.google.com with ESMTPS id r3si28580909qac.40.2014.10.14.00.45.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Oct 2014 00:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.37 as permitted sender) client-ip=209.132.183.37; Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9E7gLHY006572; Tue, 14 Oct 2014 03:42:21 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s9E7gKI8026220 for ; Tue, 14 Oct 2014 03:42:20 -0400 Received: from worklaptop.redhat.com (ovpn-113-107.phx2.redhat.com [10.3.113.107]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9E7gIZ1030794; Tue, 14 Oct 2014 03:42:19 -0400 From: Cole Robinson To: libvir-list@redhat.com Date: Tue, 14 Oct 2014 09:42:16 +0200 Message-Id: <0f41bb2d5732fbdb44a4eb900343a04df260e785.1413272536.git.crobinso@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Michal Privoznik Subject: [libvirt] [PATCH] qemu: command: Allow UEFI for non-x86 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: crobinso@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 It's supported on aarch64 and armv7l as well, so just drop the restriction entirely since it doesn't add much. --- src/qemu/qemu_command.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 8cb0865..2872e47 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7672,14 +7672,6 @@ qemuBuildDomainLoaderCommandLine(virCommandPtr cmd, break; case VIR_DOMAIN_LOADER_TYPE_PFLASH: - /* UEFI is supported only for x86_64 currently */ - if (def->os.arch != VIR_ARCH_X86_64) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("pflash is not supported for %s guest architecture"), - virArchToString(def->os.arch)); - goto cleanup; - } - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("this QEMU binary doesn't support -drive"));