From patchwork Mon Apr 17 16:40:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 673843 Delivered-To: patch@linaro.org Received: by 2002:adf:fcce:0:0:0:0:0 with SMTP id f14csp1604438wrs; Mon, 17 Apr 2023 09:41:07 -0700 (PDT) X-Google-Smtp-Source: AKy350YhAYr28ZZyZRomGJofbzuzgFpv5K7V0pfTMNU4XfFOBG5UUqIf2no/mezG69mffolDdF9w X-Received: by 2002:ac8:58cb:0:b0:3db:8942:cbd2 with SMTP id u11-20020ac858cb000000b003db8942cbd2mr24469291qta.61.1681749667620; Mon, 17 Apr 2023 09:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681749667; cv=none; d=google.com; s=arc-20160816; b=hoDJaViZaCqDWadXq9u7kzB6sA7e4OODIWGfah9iC8FatoS69lJlOf5XVh5F9hktCv UANqxV/zD78A6tkF6o1K5mKz7ShXw42k8yx4iidf8qcbbAuQvMFKk3Vm1b1i2I3oB+bK hZKAXsSFc2wd2TBQmWGGl4yd2bDQEK4M9EnA8Gfne2Tyk3lAW+Bbr2nZOK2x6sRRRfL9 vfzwu33vDZl7HTQk6OvgN3KGPmXsMqJQdbwbUjV+kiLhzZz98S2gU9Pf7wt7OB7pKsP7 9h+DY6fTlSvqZAdSa1j16zmJWluRqCoualX2s47tZxIXJs5MxA7lsPgfN49xvs3BGgZ1 VI6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:sender:errors-to:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to:delivered-to:dkim-signature; bh=4B6l8UECJ90CPUbM7Klpck4y118EN0eBNxzC139Z/3k=; b=V6vJS9ao9ktxqh6wL1dUFCVuq+MiHbh3tsISHe2hADJWnwhMHgHDAfzMsIMcCcZaJc I0CbBytnQXuhZ3iv9/PJOUP2vL5tElKBx/nGFj/pX789ubULSABZgZKW5qkg+s2sEmW4 N80iZAOht1tbvJdthlmYf3NPAbWd/M+cLqBfe9bSfpSez8uq4+zE0rzeq6gXx8FEdA/U PNfmcfqOCDxatsuPfFlQGXtQJ/xUrQlSaGQ8q21lnUc/ZubmsYUG2iiaJrXj1Ip4IxDv WtjempkvkzwokzzYA2y613jVvmgExUmJ1roYBz36o4XJmxszO6gIqTqeXBt3wmx0ZfYi 40DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZPwQasHj; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.133.124]) by mx.google.com with ESMTPS id 2-20020ac85902000000b003e38d6c16f6si5715978qty.438.2023.04.17.09.41.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 09:41:07 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZPwQasHj; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681749667; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4B6l8UECJ90CPUbM7Klpck4y118EN0eBNxzC139Z/3k=; b=ZPwQasHjr5rlD1e5ezgIAsqXVNQtROHxyuB7zJEIREYELdbH2vJYGVB1wH4ctcnbUuYZVE cWXwXiGfv7fldvc0hVW/h/faVd2Ulrk09DO2/z51dJMryRAeHqCT2vSIVFttnp11UAdL/M BYd33pqx8zwFAILzcrLLvVtn2Mpqg4M= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-3gOCnqXhOCe8xTI47ChJag-1; Mon, 17 Apr 2023 12:41:00 -0400 X-MC-Unique: 3gOCnqXhOCe8xTI47ChJag-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C0503815F65; Mon, 17 Apr 2023 16:40:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37EBE40C6E70; Mon, 17 Apr 2023 16:40:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 03FFE19465B1; Mon, 17 Apr 2023 16:40:55 +0000 (UTC) X-Original-To: libvir-list@listman.corp.redhat.com Delivered-To: libvir-list@listman.corp.redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 019F5194658C for ; Mon, 17 Apr 2023 16:40:54 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E9ED740C6E6E; Mon, 17 Apr 2023 16:40:53 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1B8640C94A9 for ; Mon, 17 Apr 2023 16:40:53 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C78AF88F4DE for ; Mon, 17 Apr 2023 16:40:53 +0000 (UTC) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-n0ZJgt0LNYevaXn1BoBYhQ-2; Mon, 17 Apr 2023 12:40:49 -0400 X-MC-Unique: n0ZJgt0LNYevaXn1BoBYhQ-2 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-2fa0ce30ac2so909844f8f.3 for ; Mon, 17 Apr 2023 09:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681749648; x=1684341648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4B6l8UECJ90CPUbM7Klpck4y118EN0eBNxzC139Z/3k=; b=DQFWMuG9qRQIibDGBAQIOLgoALpH6xuk37ny8r9fmlu72y/1lT/Hcvu9zloL2EVE09 b43KX3Np5X6Qqwvs32XJYbCLae1ElvSqiwCyWAZkjGi58IU/BzkFxo9lK8m3xlUSvtWK mSn4+H/Cw7PVWHByDEatobXeZ/PBYJtArTWiKpxeIYSyeoZ3tQZNMsh0xUZGOI3epzp4 lTLgycIqMiXoIsKw51WedOyAcPFEAZzTjDWWRz5yJrsT4K9WsGz+i7vrxOr0Re2kJjpV RfOhyBeyP0ASN6LZwi0HLHWDoO/AF4qY5etgZlbIO4pvA794EtO6G2CfRrS47MJ/CWaO xkIA== X-Gm-Message-State: AAQBX9ckWRM/0UltjeFTMWVDCXvPjI9p9ppgvnxens0EBTVtoVF8pDfe PBwHDdT/T9ICK3+ger2Q1Xr4nvXFc7EXpsAysg8= X-Received: by 2002:adf:f4cb:0:b0:2f5:aadb:4642 with SMTP id h11-20020adff4cb000000b002f5aadb4642mr6412555wrp.41.1681749648681; Mon, 17 Apr 2023 09:40:48 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q17-20020a5d61d1000000b002faaa9a1721sm2595103wrv.58.2023.04.17.09.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 09:40:48 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo Date: Mon, 17 Apr 2023 17:40:41 +0100 Message-Id: <20230417164041.684562-11-peter.maydell@linaro.org> In-Reply-To: <20230417164041.684562-1-peter.maydell@linaro.org> References: <20230417164041.684562-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, Kyle Evans , Richard Henderson , Markus Armbruster , Laurent Vivier , Eric Blake , Warner Losh Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linaro.org The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info status' command, as we've moved that information to 'info jit'. It seems unlikely that anybody is monitoring the state of this obscure TCG setting via QMP, especially since QMP provides no means for changing the setting. So simply deprecate the field, without providing any replacement. Until we do eventually delete the member, correct the misstatements in the QAPI documentation about it. If we do find that there are users for this, then the most likely way we would provide replacement access to the information would be to put the accelerator QOM object at a well-known path such as /machine/accel, which could then be used with the existing qom-set and qom-get commands. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster --- For v3: because we're only deprecating the existing member, not trying to provide a replacement with a new name, we don't need to update the iotests that use the command. (We will when we eventually drop the deprecated member.) --- docs/about/deprecated.rst | 14 ++++++++++++++ qapi/run-state.json | 14 +++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 6f5e689aa45..d5eda0f566c 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -199,6 +199,20 @@ accepted incorrect commands will return an error. Users should make sure that all arguments passed to ``device_add`` are consistent with the documented property types. +``StatusInfo`` member ``singlestep`` (since 8.1) +'''''''''''''''''''''''''''''''''''''''''''''''' + +The ``singlestep`` member of the ``StatusInfo`` returned from the +``query-status`` command is deprecated. This member has a confusing +name and it never did what the documentation claimed or what its name +suggests. We do not believe that anybody is actually using the +information provided in this member. + +The information it reports is whether the TCG JIT is in "one +instruction per translated block" mode (which can be set on the +command line or via the HMP, but not via QMP). The information remains +available via the HMP 'info jit' command. + Human Monitor Protocol (HMP) commands ------------------------------------- diff --git a/qapi/run-state.json b/qapi/run-state.json index 9d34afa39e0..daf03a6fe9c 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -104,16 +104,24 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if VCPUs are in single-step mode +# @singlestep: true if using TCG with one guest instruction +# per translation block # # @status: the virtual machine @RunState # +# Features: +# @deprecated: Member 'singlestep' is deprecated (with no replacement). +# # Since: 0.14 # -# Notes: @singlestep is enabled through the GDB stub +# Notes: @singlestep is enabled on the command line with +# '-accel tcg,one-insn-per-tb=on', or with the HMP +# 'one-insn-per-tb' command. ## { 'struct': 'StatusInfo', - 'data': {'running': 'bool', 'singlestep': 'bool', 'status': 'RunState'} } + 'data': {'running': 'bool', + 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, + 'status': 'RunState'} } ## # @query-status: