From patchwork Mon Apr 17 16:40:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 673841 Delivered-To: patch@linaro.org Received: by 2002:adf:fcce:0:0:0:0:0 with SMTP id f14csp1604425wrs; Mon, 17 Apr 2023 09:41:06 -0700 (PDT) X-Google-Smtp-Source: AKy350YnHrFlqsuxY2XK6QnuUDayb2mRxnfF9DD7vD1cdDMtBiL/3hls5+u3GxkuVfk3Dmv0xUuf X-Received: by 2002:a05:6214:410e:b0:5e7:b5c5:5558 with SMTP id kc14-20020a056214410e00b005e7b5c55558mr16552631qvb.44.1681749666399; Mon, 17 Apr 2023 09:41:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681749666; cv=none; d=google.com; s=arc-20160816; b=qc/KqXfX7Cjd2xfRobbWOXCgDY/DCbzzowEDX8CgBbVdSWKneLTLREqzcyt0s6kZFt etjd+ngLisG+z/sHdpaH8psKFv89QuXZSxFBpKxfOll6iiV1pt3/Ox8+kqx6Dmxf24gm UG+p0Q3+iSH3YFRvEVlwOZUQNSN8/5OkEs2vTyLcEd28g8FI6Bz34glGXYhOGM+Fvfna PaITkG0nVX6gXV7Rmt/ckhR+C8G0ytWdahJKdQgNjYHzlIHKDt6BYVBJSICr/mxFjcu0 n082+9r8k5QCAJ9mgaAjLRgagbGOA9Bmbcc2juPLitPv3eM9nYBwrVLcR6nWJxui7QzU cgAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:sender:errors-to:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to:delivered-to:dkim-signature; bh=5vzGB5zyqexh5lZpRKf1Wm53aoZK4fu1hbifevUF8JI=; b=ZKsTAZBVx5lKWiWDW0XZhEkyiXK3KrZJyufCUWzIc9OJF2bvAXOqxdokLgy80GiLNR auwe16Uia2yxPSgrviORHzFNhRh6ar2wutIiIA2MmgiBEtf40FdZCgdvxoqEyH27kPjf ixBOKGJ3Go1wJedQt5qaqAIkW1aIvb6QJ1RTYlvTk8kRQmNcElXiwryknZj+AoMFdUMc L0EpwyCP+vUA1ZR3zE/Vaz/6BHsS+TL/Jb6MaqB3HJ0DJRRDOb25hg7uYw9E2frh3iIs 74gEppPQe88SVA/oKGuqNfOuoRwxQUgw0Bz0fHg2KBVnFAWAtbtBppQ4JNiqc7OiIE0G 40Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SW1aiImi; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.133.124]) by mx.google.com with ESMTPS id 8-20020ad45b88000000b005ea119e52f1si1549337qvp.486.2023.04.17.09.41.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 09:41:06 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SW1aiImi; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681749666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5vzGB5zyqexh5lZpRKf1Wm53aoZK4fu1hbifevUF8JI=; b=SW1aiImiUXqK7e5GfPy4LMTBucHfhwh4So8Qs5Iy3QmDyzax+nTLI+F0k0GzCHyZqqkxjm 2Bl9qlxBOJGdz/HpfIxE9CZ9rS2GEEAZ+FGSAwkmWR/q7l0Zz+W/OP488vENE9WhgCFn46 HyuUQ3ghiCFkEwrNzSOGqqi2weo0cms= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-SiGJ8RuXMjCSbeFevytMXw-1; Mon, 17 Apr 2023 12:41:00 -0400 X-MC-Unique: SiGJ8RuXMjCSbeFevytMXw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A73063C10239; Mon, 17 Apr 2023 16:40:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B48640C94AF; Mon, 17 Apr 2023 16:40:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D7F121946594; Mon, 17 Apr 2023 16:40:51 +0000 (UTC) X-Original-To: libvir-list@listman.corp.redhat.com Delivered-To: libvir-list@listman.corp.redhat.com Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 11EFD194658D for ; Mon, 17 Apr 2023 16:40:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 02BE840C83AC; Mon, 17 Apr 2023 16:40:51 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF25340C20FA for ; Mon, 17 Apr 2023 16:40:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D610C38149C1 for ; Mon, 17 Apr 2023 16:40:50 +0000 (UTC) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-LSTfeY70OKSWk9RSFqP5Rg-1; Mon, 17 Apr 2023 12:40:47 -0400 X-MC-Unique: LSTfeY70OKSWk9RSFqP5Rg-1 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-3f169350f05so15375185e9.3 for ; Mon, 17 Apr 2023 09:40:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681749646; x=1684341646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5vzGB5zyqexh5lZpRKf1Wm53aoZK4fu1hbifevUF8JI=; b=R5EsePLbHwELz43EYr+I497NyDhzrnjWEx8cWZuATSmGFXNX1lSR+PFceFptLDiWdc 2jOK3r6e4v1VIHgruMwj12+pyTxqu9Ju7eva3R1mxiYPxba6Fr2mBETW7klhjG9ZGbDA WO9xN5rD0F0S+EOOi8Os7VgC7igBq8GzZcHKa0Pw4hTsev1f/xT5NFxE0utYixpL3fnh GitwAnuS1r5WFprC9GGvi99Y7uBiRKU2ghqBl1kAF1u//5+qE87Geg1RiY4RiBUD5MNi pU2stWhH+HRwilcMrUvDFJ62aKTpxRBidpqy/Sd7za/7OXno+9KCHa8YkmRwvpwtALtI jBNw== X-Gm-Message-State: AAQBX9e5ggqQ9XoIO9iiQcYMlYfNf0lh5fpmxkGIRxQB7UScciizCd67 b+JqZQRvsUoc0P1BdpTcG8YCXg== X-Received: by 2002:adf:e688:0:b0:2f4:62cc:922b with SMTP id r8-20020adfe688000000b002f462cc922bmr6648536wrm.16.1681749646377; Mon, 17 Apr 2023 09:40:46 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q17-20020a5d61d1000000b002faaa9a1721sm2595103wrv.58.2023.04.17.09.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 09:40:46 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH v3 06/10] Document that -singlestep command line option is deprecated Date: Mon, 17 Apr 2023 17:40:37 +0100 Message-Id: <20230417164041.684562-7-peter.maydell@linaro.org> In-Reply-To: <20230417164041.684562-1-peter.maydell@linaro.org> References: <20230417164041.684562-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, Kyle Evans , Richard Henderson , Markus Armbruster , Laurent Vivier , Eric Blake , Warner Losh Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linaro.org Document that the -singlestep command line option is now deprecated, as it is replaced by either the TCG accelerator property 'one-insn-per-tb' for system emulation or the new '-one-insn-per-tb' option for usermode emulation, and remove the only use of the deprecated syntax from a README. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 16 ++++++++++++++++ qemu-options.hx | 5 +++-- tcg/tci/README | 2 +- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 1ca9dc33d61..3c62671dac1 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -111,6 +111,22 @@ Use ``-machine acpi=off`` instead. The HAXM project has been retired (see https://github.com/intel/haxm#status). Use "whpx" (on Windows) or "hvf" (on macOS) instead. +``-singlestep`` (since 8.1) +''''''''''''''''''''''''''' + +The ``-singlestep`` option has been turned into an accelerator property, +and given a name that better reflects what it actually does. +Use ``-accel tcg,one-insn-per-tb=on`` instead. + +User-mode emulator command line arguments +----------------------------------------- + +``-singlestep`` (since 8.1) +''''''''''''''''''''''''''' + +The ``-singlestep`` option has been given a name that better reflects +what it actually does. For both linux-user and bsd-user, use the +new ``-one-insn-per-tb`` option instead. QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/qemu-options.hx b/qemu-options.hx index 1dffd36884e..6a59e997497 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4159,10 +4159,11 @@ SRST ERST DEF("singlestep", 0, QEMU_OPTION_singlestep, \ - "-singlestep always run in singlestep mode\n", QEMU_ARCH_ALL) + "-singlestep deprecated synonym for -accel tcg,one-insn-per-tb=on\n", QEMU_ARCH_ALL) SRST ``-singlestep`` - Run the emulation in single step mode. + This is a deprecated synonym for the TCG accelerator property + ``one-insn-per-tb``. ERST DEF("preconfig", 0, QEMU_OPTION_preconfig, \ diff --git a/tcg/tci/README b/tcg/tci/README index f72a40a395a..4a8b5b54018 100644 --- a/tcg/tci/README +++ b/tcg/tci/README @@ -49,7 +49,7 @@ The only difference from running QEMU with TCI to running without TCI should be speed. Especially during development of TCI, it was very useful to compare runs with and without TCI. Create /tmp/qemu.log by - qemu-system-i386 -d in_asm,op_opt,cpu -D /tmp/qemu.log -singlestep + qemu-system-i386 -d in_asm,op_opt,cpu -D /tmp/qemu.log -accel tcg,one-insn-per-tb=on once with interpreter and once without interpreter and compare the resulting qemu.log files. This is also useful to see the effects of additional