From patchwork Fri Feb 5 20:25:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 61349 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp180821lbl; Fri, 5 Feb 2016 12:28:05 -0800 (PST) X-Received: by 10.140.106.165 with SMTP id e34mr19338158qgf.23.1454704085106; Fri, 05 Feb 2016 12:28:05 -0800 (PST) Return-Path: Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com. [209.132.183.25]) by mx.google.com with ESMTPS id a141si17539943qkb.16.2016.02.05.12.28.03 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 05 Feb 2016 12:28:05 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.25 as permitted sender) client-ip=209.132.183.25; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.25 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u15KPHJJ017894; Fri, 5 Feb 2016 15:25:17 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u15KPFim008809 for ; Fri, 5 Feb 2016 15:25:15 -0500 Received: from [10.3.113.172] (ovpn-113-172.phx2.redhat.com [10.3.113.172]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u15KPFS5009634; Fri, 5 Feb 2016 15:25:15 -0500 To: libvirt-list@redhat.com References: <56B5049E.9070000@redhat.com> From: Cole Robinson Message-ID: <56B5052A.8050903@redhat.com> Date: Fri, 5 Feb 2016 15:25:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B5049E.9070000@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Laine Stump Subject: Re: [libvirt] [PATCH 4/9] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com On 02/05/2016 03:22 PM, Cole Robinson wrote: > On 01/28/2016 03:30 PM, Cole Robinson wrote: >> When we unconditionally enable QEMU_CAPS_DEVICE, these tests need >> some massaging, so do it ahead of time to not mix it in with the >> big test refresh. >> >> - minimal-s390 is not a real world working config, so drop it >> - disk-usb was testing for an old code path that will be removed. >> instead use it to test lack of USB disk support, and rename it >> to disk-usb-nosupport. Switch xml2xml to use disk-usb-device for >> input. >> - cputune-numatune was needlessly using q35, switch it to an older >> machine type >> --- >> .../qemuxml2argv-cputune-numatune.args | 7 +-- >> .../qemuxml2argv-cputune-numatune.xml | 12 +--- >> .../qemuxml2argv-disk-usb-nosupport.xml} | 0 >> tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args | 23 -------- >> .../qemuxml2argv-minimal-s390.args | 21 ------- >> .../qemuxml2argvdata/qemuxml2argv-minimal-s390.xml | 21 ------- >> tests/qemuxml2argvtest.c | 5 +- >> .../qemuxml2xmlout-cputune-numatune.xml | 14 +---- >> .../qemuxml2xmlout-disk-cdrom-empty.xml | 36 ++++++++++++ >> .../qemuxml2xmlout-disk-drive-boot-cdrom.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-boot-disk.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-cache-directsync.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-cache-unsafe.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-cache-v2-none.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-cache-v2-wb.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-cache-v2-wt.xml | 37 +++++++++++++ >> ...xml2xmlout-disk-drive-error-policy-enospace.xml | 37 +++++++++++++ >> ...qemuxml2xmlout-disk-drive-error-policy-stop.xml | 37 +++++++++++++ >> ...out-disk-drive-error-policy-wreport-rignore.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-network-gluster.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-network-rbd-auth.xml | 42 ++++++++++++++ >> ...uxml2xmlout-disk-drive-network-rbd-ceph-env.xml | 39 +++++++++++++ >> .../qemuxml2xmlout-disk-drive-network-rbd-ipv6.xml | 40 ++++++++++++++ >> .../qemuxml2xmlout-disk-drive-network-rbd.xml | 64 ++++++++++++++++++++++ >> .../qemuxml2xmlout-disk-drive-network-sheepdog.xml | 37 +++++++++++++ >> .../qemuxml2xmlout-disk-usb-device.xml} | 6 +- >> .../qemuxml2xmloutdata/qemuxml2xmlout-migrate.xml | 30 ++++++++++ >> .../qemuxml2xmlout-misc-uuid.xml | 33 +++++++++++ >> .../qemuxml2xmlout-nographics-vga.xml | 30 ++++++++++ >> .../qemuxml2xmlout-qemu-ns-no-env.xml | 34 ++++++++++++ >> .../qemuxml2xmlout-restore-v2.xml | 30 ++++++++++ >> .../qemuxml2xmloutdata/qemuxml2xmlout-watchdog.xml | 31 +++++++++++ >> tests/qemuxml2xmltest.c | 2 +- >> 33 files changed, 865 insertions(+), 99 deletions(-) >> rename tests/{qemuxml2xmloutdata/qemuxml2xmlout-disk-usb.xml => qemuxml2argvdata/qemuxml2argv-disk-usb-nosupport.xml} (100%) >> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args >> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args >> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-cdrom-empty.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-boot-cdrom.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-boot-disk.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-cache-directsync.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-cache-unsafe.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-cache-v2-none.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-cache-v2-wb.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-cache-v2-wt.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-error-policy-enospace.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-error-policy-stop.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-error-policy-wreport-rignore.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-gluster.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-rbd-auth.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-rbd-ceph-env.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-rbd-ipv6.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-rbd.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-sheepdog.xml >> rename tests/{qemuxml2argvdata/qemuxml2argv-disk-usb.xml => qemuxml2xmloutdata/qemuxml2xmlout-disk-usb-device.xml} (90%) >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-migrate.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-misc-uuid.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-nographics-vga.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-qemu-ns-no-env.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-restore-v2.xml >> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-watchdog.xml > > All these created files were from a bad rebase. They belong to patch #2. I've > fixed locally. Please only review the changes and files mentioned in the > commit message. > > Thanks, > Cole > I attached the actual version of this patch Thanks, Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list >From cee0a05dbb69c81a25d2eb9cc88aecd711f455fd Mon Sep 17 00:00:00 2001 Message-Id: From: Cole Robinson Date: Tue, 12 Jan 2016 20:41:49 -0500 Subject: [PATCH] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code path that will be removed. instead use it to test lack of USB disk support, and rename it to disk-usb-nosupport. Switch xml2xml to use disk-usb-device for input. - cputune-numatune was needlessly using q35, switch it to an older machine type --- .../qemuxml2argv-cputune-numatune.args | 7 +++---- .../qemuxml2argv-cputune-numatune.xml | 12 +---------- .../qemuxml2argv-disk-usb-nosupport.xml} | 0 tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args | 23 ---------------------- .../qemuxml2argv-minimal-s390.args | 21 -------------------- .../qemuxml2argvdata/qemuxml2argv-minimal-s390.xml | 21 -------------------- tests/qemuxml2argvtest.c | 5 ++--- .../qemuxml2xmlout-cputune-numatune.xml | 14 +++---------- .../qemuxml2xmlout-disk-usb-device.xml} | 6 ++---- tests/qemuxml2xmltest.c | 2 +- 10 files changed, 12 insertions(+), 99 deletions(-) rename tests/{qemuxml2xmloutdata/qemuxml2xmlout-disk-usb.xml => qemuxml2argvdata/qemuxml2argv-disk-usb-nosupport.xml} (100%) delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml rename tests/{qemuxml2argvdata/qemuxml2argv-disk-usb.xml => qemuxml2xmloutdata/qemuxml2xmlout-disk-usb-device.xml} (90%) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args b/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args index 7e5678d..bde6338 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args @@ -7,16 +7,15 @@ QEMU_AUDIO_DRV=none \ /usr/bin/qemu-system-x86_64 \ -name dummy2 \ -S \ --M pc-q35-2.3 \ +-M pc-0.11 \ -m 128 \ -smp 2,maxcpus=6,sockets=6,cores=1,threads=1 \ -object iothread,id=iothread1 \ -object iothread,id=iothread2 \ -uuid 4d92ec27-9ebf-400b-ae91-20c71c647c19 \ -nographic \ +-nodefaults \ -monitor unix:/tmp/test-monitor,server,nowait \ -no-acpi \ -boot c \ --net none \ --serial none \ --parallel none +-usb diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml b/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml index 855e084..2258e96 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml @@ -13,7 +13,7 @@ - hvm + hvm @@ -22,16 +22,6 @@ destroy /usr/bin/qemu-system-x86_64 - -
- - - -
- - -
- diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-usb.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb-nosupport.xml similarity index 100% rename from tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-usb.xml rename to tests/qemuxml2argvdata/qemuxml2argv-disk-usb-nosupport.xml diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args deleted file mode 100644 index f41f8b4..0000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args +++ /dev/null @@ -1,23 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M pc \ --m 214 \ --smp 1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --monitor unix:/tmp/test-monitor,server,nowait \ --no-acpi \ --boot c \ --usb \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=ide,bus=0,unit=0 \ --usbdevice disk:/tmp/usbdisk.img \ --net none \ --serial none \ --parallel none diff --git a/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args b/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args deleted file mode 100644 index a51d1f0..0000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args +++ /dev/null @@ -1,21 +0,0 @@ -LC_ALL=C \ -PATH=/bin \ -HOME=/home/test \ -USER=test \ -LOGNAME=test \ -QEMU_AUDIO_DRV=none \ -/usr/bin/qemu \ --name QEMUGuest1 \ --S \ --M s390-virtio \ --m 214 \ --smp 1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --nographic \ --monitor unix:/tmp/test-monitor,server,nowait \ --no-acpi \ --boot c \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=virtio \ --net none \ --serial none \ --parallel none diff --git a/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml b/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml deleted file mode 100644 index 7378bd4..0000000 --- a/tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml +++ /dev/null @@ -1,21 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219100 - 219100 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu - - - - - - diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index a5d4722..a298c42 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -593,7 +593,6 @@ mymain(void) DO_TEST("minimal", NONE); DO_TEST_PARSE_ERROR("minimal-no-memory", NONE); DO_TEST("minimal-msg-timestamp", QEMU_CAPS_MSG_TIMESTAMP); - DO_TEST("minimal-s390", NONE); DO_TEST("machine-aliases1", NONE); DO_TEST("machine-aliases2", QEMU_CAPS_KVM); DO_TEST("machine-core-on", QEMU_CAPS_MACHINE_OPT, @@ -809,7 +808,7 @@ mymain(void) QEMU_CAPS_DEVICE, QEMU_CAPS_BOOTINDEX); DO_TEST_PARSE_ERROR("disk-device-lun-type-invalid", QEMU_CAPS_DEVICE, QEMU_CAPS_VIRTIO_SCSI); - DO_TEST("disk-usb", NONE); + DO_TEST_FAILURE("disk-usb-nosupport", QEMU_CAPS_DEVICE); DO_TEST("disk-usb-device", QEMU_CAPS_DEVICE, QEMU_CAPS_DEVICE_USB_STORAGE, QEMU_CAPS_NODEFCONFIG); @@ -1327,7 +1326,7 @@ mymain(void) DO_TEST_PARSE_ERROR("cputune-iothreadsched-toomuch", NONE); DO_TEST_PARSE_ERROR("cputune-vcpusched-overlap", NONE); DO_TEST("cputune-numatune", QEMU_CAPS_SMP_TOPOLOGY, - QEMU_CAPS_KVM, + QEMU_CAPS_KVM, QEMU_CAPS_DEVICE, QEMU_CAPS_OBJECT_IOTHREAD, QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_OBJECT_MEMORY_FILE); diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-numatune.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-numatune.xml index 855e084..1278b00 100644 --- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-numatune.xml +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-numatune.xml @@ -13,7 +13,7 @@ - hvm + hvm @@ -22,16 +22,8 @@ destroy /usr/bin/qemu-system-x86_64 - -
- - - -
- - -
- + + diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-usb-device.xml similarity index 90% rename from tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml rename to tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-usb-device.xml index 06d75aa..6e132cb 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-usb-device.xml @@ -15,21 +15,19 @@ /usr/bin/qemu -
- - + - + diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 0c22f53..465de8e 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -339,7 +339,7 @@ mymain(void) DO_TEST("disk-floppy"); DO_TEST("disk-many"); DO_TEST("disk-xenvbd"); - DO_TEST("disk-usb"); + DO_TEST("disk-usb-device"); DO_TEST("disk-virtio"); DO_TEST("floppy-drive-fat"); DO_TEST("disk-drive-boot-disk"); -- 2.5.0