From patchwork Tue Mar 15 19:24:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 63892 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp870008lbc; Tue, 15 Mar 2016 12:28:18 -0700 (PDT) X-Received: by 10.140.237.204 with SMTP id i195mr43463914qhc.55.1458070098615; Tue, 15 Mar 2016 12:28:18 -0700 (PDT) Return-Path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com. [209.132.183.24]) by mx.google.com with ESMTPS id t90si23976537qkl.5.2016.03.15.12.28.17 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 15 Mar 2016 12:28:18 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) client-ip=209.132.183.24; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u2FJOm8l005942; Tue, 15 Mar 2016 15:24:49 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u2FJOkss029050 for ; Tue, 15 Mar 2016 15:24:46 -0400 Received: from colepc.redhat.com (ovpn-113-66.phx2.redhat.com [10.3.113.66]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2FJOkpm011420; Tue, 15 Mar 2016 15:24:46 -0400 From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 15 Mar 2016 15:24:44 -0400 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: Don't overwrite DomainSave errors X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com These functions already report fine grained errors, there's no benefit to overwriting the error here. --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.5.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index edf39d9..36c8fb5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17632,8 +17632,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("Saving live XML config failed")); goto endjob; } @@ -17659,8 +17657,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, conf_disk->blkdeviotune = info; ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Write to config file failed")); goto endjob; } }