From patchwork Tue Apr 26 12:49:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 66696 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1592372qge; Tue, 26 Apr 2016 05:52:47 -0700 (PDT) X-Received: by 10.28.21.14 with SMTP id 14mr3472785wmv.39.1461675167388; Tue, 26 Apr 2016 05:52:47 -0700 (PDT) Return-Path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com. [209.132.183.24]) by mx.google.com with ESMTPS id cz8si2652111wjd.11.2016.04.26.05.52.46 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 26 Apr 2016 05:52:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) client-ip=209.132.183.24; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.24 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3QCnxYp021901; Tue, 26 Apr 2016 08:50:00 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3QCnwki015549 for ; Tue, 26 Apr 2016 08:49:58 -0400 Received: from colepc.redhat.com (ovpn-113-44.phx2.redhat.com [10.3.113.44]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3QCnwU2018767; Tue, 26 Apr 2016 08:49:58 -0400 From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 26 Apr 2016 08:49:54 -0400 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virsh: Document change-media --live --config confusion X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com If 'virsh change-media --live --config ...' is requested, the inactive XML is used as the template for the media change/eject. If the runtime XML has diverged from the inactive XML, say via other update operations, those changes may be undone since the command will sync all non-path XML with the inactive config. To 'fix' this would involve two passes of XML editing and calls to UpdateDevice, which is kind of a pain for a case that won't affect most users. So let's just document it instead https://bugzilla.redhat.com/show_bug.cgi?id=1243342 --- tools/virsh.pod | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/tools/virsh.pod b/tools/virsh.pod index 90ab47d..4c1b7fc 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2794,6 +2794,9 @@ the hypervisor's implementation. Both I<--live> and I<--config> flags may be given, but I<--current> is exclusive. If no flag is specified, behavior is different depending on hypervisor. +If both I<--live> and I<--config> are specified, the inactive device XML +is used as the template for the media change. If your I<--live> device XML +has received runtime changes, they may be removed. If I<--print-xml> is specified, the XML that would be used to change media is printed instead of changing the media.