From patchwork Tue Jul 17 18:37:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 10073 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id EF57B23F2A for ; Tue, 17 Jul 2012 18:39:10 +0000 (UTC) Received: from mail-yx0-f180.google.com (mail-yx0-f180.google.com [209.85.213.180]) by fiordland.canonical.com (Postfix) with ESMTP id 9F881A181BC for ; Tue, 17 Jul 2012 18:39:10 +0000 (UTC) Received: by yenq6 with SMTP id q6so803131yen.11 for ; Tue, 17 Jul 2012 11:39:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:date:from :to:cc:subject:message-id:references:mime-version:content-type :content-disposition:content-transfer-encoding:in-reply-to :user-agent:x-gm-message-state; bh=qRoQyWRQjwX+/9iQmpUJ2hczWw5rTl6N0+WOgY1hfkI=; b=VtN0lJGuv+NqAZse5uDQvfR3h0diFT+EvGwr0iH2O3X4TceWNh/vjh91WXnDIvvgM3 QLhJa54pOc6kEB5A7K4fh2w1Xob5GM8rCt7xXVlLOwkEV50TBMA1XZeXmDvNe8meTWhX Wkm4q3OmLGtKQvlkSiMZ5zZCjFqGPcBjAjewIckWEMMllpcCRMf5gaD4+QCooEcjXuMb F5raqW468FC5q2+LGuWnPDwJCnRbuEZ0P54iT7/qChbEGqL7aGH4f1l/SVP18r9g6xjt mGDfgXqxYs/AE8aolCUEzFHcnxAVrnmvVejL8qm0TwyybvVp07ueqwpcSWUErgQZyeK4 KPFw== Received: by 10.50.46.232 with SMTP id y8mr2246646igm.57.1342550349770; Tue, 17 Jul 2012 11:39:09 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.241.2 with SMTP id lc2csp23267ibb; Tue, 17 Jul 2012 11:39:09 -0700 (PDT) Received: by 10.68.236.129 with SMTP id uu1mr810314pbc.77.1342550349003; Tue, 17 Jul 2012 11:39:09 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id qd2si25964639pbb.327.2012.07.17.11.39.08 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Jul 2012 11:39:09 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by pbbrr4 with SMTP id rr4so1433680pbb.37 for ; Tue, 17 Jul 2012 11:39:08 -0700 (PDT) Received: by 10.68.229.2 with SMTP id sm2mr1487812pbc.57.1342550348498; Tue, 17 Jul 2012 11:39:08 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id ms9sm11715258pbb.43.2012.07.17.11.39.06 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Jul 2012 11:39:07 -0700 (PDT) Date: Tue, 17 Jul 2012 11:37:07 -0700 From: Anton Vorontsov To: Greg Kroah-Hartman Cc: Kees Cook , Colin Cross , Tony Luck , devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, Arnd Bergmann , patches@linaro.org, Marco Stornelli , Stephen Boyd , Thomas Meyer , linux-kernel@vger.kernel.org, arve@android.com, Jesper Juhl , John Stultz , Shuah Khan , Rebecca Schultz Zavin , WANG Cong , Andrew Morton , kernel-team@android.com, Dan Carpenter Subject: [PATCH] pstore: Headers should include all stuff they use Message-ID: <20120717183707.GA24056@lizard> References: <20120717180918.GA18671@lizard> <1342548840-22404-1-git-send-email-anton.vorontsov@linaro.org> <20120717181944.GA21957@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120717181944.GA21957@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlq6zluj8OdxpHZ+sKXOc4e5r48w4k4YnPeWZHhNT4U/g0lZvdIA3IC6pQ88PNDqJyILOpK Headers should really include all the needed prototypes, types, defines etc. to be self-contained. This is a long-standing issue, but apparently the new tracing code unearthed it (SMP=n is also a prerequisite): In file included from fs/pstore/internal.h:4:0, from fs/pstore/ftrace.c:21: include/linux/pstore.h:43:15: error: field ‘read_mutex’ has incomplete type While at it, I also added the following: linux/types.h -> size_t, phys_addr_t, uXX and friends linux/spinlock.h -> spinlock_t linux/errno.h -> Exxxx linux/time.h -> struct timespec (struct passed by value) struct module and rs_control forward declaration (passed via pointers). Signed-off-by: Anton Vorontsov --- On Tue, Jul 17, 2012 at 11:19:44AM -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2012 at 11:13:59AM -0700, Anton Vorontsov wrote: > > Headers should really include all the needed prototypes, types, defines > > > > Content-Transfer-Encoding: base64 > > That's not a nice way to send patches out, care to fix this and resend? I used 'git send-email' as normal, and it said: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OK, I checked what vger.kernel.org received, and it still says: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit And I see the email readable in the text editor. OK, with linux_banner I got what the problem is, but where base64 came from?.. :-/ Anyways, resending w/ mutt. fs/pstore/internal.h | 2 ++ include/linux/pstore.h | 6 ++++++ include/linux/pstore_ram.h | 1 + 3 files changed, 9 insertions(+) diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h index 958c48d..0d0d3b7 100644 --- a/fs/pstore/internal.h +++ b/fs/pstore/internal.h @@ -1,6 +1,8 @@ #ifndef __PSTORE_INTERNAL_H__ #define __PSTORE_INTERNAL_H__ +#include +#include #include #if NR_CPUS <= 2 && defined(CONFIG_ARM_THUMB) diff --git a/include/linux/pstore.h b/include/linux/pstore.h index 120443b..c892587 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h @@ -24,6 +24,10 @@ #include #include +#include +#include +#include +#include /* types */ enum pstore_type_id { @@ -34,6 +38,8 @@ enum pstore_type_id { PSTORE_TYPE_UNKNOWN = 255 }; +struct module; + struct pstore_info { struct module *owner; char *name; diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h index af848e1..ba2b211 100644 --- a/include/linux/pstore_ram.h +++ b/include/linux/pstore_ram.h @@ -24,6 +24,7 @@ #include struct persistent_ram_buffer; +struct rs_control; struct persistent_ram_zone { phys_addr_t paddr;