From patchwork Mon Jul 27 03:14:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 51477 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by patches.linaro.org (Postfix) with ESMTPS id 6341A22DA5 for ; Mon, 27 Jul 2015 03:14:18 +0000 (UTC) Received: by lbcjj5 with SMTP id jj5sf22893619lbc.1 for ; Sun, 26 Jul 2015 20:14:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=wu5Vt5B1tXrJACcoR7+DdMCn9pw+gc99Yf3CqVSyBcQ=; b=mmFS1bDK/6ALlnMTPmDfCDcOp2r9pISrEvL6jQwGEsKyDu86CTp/XFExqFDp9eHv4N i/Ib685ttiZb0uVgNqsAcaquHhUy3rg99NRVT95RoEXrSnZ0davV364uvy/VeAFsz8H2 eAExXKTeOf2xvu3wQHgHKxFM9JL7zLtuPxfHGjBPX9Zo0XYOBhLsR0d/g+GTRa6RMSCk tJhSr3uyEpkEh/7/blDOnQhVQ3A2/ZM5jpNfQ6sgyS9qXcDx1F7rATY5mlcdvJq7Pnnj YMBDgiPLRzsNYY1OlR8tk8B8q5cjRBERnu1nhJIm6LLshtRBdr7F9l8Lb1lVvYREegzQ HudQ== X-Gm-Message-State: ALoCoQnYg4uI0BvcnIB2CmNfaR6WGdmJtP9jg1B6LWr4RAOEa1eXxeJA5+X+fG2R9CKPPXv23d/K X-Received: by 10.112.181.37 with SMTP id dt5mr11269492lbc.10.1437966857040; Sun, 26 Jul 2015 20:14:17 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.43.47 with SMTP id t15ls552525lal.77.gmail; Sun, 26 Jul 2015 20:14:16 -0700 (PDT) X-Received: by 10.112.123.69 with SMTP id ly5mr25037422lbb.57.1437966856760; Sun, 26 Jul 2015 20:14:16 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id zs5si14175357lbb.37.2015.07.26.20.14.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 20:14:16 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by lagw2 with SMTP id w2so40924671lag.3 for ; Sun, 26 Jul 2015 20:14:16 -0700 (PDT) X-Received: by 10.152.36.102 with SMTP id p6mr24928976laj.19.1437966856624; Sun, 26 Jul 2015 20:14:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1283866lba; Sun, 26 Jul 2015 20:14:15 -0700 (PDT) X-Received: by 10.70.129.44 with SMTP id nt12mr63680176pdb.116.1437966854740; Sun, 26 Jul 2015 20:14:14 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rx6si40503404pab.219.2015.07.26.20.14.13; Sun, 26 Jul 2015 20:14:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071AbbG0DOM (ORCPT + 12 others); Sun, 26 Jul 2015 23:14:12 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:32841 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbbG0DOM (ORCPT ); Sun, 26 Jul 2015 23:14:12 -0400 Received: by padck2 with SMTP id ck2so43641411pad.0 for ; Sun, 26 Jul 2015 20:14:11 -0700 (PDT) X-Received: by 10.66.102.41 with SMTP id fl9mr62661580pab.93.1437966851394; Sun, 26 Jul 2015 20:14:11 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id v8sm26331342pdm.89.2015.07.26.20.14.09 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 26 Jul 2015 20:14:10 -0700 (PDT) Date: Mon, 27 Jul 2015 08:44:07 +0530 From: Viresh Kumar To: Bartlomiej Zolnierkiewicz Cc: Rafael Wysocki , rob.herring@linaro.org, nm@ti.com, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, arnd.bergmann@linaro.org, broonie@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, Sudeep.Holla@arm.com, viswanath.puttagunta@linaro.org, l.stach@pengutronix.de, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com, kesavan.abhilash@gmail.com, khilman@linaro.org, santosh.shilimkar@oracle.com Subject: Re: [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings Message-ID: <20150727031407.GH19944@linux> References: <2910042.ys2zsBBKt2@amdc1976> <20150709051845.GM1805@linux> <9723014.v9tt0Yn4CZ@amdc1976> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9723014.v9tt0Yn4CZ@amdc1976> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 24-07-15, 20:02, Bartlomiej Zolnierkiewicz wrote: > There is also a minor issue with of_init_opp_table() documentation > (the function can now return -EINVAL in some cases). Except these > two things the patch looks fine and once it is fixed you can add: > > Reviewed-by: Bartlomiej Zolnierkiewicz Fixed the documentation issue as: Please give your reviewed-by again as I wouldn't be fixing the u32 type issue for now and wasn't sure if you will give your RBY without that :) diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index c4ca176061b8..3ad93a7e76e5 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -1144,6 +1144,7 @@ static int _of_init_opp_table_v1(struct device *dev) * -ENODEV when 'operating-points' property is not found or is invalid data * in device node. * -ENODATA when empty 'operating-points' property is found + * -EINVAL when invalid entries are found in opp-v2 table */ int of_init_opp_table(struct device *dev) {