From patchwork Wed Jul 29 10:24:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 51636 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by patches.linaro.org (Postfix) with ESMTPS id 6EAAD22DB5 for ; Wed, 29 Jul 2015 10:24:50 +0000 (UTC) Received: by wixh2 with SMTP id h2sf5494549wix.0 for ; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=LsdZ1TEofy0qcMu/YAxYte38CHlUT9sBMr6k31YJ7mE=; b=b3CvVOrUuw5k9DVLkshg2pv+ogktO5VLbdGLyynr4RYQ/tVdXMyPTuFftXN1R+hRfV rWj1DzWPsnVoIYtURWPjPtpRqvEt77QhkAlLtW9x2OrfcxihReYse17ncRzy5PuQ2CRA OzLFMZ7dBa08NKWTkF+uugqW1wEQ0n7V+c0qQt2rdG5VQSKsYgi/nUdsDOTU9moK35mk w09N1HIkjXLQmDED1Gj7EsJNBT1bAnFZrZJKEwaKBuOw+/oPxEs0gSBVpytaLfKuwn1o EhXw5n9RBrVyxhgoO+mHgUoyH98djTWRt4qj3NM3VsQ8G9FVYYDgNC5rmkuwvLfb/vLl 0afQ== X-Gm-Message-State: ALoCoQlpAZemPokU2u7Z5lCbBDYkGHrMCio3inAGXrKyWT3LG9jQ47UUSGcqIAGIT3urb2eXvUq4 X-Received: by 10.112.51.177 with SMTP id l17mr15835611lbo.1.1438165489646; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.4 with SMTP id x4ls24046lag.100.gmail; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) X-Received: by 10.152.179.225 with SMTP id dj1mr28749940lac.53.1438165489471; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com. [209.85.217.174]) by mx.google.com with ESMTPS id lh6si17189040lbc.49.2015.07.29.03.24.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 03:24:49 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) client-ip=209.85.217.174; Received: by lbbst4 with SMTP id st4so3552656lbb.1 for ; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) X-Received: by 10.112.125.34 with SMTP id mn2mr34353321lbb.76.1438165489269; Wed, 29 Jul 2015 03:24:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp2660477lba; Wed, 29 Jul 2015 03:24:48 -0700 (PDT) X-Received: by 10.70.109.199 with SMTP id hu7mr93035687pdb.71.1438165487479; Wed, 29 Jul 2015 03:24:47 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8si8611331par.90.2015.07.29.03.24.45; Wed, 29 Jul 2015 03:24:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbbG2KYo (ORCPT + 27 others); Wed, 29 Jul 2015 06:24:44 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34242 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbbG2KYm (ORCPT ); Wed, 29 Jul 2015 06:24:42 -0400 Received: by pacan13 with SMTP id an13so3655759pac.1 for ; Wed, 29 Jul 2015 03:24:41 -0700 (PDT) X-Received: by 10.66.174.36 with SMTP id bp4mr90256897pac.133.1438165481808; Wed, 29 Jul 2015 03:24:41 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id pa1sm39910828pdb.73.2015.07.29.03.24.39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 29 Jul 2015 03:24:41 -0700 (PDT) Date: Wed, 29 Jul 2015 15:54:35 +0530 From: Viresh Kumar To: Pavel Machek Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, b.zolnierkie@samsung.com, nm@ti.com, sboyd@codeaurora.org, Tomasz Figa , Michael Turquette , Javier Martinez Canillas , Thomas Abraham , Greg Kroah-Hartman , Len Brown , open list Subject: Re: [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper Message-ID: <20150729102435.GB9584@linux> References: <20150728142713.GB17745@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150728142713.GB17745@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 28-07-15, 16:27, Pavel Machek wrote: > Typo. > > And this is not exactly most helpful comment. opp is turbo... returns > if opp was turbo. Explanation what "turbo" means in this context would > be nice. I'm pretty sure it is not about air compression :-). Does this make it any better: diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index e039cf024a6c..da8ec7f824d5 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -281,9 +281,13 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq); /** - * dev_pm_opp_is_turbo() - Returns true if opp was trubo OPP + * dev_pm_opp_is_turbo() - Returns if opp is turbo OPP or not * @opp: opp for which turbo mode is being verified * + * Turbo OPPs are not for normal use, and can be enabled (under certain + * conditions) for short duration of times to finish high throughput work + * quickly. Running on them for longer times may overheat the chip. + * * Return: true if opp is turbo opp, else false. * * Locking: This function must be called under rcu_read_lock(). opp is a rcu