From patchwork Mon Mar 18 15:23:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 15404 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7EE3623E3E for ; Mon, 18 Mar 2013 15:24:40 +0000 (UTC) Received: from mail-ve0-f178.google.com (mail-ve0-f178.google.com [209.85.128.178]) by fiordland.canonical.com (Postfix) with ESMTP id 22979A187B7 for ; Mon, 18 Mar 2013 15:24:40 +0000 (UTC) Received: by mail-ve0-f178.google.com with SMTP id db10so4411605veb.23 for ; Mon, 18 Mar 2013 08:24:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:in-reply-to:references:x-gm-message-state; bh=5UVDjwh7/HiO9fq5k2IFIN3Vk7aWNSpD+xvDQrMIrwc=; b=I4/cf0jQSBhAlN8acQZ5+SfZpLEK/+ZxlRjn7xDp2qSXrWBKEJGkMfOcd8r1bwi/7m Suw+lPNdKw2BWZXsAHhDnXKIFx52olFXgYWUrGWhk1v+vZzT+Kfcj1SCwnHzv80pJjkA z9XhN+N/SIP3EyA5glVc12kDDBS1nlHcxiCjX0e/jOWe8ZcIyaklHFEjMGAsWW/aEwFn rwxsaPFMO8/8PoC5Bu1WuYMOb753ljxF3M+UmKsegEWBlIMTY0Wcjn/qCjjyn4V6b8i6 XpvWPUcFUzCU5G5ipO9eTtvejGvMUkUMtOTOBj8f9qzz06mSSsdkdd3D/cCCwm7q7quC +DGg== X-Received: by 10.52.93.235 with SMTP id cx11mr17175108vdb.51.1363620279660; Mon, 18 Mar 2013 08:24:39 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp29016veb; Mon, 18 Mar 2013 08:24:39 -0700 (PDT) X-Received: by 10.66.13.74 with SMTP id f10mr10916878pac.146.1363620278752; Mon, 18 Mar 2013 08:24:38 -0700 (PDT) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx.google.com with ESMTPS id nq5si21458155pbc.236.2013.03.18.08.24.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Mar 2013 08:24:38 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.160.54; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.54 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) smtp.mail=viresh.kumar@linaro.org Received: by mail-pb0-f54.google.com with SMTP id rr4so6497220pbb.27 for ; Mon, 18 Mar 2013 08:24:38 -0700 (PDT) X-Received: by 10.66.253.201 with SMTP id ac9mr10929473pad.29.1363620278131; Mon, 18 Mar 2013 08:24:38 -0700 (PDT) Received: from localhost ([122.167.69.232]) by mx.google.com with ESMTPS id rr14sm20519677pbb.34.2013.03.18.08.24.31 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 08:24:37 -0700 (PDT) From: Viresh Kumar To: pjt@google.com, paul.mckenney@linaro.org, tglx@linutronix.de, tj@kernel.org, suresh.b.siddha@intel.com, venki@google.com, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org Cc: linaro-kernel@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, Arvind.Chauhan@arm.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH V3 4/7] PHYLIB: queue work on any cpu Date: Mon, 18 Mar 2013 20:53:26 +0530 Message-Id: <9a366f17b93a5e18777360481c94e6db763b45b7.1363617402.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQmSyiEHSQwGtQMkVYJ0gBNBgHKkzeFT0msaZlQM/UhKzCAmxeWye4TW2LqU0i+dHXjM7xCZ Phylib uses workqueues for multiple purposes. There is no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which isn't idle to save on power. By idle cpu (from scheduler's perspective) we mean: - Current task is idle task - nr_running == 0 - wake_list is empty This patch replaces the schedule_work() and schedule_delayed_work() routines with their queue_[delayed_]work_on_any_cpu() siblings with system_wq as parameter. These routines would look for the closest (via scheduling domains) non-idle cpu (non-idle from schedulers perspective). If the current cpu is not idle or all cpus are idle, work will be scheduled on local cpu. Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Viresh Kumar --- drivers/net/phy/phy.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 298b4c2..a517706 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -439,7 +439,7 @@ void phy_start_machine(struct phy_device *phydev, { phydev->adjust_state = handler; - schedule_delayed_work(&phydev->state_queue, HZ); + queue_delayed_work_on_any_cpu(system_wq, &phydev->state_queue, HZ); } /** @@ -527,7 +527,7 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat) disable_irq_nosync(irq); atomic_inc(&phydev->irq_disable); - schedule_work(&phydev->phy_queue); + queue_work_on_any_cpu(system_wq, &phydev->phy_queue); return IRQ_HANDLED; } @@ -682,7 +682,7 @@ static void phy_change(struct work_struct *work) /* reschedule state queue work to run as soon as possible */ cancel_delayed_work_sync(&phydev->state_queue); - schedule_delayed_work(&phydev->state_queue, 0); + queue_delayed_work_on_any_cpu(system_wq, &phydev->state_queue, 0); return; @@ -966,7 +966,8 @@ void phy_state_machine(struct work_struct *work) if (err < 0) phy_error(phydev); - schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ); + queue_delayed_work_on_any_cpu(system_wq, &phydev->state_queue, + PHY_STATE_TIME * HZ); } static inline void mmd_phy_indirect(struct mii_bus *bus, int prtad, int devad,