From patchwork Mon Mar 30 16:17:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 46528 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E26D12159A for ; Mon, 30 Mar 2015 16:17:22 +0000 (UTC) Received: by lbfb1 with SMTP id b1sf7269794lbf.2 for ; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:content-type:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe; bh=W5cmR9uhB5c05g1VLs9fPKpAlQ9dc+JMEBN6aHrPqEs=; b=lRhYINLRca4ryL9eTunaIxFBJNvmgS1DyFYMGV49z13wLCHEjGlJPkhNSxYHQfGjkn 27JqdBG5U2sl59LDmrZzZfPgXO8Hhbd6IcbTzjpU/s3w258y9vN8x2k9X2Ys+BNcThoC gu6lIXXQS1nSHVbU00Bm36vUWAPrCrV25catTnpDbEruNxqX8WSoyagUWXkDD+UgyqT0 AtlkAUUx9IPi0mGD0a1wRYkcHXuqURAwu8fAtpGsOVQU52csU3aPSlHrciAfiydr/Py0 x7xX7ajeujdvliSzoO5Hi6j1KOqwlMzm1o8DMrldSBo+tdTPGTamDjrW0+1BtBySGuf/ zexQ== X-Gm-Message-State: ALoCoQlbQnKQ042QuFbk4B3BFyhGGQ201w8n8HE8zMBRO3T4NrjXQMVCu27hF6zkXgbLvBOXO2/p X-Received: by 10.152.23.7 with SMTP id i7mr559227laf.1.1427732241874; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.181.5 with SMTP id ds5ls647908lac.20.gmail; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) X-Received: by 10.112.137.164 with SMTP id qj4mr27086591lbb.17.1427732241693; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) Received: from mail-la0-f42.google.com (mail-la0-f42.google.com. [209.85.215.42]) by mx.google.com with ESMTPS id p6si406147laj.167.2015.03.30.09.17.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 09:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) client-ip=209.85.215.42; Received: by lahp7 with SMTP id p7so89118025lah.2 for ; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) X-Received: by 10.152.36.169 with SMTP id r9mr4264791laj.29.1427732241252; Mon, 30 Mar 2015 09:17:21 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.57.201 with SMTP id k9csp1244581lbq; Mon, 30 Mar 2015 09:17:20 -0700 (PDT) X-Received: by 10.68.97.65 with SMTP id dy1mr60341125pbb.10.1427732239337; Mon, 30 Mar 2015 09:17:19 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dh2si15348858pbd.253.2015.03.30.09.17.18; Mon, 30 Mar 2015 09:17:19 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbbC3QRN (ORCPT + 27 others); Mon, 30 Mar 2015 12:17:13 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:36834 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbbC3QRJ (ORCPT ); Mon, 30 Mar 2015 12:17:09 -0400 Received: by obbps3 with SMTP id ps3so13649742obb.3 for ; Mon, 30 Mar 2015 09:17:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.255.195 with SMTP id as3mr27392452obd.56.1427732221911; Mon, 30 Mar 2015 09:17:01 -0700 (PDT) Received: by 10.182.185.36 with HTTP; Mon, 30 Mar 2015 09:17:01 -0700 (PDT) In-Reply-To: <20150330135948.GY23123@twins.programming.kicks-ass.net> References: <20150327091613.GE27490@worktop.programming.kicks-ass.net> <20150327093023.GA32047@worktop.ger.corp.intel.com> <20150328095322.GH27490@worktop.programming.kicks-ass.net> <55169723.3070006@linaro.org> <20150328134457.GK27490@worktop.programming.kicks-ass.net> <20150329102440.GC32047@worktop.ger.corp.intel.com> <20150330124746.GI21418@twins.programming.kicks-ass.net> <20150330135948.GY23123@twins.programming.kicks-ass.net> Date: Mon, 30 Mar 2015 21:47:01 +0530 Message-ID: Subject: Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work From: Viresh Kumar To: Peter Zijlstra Cc: Andrew Morton , Johannes Weiner , Christoph Lameter , Linaro Kernel Mailman List , Linux Kernel Mailing List , vinmenon@codeaurora.org, shashim@codeaurora.org, Michal Hocko , Mel Gorman , dave@stgolabs.net, Konstantin Khlebnikov , Linux Memory Management List , Suresh Siddha , Thomas Gleixner Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 30 March 2015 at 19:29, Peter Zijlstra wrote: > Yeah, so that _should_ not trigger (obviously), and while I agree with > the sentiment of sanity checks, I'm not sure its worth keeping that > variable around just for that. I read it as I can remove it then ? :) > Anyway, while I'm looking at struct tvec_base I notice the cpu member > should be second after the lock, that'll save 8 bytes on the structure > on 64bit machines. Hmm, I tried it on my macbook-pro. $ uname -a Linux vireshk 3.13.0-46-generic #79-Ubuntu SMP Tue Mar 10 20:06:50 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux $ gcc --version gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2 config: arch/x86/configs/x86_64_defconfig And all I get it is 8256 bytes, with or without the change. --- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 2d3f5c504939..afc5d74678df 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -77,12 +77,12 @@ struct tvec_root { struct tvec_base { spinlock_t lock; + int cpu; struct timer_list *running_timer; unsigned long timer_jiffies; unsigned long next_timer; unsigned long active_timers; unsigned long all_timers; - int cpu; struct tvec_root tv1; struct tvec tv2; struct tvec tv3;