From patchwork Thu Sep 12 09:21:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19993 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DF41420F59 for ; Thu, 12 Sep 2013 09:22:00 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id gf11sf11577446vcb.10 for ; Thu, 12 Sep 2013 02:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=Rot55H25vWFyIjRDBQ2tLbD75wg/TCK7PlkMh2icJLI=; b=AvquUXvCfmdYs57wXzjl0jyf7pPublq0F+yg4fDCU38QRjdwRbDOHMxJamDpmZyUJu q151I72AmuMHM2N0Jdu3oxbEtSuiZTElJ782iK+iePQ9xuWGR0ENC5n+ifcJ47cEbsUg STOChht5buLFOYMV1wH0KvHiWq5wu/XZlLAPbwjQkAAUUvjf7BLjCICQTCJGks09vyj8 3X+2ZAYm/IZbsGc+AZtsKz18X/1jXI/f2ikbcll4Z0/+OBpUGWs8geyk9GhbNEMSlFoX bNPQaERW2Rs28xrQbuLIH9AcfAxSOKFoxV5Q1eC0NfyjfEVc5ClNFEHfhGdRr2ZWmaRs TNtQ== X-Gm-Message-State: ALoCoQnvRS/D9pitY6pdJYSXkbVJ3iwXVkBiZCUW0bbqYXQ7ga4LpEcAa+FQAoeJeXQy9FfIezif X-Received: by 10.236.13.36 with SMTP id a24mr2488489yha.50.1378977720096; Thu, 12 Sep 2013 02:22:00 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.83.7 with SMTP id m7ls679422qey.0.gmail; Thu, 12 Sep 2013 02:21:59 -0700 (PDT) X-Received: by 10.52.74.100 with SMTP id s4mr50742vdv.35.1378977719892; Thu, 12 Sep 2013 02:21:59 -0700 (PDT) Received: from mail-vb0-f43.google.com (mail-vb0-f43.google.com [209.85.212.43]) by mx.google.com with ESMTPS id tf3si890065vec.106.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Sep 2013 02:21:59 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.43 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.43; Received: by mail-vb0-f43.google.com with SMTP id h11so7020976vbh.16 for ; Thu, 12 Sep 2013 02:21:59 -0700 (PDT) X-Received: by 10.220.186.202 with SMTP id ct10mr5840063vcb.14.1378977719806; Thu, 12 Sep 2013 02:21:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp8750vcz; Thu, 12 Sep 2013 02:21:58 -0700 (PDT) X-Received: by 10.182.48.194 with SMTP id o2mr50089obn.90.1378977718804; Thu, 12 Sep 2013 02:21:58 -0700 (PDT) Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by mx.google.com with ESMTPS id iz10si1696723obb.65.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Sep 2013 02:21:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.214.180 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.214.180; Received: by mail-ob0-f180.google.com with SMTP id wm4so260865obc.11 for ; Thu, 12 Sep 2013 02:21:58 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.101.198 with SMTP id fi6mr69446obb.79.1378977718484; Thu, 12 Sep 2013 02:21:58 -0700 (PDT) Received: by 10.182.28.168 with HTTP; Thu, 12 Sep 2013 02:21:58 -0700 (PDT) In-Reply-To: <52316A40.4050600@linux.vnet.ibm.com> References: <8f777cc6b41b2fed4bf71ce2adc36800353d5738.1378963070.git.viresh.kumar@linaro.org> <523161D1.9040005@linux.vnet.ibm.com> <52316A40.4050600@linux.vnet.ibm.com> Date: Thu, 12 Sep 2013 14:51:58 +0530 Message-ID: Subject: Re: [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish() From: Viresh Kumar To: "Srivatsa S. Bhat" Cc: "Rafael J. Wysocki" , Stephen Warren , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.43 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 12 September 2013 12:46, Srivatsa S. Bhat wrote: > That sounds good! Even the naming is much better, it conveys the intent > clearly. Folded below change in my patch (attached): if (frozen) Tested-by: Stephen Warren --- thanks diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index b556d46..23f5845 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1111,7 +1111,7 @@ static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, int ret; /* first sibling now owns the new sysfs dir */ - cpu_dev = get_cpu_device(cpumask_first(policy->cpus)); + cpu_dev = get_cpu_device(cpumask_any_but(policy->cpus, old_cpu)); /* Don't touch sysfs files during light-weight tear-down */