From patchwork Wed Sep 2 09:06:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 52958 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by patches.linaro.org (Postfix) with ESMTPS id D65E922E23 for ; Wed, 2 Sep 2015 09:07:26 +0000 (UTC) Received: by laeb10 with SMTP id b10sf1611308lae.1 for ; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=iRiJDTcTdDklrQsnldK4/CAJq0fTOKhKAdmJyi1jxvU=; b=e0Vk4TN+1PuK+eYWmVlFawc5xkHU5XXr2zLasCX61g9nK0gI4xGuiIEg4AZ8xWHrN5 egOJUydCAicWY6yyW0htZdBXN9GctGBkNYxzEa0z7hU2Z7pAmmTFih0odnxr49XoSnwp PW4KlAejbdhgHUbmHhCSROi5o8lteI3L6SvpA5Fq9F3LfOhcHqeQZSaq/6stA5e0irY2 IwIzVImh0F5akxq9WqjcjV8vIoyQDL9HUppz/XktoonzDMg7nZCrOBMDx2mS4rD96b1v B2pItSqwuvOdB289FzMAWPqRflAKJjbd5rwurV96d26DZ8cy4NqBVVzatnundgUADqCB C0fg== X-Gm-Message-State: ALoCoQn3UVyAVt+cU2sPhOnI6lm/kGN3Nv3551oYtoBi79ai+x0ohL/TLGMD+EGIr5Vh9C4YFoDf X-Received: by 10.194.80.69 with SMTP id p5mr8933430wjx.2.1441184845544; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.180.203 with SMTP id dq11ls46688lac.34.gmail; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) X-Received: by 10.112.138.170 with SMTP id qr10mr15369009lbb.14.1441184845358; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id ai2si19053861lbc.68.2015.09.02.02.07.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2015 02:07:25 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by lagj9 with SMTP id j9so2595961lag.2 for ; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) X-Received: by 10.112.235.130 with SMTP id um2mr15280494lbc.72.1441184845233; Wed, 02 Sep 2015 02:07:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp402274lbb; Wed, 2 Sep 2015 02:07:24 -0700 (PDT) X-Received: by 10.66.141.109 with SMTP id rn13mr53025635pab.127.1441184844074; Wed, 02 Sep 2015 02:07:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jy1si34379032pbc.120.2015.09.02.02.07.22; Wed, 02 Sep 2015 02:07:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614AbbIBJHO (ORCPT + 28 others); Wed, 2 Sep 2015 05:07:14 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36018 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbbIBJHK (ORCPT ); Wed, 2 Sep 2015 05:07:10 -0400 Received: by pacwi10 with SMTP id wi10so5056336pac.3 for ; Wed, 02 Sep 2015 02:07:10 -0700 (PDT) X-Received: by 10.68.189.161 with SMTP id gj1mr54422193pbc.4.1441184830070; Wed, 02 Sep 2015 02:07:10 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id x6sm7746273pbt.3.2015.09.02.02.07.08 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 02 Sep 2015 02:07:09 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Viresh Kumar , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] cpufreq: dt: Print error on failing to mark OPPs as shared Date: Wed, 2 Sep 2015 14:36:49 +0530 Message-Id: X-Mailer: git-send-email 2.4.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We need to explicitly mark OPPs as shared, when they are not defined with OPP-v2 bindings. This operation can potentially fail, and in that case we should at least print an error message. Fixes: 2e02d8723edf ("cpufreq: dt: Add support for operating-points-v2 bindings") Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq-dt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 8c38b5192baa..b1131cf89757 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -260,7 +260,10 @@ static int cpufreq_init(struct cpufreq_policy *policy) * OPP tables are initialized only for policy->cpu, do it for * others as well. */ - set_cpus_sharing_opps(cpu_dev, policy->cpus); + ret = set_cpus_sharing_opps(cpu_dev, policy->cpus); + if (ret) + dev_err(cpu_dev, "%s: failed to mark OPPs as shared: %d\n", + __func__, ret); of_property_read_u32(np, "clock-latency", &transition_latency); } else {