mbox series

[v3,0/6] acpi: numa: add target support for generic port to HMAT parsing

Message ID 168686408822.2950427.16242077816997472103.stgit@djiang5-mobl3
Headers show
Series acpi: numa: add target support for generic port to HMAT parsing | expand

Message

Dave Jiang June 15, 2023, 9:23 p.m. UTC
v3:
- Break out ACPI_SRAT_DEVICE_HANDLE_SIZE define. Merged into ACPICA repo.
- Break out code in hmat_parse_locality() to improve readability. (Jonathan)
- Drop continue after setting gen target access data. (Jonathan)
v2:
- Add check for memory type for setting GENPORT access data. (Jonathan)
- NODE_ACCESS_CLASS_GENPORT to NODE_ACCESS_CLASS_GENPORT_SINK
- Change strncmp() to memcmp() for device handle compare

Hi Rafael,
Please consider acking this series. Dan will take it through his CXL tree.
This is the second set of ACPI changes that's part of the "cxl: Add support for
QTG ID retrieval for CXL subsystem" [1]. It has dependency on the patch [2]
that was sent to you and GregKH and Greg has ack'd. But it's independent of the
first set of ACPI changes [3]. The series adds support to store the device handle
from the SRAT Generic Port Affinity Structure in correlation with a proximity
domain. And later on the HMAT is parsed and the performance data is stored
associated with the proximity domain. A helper function is added to allow the CXL
driver to retrieve the performance data that matches with the device handle later
on. The full series of CXL code is at this git repo [4] for usage reference.


[1]: https://lore.kernel.org/linux-cxl/168193556660.1178687.15477509915255912089.stgit@djiang5-mobl3/T/#t 
[2]: https://lore.kernel.org/lkml/168332248685.2190392.1983307884583782116.stgit@djiang5-mobl3/
[3]: https://lore.kernel.org/linux-acpi/168330787964.2042604.17648905811002211147.stgit@djiang5-mobl3/T/#t
[4]: https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/log/?h=cxl-qtg

---

Dave Jiang (6):
      acpi: numa: Create enum for memory_target access coordinates indexing
      ACPICA: Add a define for size of acpi_srat_generic_affinity DeviceHandle
      acpi: numa: Add genport target allocation to the HMAT parsing
      acpi: Break out nesting for hmat_parse_locality()
      acpi: numa: Add setting of generic port system locality attributes
      acpi: numa: Add helper function to retrieve the performance attributes


 drivers/acpi/numa/hmat.c | 151 +++++++++++++++++++++++++++++++++------
 include/acpi/actbl3.h    |   4 +-
 include/linux/acpi.h     |  12 ++++
 3 files changed, 144 insertions(+), 23 deletions(-)

--

Comments

Rafael J. Wysocki June 16, 2023, 5:58 p.m. UTC | #1
On Thu, Jun 15, 2023 at 11:23 PM Dave Jiang <dave.jiang@intel.com> wrote:
>
> v3:
> - Break out ACPI_SRAT_DEVICE_HANDLE_SIZE define. Merged into ACPICA repo.
> - Break out code in hmat_parse_locality() to improve readability. (Jonathan)
> - Drop continue after setting gen target access data. (Jonathan)
> v2:
> - Add check for memory type for setting GENPORT access data. (Jonathan)
> - NODE_ACCESS_CLASS_GENPORT to NODE_ACCESS_CLASS_GENPORT_SINK
> - Change strncmp() to memcmp() for device handle compare
>
> Hi Rafael,
> Please consider acking this series.

Sure.

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> Dan will take it through his CXL tree.

Works for me!

> This is the second set of ACPI changes that's part of the "cxl: Add support for
> QTG ID retrieval for CXL subsystem" [1]. It has dependency on the patch [2]
> that was sent to you and GregKH and Greg has ack'd. But it's independent of the
> first set of ACPI changes [3]. The series adds support to store the device handle
> from the SRAT Generic Port Affinity Structure in correlation with a proximity
> domain. And later on the HMAT is parsed and the performance data is stored
> associated with the proximity domain. A helper function is added to allow the CXL
> driver to retrieve the performance data that matches with the device handle later
> on. The full series of CXL code is at this git repo [4] for usage reference.
>
>
> [1]: https://lore.kernel.org/linux-cxl/168193556660.1178687.15477509915255912089.stgit@djiang5-mobl3/T/#t
> [2]: https://lore.kernel.org/lkml/168332248685.2190392.1983307884583782116.stgit@djiang5-mobl3/
> [3]: https://lore.kernel.org/linux-acpi/168330787964.2042604.17648905811002211147.stgit@djiang5-mobl3/T/#t
> [4]: https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/log/?h=cxl-qtg
>
> ---
>
> Dave Jiang (6):
>       acpi: numa: Create enum for memory_target access coordinates indexing
>       ACPICA: Add a define for size of acpi_srat_generic_affinity DeviceHandle
>       acpi: numa: Add genport target allocation to the HMAT parsing
>       acpi: Break out nesting for hmat_parse_locality()
>       acpi: numa: Add setting of generic port system locality attributes
>       acpi: numa: Add helper function to retrieve the performance attributes
>
>
>  drivers/acpi/numa/hmat.c | 151 +++++++++++++++++++++++++++++++++------
>  include/acpi/actbl3.h    |   4 +-
>  include/linux/acpi.h     |  12 ++++
>  3 files changed, 144 insertions(+), 23 deletions(-)
>
> --
>