| Message ID | 20221027031458.2855599-1-LeoLiu-oc@zhaoxin.com |
|---|---|
| Headers | show |
| Series | Parse the PCIE AER structure and set to relevant registers | expand |
On 10/26/22 8:14 PM, LeoLiu-oc wrote: > From: leoliu-oc <leoliu-oc@zhaoxin.com> > > HEST PCIE AER error source information describes the Uncorrectable Error > Severity, CorrectableError Mask and other aer register's value to write to the /s/CorrectableError/Correctable Error /s/aer/AER > bridge's Correctable Error Mask register. Can you add spec reference? > > leoliu-oc (5): > ACPI/APEI: Add apei_hest_parse_aer() > ACPI/APEI: remove static from apei_hest_parse() > ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges > ACPI/PCI: Add pci_acpi_program_hest_aer_params() > ACPI/PCI: config pcie devices's aer register > > drivers/acpi/apei/hest.c | 121 +++++++++++++++++++++++++++++++++- > drivers/pci/pci-acpi.c | 92 ++++++++++++++++++++++++++ > drivers/pci/pci.h | 5 ++ > drivers/pci/probe.c | 1 + > include/acpi/actbl1.h | 69 +++++++++++++++++++ > include/acpi/apei.h | 9 +++ > include/uapi/linux/pci_regs.h | 5 ++ > 7 files changed, 300 insertions(+), 2 deletions(-) >
On Thu, Oct 27, 2022 at 11:14:58AM +0800, LeoLiu-oc wrote: > From: leoliu-oc <leoliu-oc@zhaoxin.com> > > HEST PCIE AER error source information describes the Uncorrectable Error > Severity, CorrectableError Mask and other aer register's value to write to the > bridge's Correctable Error Mask register. I guess the point is to extract register values from HEST PCI Express AER structures (ACPI r6.5, sec 18.3.2.4, etc.) and program them into AER Capabilities? > leoliu-oc (5): > ACPI/APEI: Add apei_hest_parse_aer() > ACPI/APEI: remove static from apei_hest_parse() > ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges > ACPI/PCI: Add pci_acpi_program_hest_aer_params() > ACPI/PCI: config pcie devices's aer register If/when you repost this, it would be nice if the patches ([1/5], [2/5], etc) were responses to the cover letter ([0/5]). Since they're not responses, b4 doesn't know they're connected and can't grab the whole series at once. Also capitalize the subject lines consistently and s/PCIE/PCIe/ and s/pcie/PCIe/ and s/aer/AER/, e.g., ACPI/APEI: Add apei_hest_parse_aer() ACPI/APEI: Remove static from apei_hest_parse() PCI: Add AER #defines for PCIe/PCI-X bridges ACPI/PCI: Add pci_acpi_program_hest_aer_params() ACPI/PCI: Configure devices AER registers based on HEST > drivers/acpi/apei/hest.c | 121 +++++++++++++++++++++++++++++++++- > drivers/pci/pci-acpi.c | 92 ++++++++++++++++++++++++++ > drivers/pci/pci.h | 5 ++ > drivers/pci/probe.c | 1 + > include/acpi/actbl1.h | 69 +++++++++++++++++++ > include/acpi/apei.h | 9 +++ > include/uapi/linux/pci_regs.h | 5 ++ > 7 files changed, 300 insertions(+), 2 deletions(-) > > -- > 2.20.1 >
在 2022/10/27 12:17, Sathyanarayanan Kuppuswamy 写道: > > > On 10/26/22 8:14 PM, LeoLiu-oc wrote: >> From: leoliu-oc <leoliu-oc@zhaoxin.com> >> >> HEST PCIE AER error source information describes the Uncorrectable Error >> Severity, CorrectableError Mask and other aer register's value to write to the > > /s/CorrectableError/Correctable Error > /s/aer/AER Got it. I will modify this in next version patch set. Thanks leoliu-oc > >> bridge's Correctable Error Mask register. > > Can you add spec reference? > Please refer to Section 18.3.2 ACPI Error Source of acpi spec v6.3. Links to the online versions of ACPI Spec 6.3 is https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/18_ACPI_Platform_Error_Interfaces/error-source-discovery.html#acpi-error-source. Section 18.3.2.4 describes PCI Express Root Port AER Structure, section 18.3.2.5 describes PCI Express Device AER Structure, section 18.3.2.6 describes PCI Express/PCI-X Bridge AER Structure. Thanks leoliu-oc >> >> leoliu-oc (5): >> ACPI/APEI: Add apei_hest_parse_aer() >> ACPI/APEI: remove static from apei_hest_parse() >> ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges >> ACPI/PCI: Add pci_acpi_program_hest_aer_params() >> ACPI/PCI: config pcie devices's aer register >> >> drivers/acpi/apei/hest.c | 121 +++++++++++++++++++++++++++++++++- >> drivers/pci/pci-acpi.c | 92 ++++++++++++++++++++++++++ >> drivers/pci/pci.h | 5 ++ >> drivers/pci/probe.c | 1 + >> include/acpi/actbl1.h | 69 +++++++++++++++++++ >> include/acpi/apei.h | 9 +++ >> include/uapi/linux/pci_regs.h | 5 ++ >> 7 files changed, 300 insertions(+), 2 deletions(-) >> >
From: leoliu-oc <leoliu-oc@zhaoxin.com> HEST PCIE AER error source information describes the Uncorrectable Error Severity, CorrectableError Mask and other aer register's value to write to the bridge's Correctable Error Mask register. leoliu-oc (5): ACPI/APEI: Add apei_hest_parse_aer() ACPI/APEI: remove static from apei_hest_parse() ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges ACPI/PCI: Add pci_acpi_program_hest_aer_params() ACPI/PCI: config pcie devices's aer register drivers/acpi/apei/hest.c | 121 +++++++++++++++++++++++++++++++++- drivers/pci/pci-acpi.c | 92 ++++++++++++++++++++++++++ drivers/pci/pci.h | 5 ++ drivers/pci/probe.c | 1 + include/acpi/actbl1.h | 69 +++++++++++++++++++ include/acpi/apei.h | 9 +++ include/uapi/linux/pci_regs.h | 5 ++ 7 files changed, 300 insertions(+), 2 deletions(-)