| Message ID | 20221124102056.393220-1-treapking@chromium.org |
|---|---|
| Headers | show |
| Series | Register Type-C mode-switch in DP bridge endpoints | expand |
On Thu, Nov 24, 2022 at 06:20:56PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the "lane_swap" > state based on the entered alternate mode for a specific Type-C > connector, which ends up updating the lane swap registers of the it6505 > chip. ... > config DRM_ITE_IT6505 > tristate "ITE IT6505 DisplayPort bridge" > depends on OF > + depends on TYPEC || TYPEC=n > select DRM_DISPLAY_DP_HELPER > select DRM_DISPLAY_HDCP_HELPER > select DRM_DISPLAY_HELPER Something went wrong with the indentation. Perhaps you need to fix it first. ... > #include <drm/drm_edid.h> > #include <drm/drm_print.h> > #include <drm/drm_probe_helper.h> > +#include <drm/drm_of.h> Make it ordered? ... > +struct it6505_port_data { > + bool dp_connected; Perhaps make it last? > + struct typec_mux_dev *typec_mux; > + struct it6505 *it6505; > +}; ... > +static void it6505_typec_ports_update(struct it6505 *it6505) > +{ > + usleep_range(3000, 4000); > + > + if (it6505->typec_ports[0].dp_connected && it6505->typec_ports[1].dp_connected) > + /* Both ports available, do nothing to retain the current one. */ > + return; > + else if (it6505->typec_ports[0].dp_connected) > + it6505->lane_swap = false; > + else if (it6505->typec_ports[1].dp_connected) > + it6505->lane_swap = true; > + > + usleep_range(3000, 4000); > +} As per previous patch comments. Also, comment out these long sleeps. Why they are needed. ... > + int ret = pm_runtime_get_sync(dev); > + > + /* > + * On system resume, mux_set can be triggered before > + * pm_runtime_force_resume re-enables runtime power management. We refer to the functions as func(). > + * Handling the error here to make sure the bridge is powered on. > + */ > + if (ret < 0) > + it6505_poweron(it6505); This seems needed a bit more of explanation, esp. why you leave PM runtime reference count bumped up. ... > + num_lanes = drm_of_get_data_lanes_count(node, 0, 2); > + if (num_lanes <= 0) { > + dev_err(dev, "Error on getting data lanes count: %d\n", > + num_lanes); > + return num_lanes; > + } > + > + ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, num_lanes); > + if (ret) { > + dev_err(dev, "Failed to read the data-lanes variable: %d\n", > + ret); > + return ret; > + } > + > + for (i = 0; i < num_lanes; i++) { > + if (port_num != -1 && port_num != dp_lanes[i] / 2) { > + dev_err(dev, "Invalid data lane numbers\n"); > + return -EINVAL; > + } As per previous patch comments. > + port_num = dp_lanes[i] / 2; > + } The above seems like tons of duplicating code that drivers need to implement. Can we shrink that burden by adding some library functions?
On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file make: *** [Makefile:1492: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command.
Sorry for accidentally using the tab characters. Will fix this in v7. On Fri, Nov 25, 2022 at 1:39 AM Rob Herring <robh@kernel.org> wrote: > > > On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or regular DisplayPort output ports. > > > > Update the binding to accommodate this usage by introducing a > > data-lanes and a mode-switch property on endpoints. > > > > Also include the link to the product brief in the bindings. > > > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > > > --- > > > > Changes in v6: > > - Remove switches node and use endpoints and data-lanes property to > > describe the connections. > > > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > > 1 file changed, 71 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: [error] syntax error: found character '\t' that cannot start any token (syntax) > > dtschema/dtc warnings/errors: > make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts' > Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/analogix,anx7625.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:218:1: found character '\t' that cannot start any token > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml: ignoring, error parsing file > make: *** [Makefile:1492: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221124102056.393220-4-treapking@chromium.org > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command. >
Hi Andy, Thanks for reviewing the patch. On Thu, Nov 24, 2022 at 8:23 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Nov 24, 2022 at 06:20:56PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available in Device Tree. Configure the "lane_swap" > > state based on the entered alternate mode for a specific Type-C > > connector, which ends up updating the lane swap registers of the it6505 > > chip. > > ... > > > config DRM_ITE_IT6505 > > tristate "ITE IT6505 DisplayPort bridge" > > depends on OF > > + depends on TYPEC || TYPEC=n > > select DRM_DISPLAY_DP_HELPER > > select DRM_DISPLAY_HDCP_HELPER > > select DRM_DISPLAY_HELPER > > Something went wrong with the indentation. Perhaps you need to fix it first. > > ... > > > #include <drm/drm_edid.h> > > #include <drm/drm_print.h> > > #include <drm/drm_probe_helper.h> > > +#include <drm/drm_of.h> > > Make it ordered? Will fix it in v7. > > ... > > > +struct it6505_port_data { > > > + bool dp_connected; > > Perhaps make it last? Will fix it in v7. > > > + struct typec_mux_dev *typec_mux; > > + struct it6505 *it6505; > > +}; > > ... > > > +static void it6505_typec_ports_update(struct it6505 *it6505) > > +{ > > + usleep_range(3000, 4000); > > + > > + if (it6505->typec_ports[0].dp_connected && it6505->typec_ports[1].dp_connected) > > + /* Both ports available, do nothing to retain the current one. */ > > + return; > > + else if (it6505->typec_ports[0].dp_connected) > > + it6505->lane_swap = false; > > + else if (it6505->typec_ports[1].dp_connected) > > + it6505->lane_swap = true; > > + > > + usleep_range(3000, 4000); > > +} > > As per previous patch comments. Will update it in v7. > > Also, comment out these long sleeps. Why they are needed. Actually, it turns out that these sleeps are not needed. I'll remove it in v7. > > ... > > > + int ret = pm_runtime_get_sync(dev); > > + > > + /* > > + * On system resume, mux_set can be triggered before > > + * pm_runtime_force_resume re-enables runtime power management. > > We refer to the functions as func(). Will fix this in v7. > > > + * Handling the error here to make sure the bridge is powered on. > > + */ > > + if (ret < 0) > > + it6505_poweron(it6505); > > This seems needed a bit more of explanation, esp. why you leave PM runtime > reference count bumped up. pm_runtime_force_suspend() disables runtime PM when the device enters suspend, and sometime it6505_typec_mux_set() is called before pm_runtime_force_resume brings runtime PM back. We force power up the bridge in this case and leave the ref count incremented to make the future pm_runtime_(get|put)_sync() calls balanced. I'll include more explanations around this in v7. > > ... > > > + num_lanes = drm_of_get_data_lanes_count(node, 0, 2); > > + if (num_lanes <= 0) { > > + dev_err(dev, "Error on getting data lanes count: %d\n", > > + num_lanes); > > + return num_lanes; > > + } > > + > > + ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, num_lanes); > > + if (ret) { > > + dev_err(dev, "Failed to read the data-lanes variable: %d\n", > > + ret); > > + return ret; > > + } > > + > > + for (i = 0; i < num_lanes; i++) { > > + if (port_num != -1 && port_num != dp_lanes[i] / 2) { > > + dev_err(dev, "Invalid data lane numbers\n"); > > + return -EINVAL; > > + } > > As per previous patch comments. I'll remove this part in v7 and try to figure out how to do similar checking with schemas. > > > + port_num = dp_lanes[i] / 2; > > + } > > The above seems like tons of duplicating code that drivers need to implement. > Can we shrink that burden by adding some library functions? Could you advise where this lib file should go, and what the namings can be? The "port-switching" logic is specific to some of the DP bridges, and I'm not sure what kinds of naming/structure fit into this case. Thanks and regards, Pin-yen > > -- > With Best Regards, > Andy Shevchenko > >
Hi Andy, Thanks for reviewing the patch. On Thu, Nov 24, 2022 at 8:18 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Nov 24, 2022 at 06:20:54PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available in Device Tree. Configure the crosspoint > > switch based on the entered alternate mode for a specific Type-C > > connector. > > ... > > > +static void anx7625_typec_two_ports_update(struct anx7625_data *ctx) > > +{ > > + if (ctx->typec_ports[0].dp_connected && ctx->typec_ports[1].dp_connected) > > + /* Both ports available, do nothing to retain the current one. */ > > + return; > > > + else if (ctx->typec_ports[0].dp_connected) > > This 'else' is redundant. I would rewrite above as > > /* Check if both ports available and do nothing to retain the current one */ > if (ctx->typec_ports[0].dp_connected && ctx->typec_ports[1].dp_connected) > return; > > if (ctx->typec_ports[0].dp_connected) > > > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_NORMAL); > > + else if (ctx->typec_ports[1].dp_connected) > > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_REVERSE); > > +} Thanks for the detailed suggestion. I'll adapt this in v7. > > ... > > > + data->dp_connected = (state->alt && state->alt->svid == USB_TYPEC_DP_SID && > > + state->alt->mode == USB_TYPEC_DP_MODE); > > Parentheses are not needed. Will fix this in v7. > > ... > > > + /* > > + * <0 1> refers to SSRX1/SSTX1, and <2 3> refers to SSRX2/SSTX2. > > + */ > > + for (i = 0; i < num_lanes; i++) { > > > + if (port_num != -1 && port_num != dp_lanes[i] / 2) { > > + dev_err(dev, "Invalid data lane numbers\n"); > > + return -EINVAL; > > + } > > According to Rob Linux must not validate device tree. If you need it, use > proper YAML schema. > > > + port_num = dp_lanes[i] / 2; > > + } > I'll remove this from the driver in v7. > ... > > > + if (!ctx->num_typec_switches) { > > + dev_warn(dev, "No Type-C switches node found\n"); > > > + return ret; > > Why not to return 0 explicitly? Will update to just "return 0" in v7. > > > + } > > ... > > > + ctx->typec_ports = devm_kcalloc( > > Broken indentation. Will fix in v7 > > > + dev, ctx->num_typec_switches, sizeof(struct anx7625_port_data), > > + GFP_KERNEL); > > + if (!ctx->typec_ports) > > + return -ENOMEM; > > ... > > > +struct anx7625_port_data { > > > + bool dp_connected; > > You can save some bytes on some architectures if move this to be last field. Thanks for the suggestion. I'll do so in v7 > > > + struct typec_mux_dev *typec_mux; > > + struct anx7625_data *ctx; > > +}; > > -- > With Best Regards, > Andy Shevchenko > >