[0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers

Message ID	20240822173810.11090-1-W_Armin@gmx.de
Headers	show Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EBA8487AE; Thu, 22 Aug 2024 17:38:55 +0000 (UTC) From: Armin Wolf <W_Armin@gmx.de> To: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com, luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers Date: Thu, 22 Aug 2024 19:38:05 +0200 Message-Id: <20240822173810.11090-1-W_Armin@gmx.de> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable UI-OutboundReport: notjunk:1;M01:P0:Mq5Vv18SZrA=;ntV1+pe2Xv0Dp8y7JS6S4MW3SFE o37wrXcePso/wmz8qO+rKqvcsGp30GdNGI6xoyrXierNMp/DA8aH+vAwjnEuqYrSzsP6x1+G3 HwktzJqICJdob5KsNYHb0kiysfU688EoWBIfEzzVi+Vbl7g2a8FjvPGhNKGZhwPI7ONAp+BsK HwPSbFf8IPDtHqHk0wOP1dILPgkL8xgdmODIntwwjOz57ep6YD840J0RPXfmD1pYupUlyP3Sc k+MqtiphMbp2fw+lpIr9BFvgE3dNoq0dToKWdYC8u+1U/SnzKgjTM2F55fXaBT5DSVKPsLdM0 9h7OSUtux/qQjy5seBRrHhuCrKrwvR1waciGsNkDRPCCobCxC8gv/h28GDmHV2L7rvZREq4RB /MbDelqM0iHe8mmzLRPzKCg7xL99ppV8n3iZub3V5XayCkpVRlrtAmi3XT5R381Bl5cSf2jPv 8AY10VmyEX1X1QeBFL41Spv6p2ukhpMPFDXj2QVNEgdkrtyD0dw6VUWDk9yPUGqLvYzniD4Ep 8bIXXvFyjlR4nWIw14LyHIve0bCMNPP0q9fjjv9OuK2RGMVRrtFw5HlaDXGzc3+6ygnZQgHPu kveGUPkDbtWvwOJDVI5eNU6Py3zT9GAUk7PZuLUxSNhaBgi9y8uj1S4W/sXKwViq9k2gpdFvz xxcUz0GVsrZve0lE7KGKxv511WL2Vc5KzDwlz9HaemlUanRN3ylAMjE3VvtwJm2O5wsKDpn4a dMFOw0xmMWFFSsEsY719pdCGtr4Y9elBMi2Cht1G8OR9S28/UgwUbrvJMMGyoHlmn/9wWttld sgOSQRy4DO82GH31H4kauHcw==
Series	platform/x86: wmi: Pass event data directly to legacy notify handlers \| expand [0/5] platform/x86: wmi: Pass event data directly to legacy notify handlers [1/5] platform/x86: wmi: Pass event data directly to legacy notify handlers [2/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists [3/5] platform/x86: wmi: Remove wmi_get_event_data() [4/5] platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data() [5/5] platform/x86: wmi: Call both legacy and WMI driver notify handlers

Message ID

20240822173810.11090-1-W_Armin@gmx.de

Headers

From: Armin Wolf <W_Armin@gmx.de>
To: james@equiv.tech,
	jlee@suse.com,
	corentin.chary@gmail.com,
	luke@ljones.dev,
	matan@svgalib.org,
	coproscefalo@gmail.com
Cc: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	rafael@kernel.org,
	lenb@kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-hwmon@vger.kernel.org,
	linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] platform/x86: wmi: Pass event data directly to legacy
 notify handlers
Date: Thu, 22 Aug 2024 19:38:05 +0200
Message-Id: <20240822173810.11090-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Mq5Vv18SZrA=;ntV1+pe2Xv0Dp8y7JS6S4MW3SFE
 o37wrXcePso/wmz8qO+rKqvcsGp30GdNGI6xoyrXierNMp/DA8aH+vAwjnEuqYrSzsP6x1+G3
 HwktzJqICJdob5KsNYHb0kiysfU688EoWBIfEzzVi+Vbl7g2a8FjvPGhNKGZhwPI7ONAp+BsK
 HwPSbFf8IPDtHqHk0wOP1dILPgkL8xgdmODIntwwjOz57ep6YD840J0RPXfmD1pYupUlyP3Sc
 k+MqtiphMbp2fw+lpIr9BFvgE3dNoq0dToKWdYC8u+1U/SnzKgjTM2F55fXaBT5DSVKPsLdM0
 9h7OSUtux/qQjy5seBRrHhuCrKrwvR1waciGsNkDRPCCobCxC8gv/h28GDmHV2L7rvZREq4RB
 /MbDelqM0iHe8mmzLRPzKCg7xL99ppV8n3iZub3V5XayCkpVRlrtAmi3XT5R381Bl5cSf2jPv
 8AY10VmyEX1X1QeBFL41Spv6p2ukhpMPFDXj2QVNEgdkrtyD0dw6VUWDk9yPUGqLvYzniD4Ep
 8bIXXvFyjlR4nWIw14LyHIve0bCMNPP0q9fjjv9OuK2RGMVRrtFw5HlaDXGzc3+6ygnZQgHPu
 kveGUPkDbtWvwOJDVI5eNU6Py3zT9GAUk7PZuLUxSNhaBgi9y8uj1S4W/sXKwViq9k2gpdFvz
 xxcUz0GVsrZve0lE7KGKxv511WL2Vc5KzDwlz9HaemlUanRN3ylAMjE3VvtwJm2O5wsKDpn4a
 dMFOw0xmMWFFSsEsY719pdCGtr4Y9elBMi2Cht1G8OR9S28/UgwUbrvJMMGyoHlmn/9wWttld
 sgOSQRy4DO82GH31H4kauHcw==

Series

platform/x86: wmi: Pass event data directly to legacy notify handlers | expand

Message

Armin Wolf Aug. 22, 2024, 5:38 p.m. UTC

The current legacy WMI handlers are susceptible to picking up wrong
WMI event data on systems where different WMI devices share some
notification IDs.

Prevent this by letting the WMI driver core taking care of retrieving
the event data. This also simplifies the legacy WMI handlers and their
implementation inside the WMI driver core.

The first patch converts all legacy WMI notify handlers to stop using
wmi_get_event_data() and instead use the new event data provided by
the WMI driver core.
The second patch fixes a minor issue discovered inside the
hp-wmi-sensors driver, and the remaining patches perform some cleanups.

The patch series was tested on a Dell Inspiron 3505 and a Acer Aspire
E1-731 and appears to work.

Armin Wolf (5):
  platform/x86: wmi: Pass event data directly to legacy notify handlers
  hwmon: (hp-wmi-sensors) Check if WMI event data exists
  platform/x86: wmi: Remove wmi_get_event_data()
  platform/x86: wmi: Merge get_event_data() with wmi_get_notify_data()
  platform/x86: wmi: Call both legacy and WMI driver notify handlers

 drivers/hwmon/hp-wmi-sensors.c           |  20 +---
 drivers/platform/x86/acer-wmi.c          |  16 +--
 drivers/platform/x86/asus-wmi.c          |  19 +--
 drivers/platform/x86/dell/dell-wmi-aio.c |  13 +--
 drivers/platform/x86/hp/hp-wmi.c         |  16 +--
 drivers/platform/x86/huawei-wmi.c        |  14 +--
 drivers/platform/x86/lg-laptop.c         |  13 +--
 drivers/platform/x86/msi-wmi.c           |  20 +---
 drivers/platform/x86/toshiba-wmi.c       |  15 +--
 drivers/platform/x86/wmi.c               | 143 ++++++-----------------
 include/linux/acpi.h                     |   3 +-
 11 files changed, 53 insertions(+), 239 deletions(-)

--
2.39.2