mbox series

[0/5] ACPI: battery: various cleanups

Message ID 20240904-acpi-battery-cleanups-v1-0-a3bf74f22d40@weissschuh.net
Headers show
Series ACPI: battery: various cleanups | expand

Message

Thomas Weißschuh Sept. 4, 2024, 7:12 a.m. UTC
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (5):
      ACPI: battery: check result of register_pm_notifier()
      ACPI: battery: allocate driver data through devm_ APIs
      ACPI: battery: initialize mutexes through devm_ APIs
      ACPI: battery: use DEFINE_SIMPLE_DEV_PM_OPS
      ACPI: battery: install notify handler through ACPI core

 drivers/acpi/battery.c | 41 +++++++++++------------------------------
 1 file changed, 11 insertions(+), 30 deletions(-)
---
base-commit: 88fac17500f4ea49c7bac136cf1b27e7b9980075
change-id: 20240904-acpi-battery-cleanups-98903bf44bd0

Best regards,

Comments

Rafael J. Wysocki Sept. 4, 2024, 12:44 p.m. UTC | #1
On Wed, Sep 4, 2024 at 9:13 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (5):
>       ACPI: battery: check result of register_pm_notifier()
>       ACPI: battery: allocate driver data through devm_ APIs
>       ACPI: battery: initialize mutexes through devm_ APIs
>       ACPI: battery: use DEFINE_SIMPLE_DEV_PM_OPS
>       ACPI: battery: install notify handler through ACPI core
>
>  drivers/acpi/battery.c | 41 +++++++++++------------------------------
>  1 file changed, 11 insertions(+), 30 deletions(-)
> ---

Since it is a bit late in the cycle and this material does not appear
to be urgent, I'd prefer to defer it until 6.12-rc1 is out.
Thomas Weißschuh Oct. 5, 2024, 7:27 a.m. UTC | #2
Hi Rafael,

On 2024-09-04 14:44:33+0200, Rafael J. Wysocki wrote:
> On Wed, Sep 4, 2024 at 9:13 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > Thomas Weißschuh (5):
> >       ACPI: battery: check result of register_pm_notifier()
> >       ACPI: battery: allocate driver data through devm_ APIs
> >       ACPI: battery: initialize mutexes through devm_ APIs
> >       ACPI: battery: use DEFINE_SIMPLE_DEV_PM_OPS
> >       ACPI: battery: install notify handler through ACPI core
> >
> >  drivers/acpi/battery.c | 41 +++++++++++------------------------------
> >  1 file changed, 11 insertions(+), 30 deletions(-)
> > ---
> 
> Since it is a bit late in the cycle and this material does not appear
> to be urgent, I'd prefer to defer it until 6.12-rc1 is out.

6.12-rc1 is out and other patches have been queued.
Did this one fall through the cracks?


Thanks,
Thomas
Rafael J. Wysocki Oct. 7, 2024, 4:49 p.m. UTC | #3
On Mon, Oct 7, 2024 at 5:14 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Sat, Oct 5, 2024 at 9:27 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
> >
> > Hi Rafael,
> >
> > On 2024-09-04 14:44:33+0200, Rafael J. Wysocki wrote:
> > > On Wed, Sep 4, 2024 at 9:13 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
> > > >
> > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > > > ---
> > > > Thomas Weißschuh (5):
> > > >       ACPI: battery: check result of register_pm_notifier()
> > > >       ACPI: battery: allocate driver data through devm_ APIs
> > > >       ACPI: battery: initialize mutexes through devm_ APIs
> > > >       ACPI: battery: use DEFINE_SIMPLE_DEV_PM_OPS
> > > >       ACPI: battery: install notify handler through ACPI core
> > > >
> > > >  drivers/acpi/battery.c | 41 +++++++++++------------------------------
> > > >  1 file changed, 11 insertions(+), 30 deletions(-)
> > > > ---
> > >
> > > Since it is a bit late in the cycle and this material does not appear
> > > to be urgent, I'd prefer to defer it until 6.12-rc1 is out.
> >
> > 6.12-rc1 is out and other patches have been queued.
> > Did this one fall through the cracks?
>
> No, it didn't.
>
> There were a couple of ACPI battery driver fixes I wanted to go in
> before this series and they are in -rc2, so I'm going to apply it now.

And now applied except for the last patch which goes against the plan
to turn the ACPI battery driver into a platform one (which it should
be in the first place).