mbox series

[0/4] PCI: Constify 'struct bin_attribute'

Message ID 20241202-sysfs-const-bin_attr-pci-v1-0-c32360f495a7@weissschuh.net
Headers show
Series PCI: Constify 'struct bin_attribute' | expand

Message

Thomas Weißschuh Dec. 2, 2024, 7:02 p.m. UTC 
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

The usage of read_new/write_new/bin_attrs_new is a transition mechanism
and will be reverted after the transition is complete.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (4):
      PCI/sysfs: Constify 'struct bin_attribute'
      PCI/VPD: Constify 'struct bin_attribute'
      PCI/P2PDMA: Constify 'struct bin_attribute'
      PCI/ACPI: Constify 'struct bin_attribute'

 drivers/pci/hotplug/acpiphp_ibm.c |  6 +++---
 drivers/pci/p2pdma.c              |  6 +++---
 drivers/pci/pci-sysfs.c           | 42 +++++++++++++++++++--------------------
 drivers/pci/vpd.c                 | 14 ++++++-------
 4 files changed, 34 insertions(+), 34 deletions(-)
---
base-commit: e70140ba0d2b1a30467d4af6bcfe761327b9ec95
change-id: 20241201-sysfs-const-bin_attr-pci-be2425e1a856

Best regards,

Comments

Bjorn Helgaas Dec. 3, 2024, 9:32 p.m. UTC | #1 
On Mon, Dec 02, 2024 at 08:02:56PM +0100, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
> 
> The usage of read_new/write_new/bin_attrs_new is a transition mechanism
> and will be reverted after the transition is complete.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Applied to pci/constify for v6.14, thanks.

Logan, I converted your response at
https://lore.kernel.org/all/003d2d13-13be-4f05-80f8-61e14ddb9c83@deltatee.com/
to include "Reviewed-by".

Let me know if that's not what you intended.

> ---
> Thomas Weißschuh (4):
>       PCI/sysfs: Constify 'struct bin_attribute'
>       PCI/VPD: Constify 'struct bin_attribute'
>       PCI/P2PDMA: Constify 'struct bin_attribute'
>       PCI/ACPI: Constify 'struct bin_attribute'
> 
>  drivers/pci/hotplug/acpiphp_ibm.c |  6 +++---
>  drivers/pci/p2pdma.c              |  6 +++---
>  drivers/pci/pci-sysfs.c           | 42 +++++++++++++++++++--------------------
>  drivers/pci/vpd.c                 | 14 ++++++-------
>  4 files changed, 34 insertions(+), 34 deletions(-)
> ---
> base-commit: e70140ba0d2b1a30467d4af6bcfe761327b9ec95
> change-id: 20241201-sysfs-const-bin_attr-pci-be2425e1a856
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>