mbox series

[v2,0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes

Message ID 5640233.DvuYhMxLoT@kreacher
Headers show
Series rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes | expand

Message

Rafael J. Wysocki Nov. 9, 2022, 12:05 p.m. UTC 
Hi All,

This is a v2 of the series previously posted as

https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/

The first three patches in the series have not changed since then (I have
considered moving the last patch, which is a fix, to the front, but that turns
out to be a bit cumbersome and not really worth the effort).

This series of patches does some assorted ACPI-related cleanups to the CMOS RTC
driver:
- redundant static variable is dropped,
- code duplication is reduced,
- code is relocated so as to drop a few unnecessary forward declarations of
  functions,
- functions are renamed to avoid confusion,
and fixes up an issue in the driver removal path.

Thanks!

Comments

Zhang, Rui Nov. 10, 2022, noon UTC | #1 
On Wed, 2022-11-09 at 13:05 +0100, Rafael J. Wysocki wrote:
> Hi All,
> 
> This is a v2 of the series previously posted as
> 
> https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/
> 
> The first three patches in the series have not changed since then (I
> have
> considered moving the last patch, which is a fix, to the front, but
> that turns
> out to be a bit cumbersome and not really worth the effort).
> 
> This series of patches does some assorted ACPI-related cleanups to
> the CMOS RTC
> driver:
> - redundant static variable is dropped,
> - code duplication is reduced,
> - code is relocated so as to drop a few unnecessary forward
> declarations of
>   functions,
> - functions are renamed to avoid confusion,
> and fixes up an issue in the driver removal path.
> 
> 
> 

Reviewed-by: Zhang Rui <rui.zhang@intel.com>

And I have tested the patch series on a platform with both
use_acpi_alarm parameter set and cleared, the ACPI RTC fixed event
works as expected, for both runtime and suspend wakeups.

So
Tested-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui
Alexandre Belloni Nov. 15, 2022, 8:08 p.m. UTC | #2 
On Wed, 09 Nov 2022 13:05:13 +0100, Rafael J. Wysocki wrote:
> This is a v2 of the series previously posted as
> 
> https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/
> 
> The first three patches in the series have not changed since then (I have
> considered moving the last patch, which is a fix, to the front, but that turns
> out to be a bit cumbersome and not really worth the effort).
> 
> [...]

Applied, thanks!

[1/5] rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()
      commit: 508ccdfb86b21da37ad091003a4d4567709d5dfb
[2/5] rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()
      commit: 375bbba09692fe4c5218eddee8e312dd733fa846
[3/5] rtc: rtc-cmos: Eliminate forward declarations of some functions
      commit: dca4d3b71c8a09a16951add656711fbd6f5bfbb0
[4/5] rtc: rtc-cmos: Rename ACPI-related functions
      commit: d13e9ad9f5146f066a5c5a1cc993d09e4fb21ead
[5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal
      commit: 83ebb7b3036d151ee39a4a752018665648fc3bd4

Best regards,