mbox series

[v7,0/3] serial: 8250_pnp: Support configurable reg shift property

Message ID cover.1712890897.git.albanhuang@tencent.com
Headers show
Series serial: 8250_pnp: Support configurable reg shift property | expand

Message

Guanbing Huang April 12, 2024, 3:23 a.m. UTC 
From: Guanbing Huang <albanhuang@tencent.com>

The 16550a serial port based on the ACPI table requires obtaining the
reg-shift attribute. In the ACPI scenario, If the reg-shift property
is not configured like in DTS, the 16550a serial driver cannot read or
write controller registers properly during initialization.

To address the issue of configuring the reg-shift property, the 
__uart_read_properties() universal interface is called to implement it.
Adaptation of PNP devices is done in the __uart_read_properties() function.

Guanbing Huang (3):
  PNP: Add dev_is_pnp() macro
  serial: port: Add support of PNP IRQ to __uart_read_properties()
  serial: 8250_pnp: Support configurable reg shift property

 drivers/tty/serial/8250/8250_pnp.c | 40 +++++++++++++++++++-----------
 drivers/tty/serial/serial_port.c   |  7 +++++-
 include/linux/pnp.h                |  4 +++
 3 files changed, 35 insertions(+), 16 deletions(-)

Comments

Andy Shevchenko April 12, 2024, 3:29 p.m. UTC | #1 
On Fri, Apr 12, 2024 at 11:24:12AM +0800, Guanbing Huang wrote:

...

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I haven't given this tag _explicitly_ as it's a new code and I answered in
the previous email that I will give one for the new version.

...

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404100523.b06UvPSB-lkp@intel.com/

No, the new feature can't be reported.

...

Please, try again.