From patchwork Wed May 28 07:39:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 31039 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f198.google.com (mail-ig0-f198.google.com [209.85.213.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 27BE0203C3 for ; Wed, 28 May 2014 07:40:33 +0000 (UTC) Received: by mail-ig0-f198.google.com with SMTP id uq10sf6621382igb.1 for ; Wed, 28 May 2014 00:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=wWUAJDTBvTRPrurtGgjj0tqksK5T6oE11WU6PRl/YMU=; b=Chnujk0Twqg7x7V2Nxb4xUlt7UIUvevQi6u1UZuR18WzUuCEk44fjwQEeEi2t990MX CmHoLuqaQLvk/pxTCkkwA2nt6x9ztEpvxTadUuAPAuxs6oUNbLbQIBz35qb0hT3WdEfT xNA1FsPTAlm8q1OPXvZ2N6+5Uh20lX5a2ujWbBPcZ0WevV+h8KjIld1VJcy7AukBExIF l89jX7vNGxDC7Z8Ckog4lnxK86GkN2dK8maI7Kv1jIswUIL59Jl/pm80mRetmgB9esOf j8uezj0/8+SpCgZVaR6zBBYkr0w48HkP6Mx/F7ImFoGlRQ0TtEyTxjsaY2W1YYNrqehe V/bQ== X-Gm-Message-State: ALoCoQlkUp2r5li/MGzXOfIDHyyAJnjFg4HoHCSorQXC/ovxzokX5XO4tdE43I902OMACaaFJOAc X-Received: by 10.43.156.13 with SMTP id lk13mr6386552icc.29.1401262832718; Wed, 28 May 2014 00:40:32 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.86.163 with SMTP id p32ls3566442qgd.42.gmail; Wed, 28 May 2014 00:40:32 -0700 (PDT) X-Received: by 10.58.195.130 with SMTP id ie2mr32598789vec.3.1401262832481; Wed, 28 May 2014 00:40:32 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id ks14si217524veb.45.2014.05.28.00.40.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 May 2014 00:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.169 as permitted sender) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id jx11so11999341veb.14 for ; Wed, 28 May 2014 00:40:32 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr32568662vco.25.1401262832399; Wed, 28 May 2014 00:40:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp180610vcb; Wed, 28 May 2014 00:40:31 -0700 (PDT) X-Received: by 10.68.203.233 with SMTP id kt9mr43871291pbc.61.1401262831650; Wed, 28 May 2014 00:40:31 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id be6si22528447pac.1.2014.05.28.00.40.31; Wed, 28 May 2014 00:40:31 -0700 (PDT) Received-SPF: none (google.com: linux-acpi-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121AbaE1Hk2 (ORCPT + 8 others); Wed, 28 May 2014 03:40:28 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:51060 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754320AbaE1Hjz (ORCPT ); Wed, 28 May 2014 03:39:55 -0400 Received: by mail-we0-f177.google.com with SMTP id x48so10806530wes.36 for ; Wed, 28 May 2014 00:39:54 -0700 (PDT) X-Received: by 10.180.93.101 with SMTP id ct5mr46218328wib.23.1401262794172; Wed, 28 May 2014 00:39:54 -0700 (PDT) Received: from tn-HP3-PC.semihalf.com ([80.82.22.190]) by mx.google.com with ESMTPSA id ga10sm41135474wjb.23.2014.05.28.00.39.52 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 May 2014 00:39:53 -0700 (PDT) From: Tomasz Nowicki To: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, m.chehab@samsung.com, bp@suse.de Cc: linux-edac@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Tomasz Nowicki Subject: [PATCH v2 4/5] apei, ghes, nmi: Factor out NMI arch-specific calls. Date: Wed, 28 May 2014 09:39:29 +0200 Message-Id: <1401262770-25343-5-git-send-email-tomasz.nowicki@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1401262770-25343-1-git-send-email-tomasz.nowicki@linaro.org> References: <1401262770-25343-1-git-send-email-tomasz.nowicki@linaro.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tomasz.nowicki@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Similar to MCE related patch, all NMI architectural calls are abstracted. Also, we are providing corresponding X86 functions' content. Signed-off-by: Tomasz Nowicki --- arch/x86/kernel/acpi/apei.c | 25 +++++++++++++++++++++++++ drivers/acpi/apei/apei-base.c | 19 +++++++++++++++++++ drivers/acpi/apei/ghes.c | 14 ++++++-------- include/acpi/apei.h | 7 +++++++ 4 files changed, 57 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c index dca2852..221a3a6 100644 --- a/arch/x86/kernel/acpi/apei.c +++ b/arch/x86/kernel/acpi/apei.c @@ -12,9 +12,12 @@ * GNU General Public License for more details. */ +#include #include #include +#include +#include int apei_arch_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data) { @@ -54,3 +57,25 @@ void apei_arch_report_mem_error(int sev, struct cper_sec_mem_err *mem_err) apei_mce_report_mem_error(sev, mem_err); #endif } + +int arch_apei_register_nmi(int (*nmi_handler)(unsigned int, struct pt_regs *), + const char *name) +{ + struct nmiaction apei_nmi_action = { + .handler = nmi_handler, + .name = name, + .flags = 0, + }; + + return __register_nmi_handler(NMI_LOCAL, &apei_nmi_action); +} + +void arch_apei_unregister_nmi(const char *name) +{ + unregister_nmi_handler(NMI_LOCAL, name); +} + +void arch_apei_nmi_oops_begin(void) +{ + oops_begin(); +} diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c index 4a11c1a..78c2a26 100644 --- a/drivers/acpi/apei/apei-base.c +++ b/drivers/acpi/apei/apei-base.c @@ -758,6 +758,25 @@ void __weak apei_arch_report_mem_error(int sev, } EXPORT_SYMBOL_GPL(apei_arch_report_mem_error); +int __weak arch_apei_register_nmi( + __attribute__((unused)) int (*nmi_handler)(unsigned int, + struct pt_regs *), + const char *name) +{ + return -ENOSYS; +} +EXPORT_SYMBOL_GPL(arch_apei_register_nmi); + +void __weak arch_apei_unregister_nmi(const char *name) +{ +} +EXPORT_SYMBOL_GPL(arch_apei_unregister_nmi); + +void __weak arch_apei_nmi_oops_begin(void) +{ +} +EXPORT_SYMBOL_GPL(arch_apei_nmi_oops_begin); + int apei_osc_setup(void) { static u8 whea_uuid_str[] = "ed855e0c-6c90-47bf-a62a-26de0fc5ad5c"; diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 750b04e..3c42629 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -51,7 +51,6 @@ #include #include #include -#include #include "apei-internal.h" @@ -817,7 +816,7 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) { struct ghes *ghes, *ghes_global = NULL; int sev, sev_global = -1; - int ret = NMI_DONE; + int ret = APEI_NMI_DONE; BUG_ON(!IS_ENABLED(CONFIG_ACPI_APEI_NMI)); @@ -832,14 +831,14 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) sev_global = sev; ghes_global = ghes; } - ret = NMI_HANDLED; + ret = APEI_NMI_HANDLED; } - if (ret == NMI_DONE) + if (ret == APEI_NMI_DONE) goto out; if (sev_global >= GHES_SEV_PANIC) { - oops_begin(); + arch_apei_nmi_oops_begin(); ghes_print_queued_estatus(); __ghes_print_estatus(KERN_EMERG, ghes_global->generic, ghes_global->estatus); @@ -909,8 +908,7 @@ static int ghes_notify_init_nmi(struct ghes *ghes) ghes_estatus_pool_expand(len); mutex_lock(&ghes_list_mutex); if (list_empty(&ghes_nmi)) - status = register_nmi_handler(NMI_LOCAL, ghes_notify_nmi, 0, - "ghes"); + status = arch_apei_register_nmi(ghes_notify_nmi, "ghes"); list_add_rcu(&ghes->list, &ghes_nmi); mutex_unlock(&ghes_list_mutex); @@ -924,7 +922,7 @@ static void ghes_notify_remove_nmi(struct ghes *ghes) mutex_lock(&ghes_list_mutex); list_del_rcu(&ghes->list); if (list_empty(&ghes_nmi)) - unregister_nmi_handler(NMI_LOCAL, "ghes"); + arch_apei_unregister_nmi("ghes"); mutex_unlock(&ghes_list_mutex); /* * To synchronize with NMI handler, ghes can only be diff --git a/include/acpi/apei.h b/include/acpi/apei.h index 62b9d1c..348e1ea 100644 --- a/include/acpi/apei.h +++ b/include/acpi/apei.h @@ -14,6 +14,9 @@ #define APEI_ERST_CLEAR_RECORD _IOW('E', 1, u64) #define APEI_ERST_GET_RECORD_COUNT _IOR('E', 2, u32) +#define APEI_NMI_DONE 0 +#define APEI_NMI_HANDLED 1 + #ifdef __KERNEL__ extern bool hest_disable; @@ -44,6 +47,10 @@ int erst_clear(u64 record_id); int apei_arch_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data); void apei_arch_report_mem_error(int sev, struct cper_sec_mem_err *mem_err); +int arch_apei_register_nmi(int (*nmi_handler)(unsigned int, struct pt_regs *), + const char *name); +void arch_apei_unregister_nmi(const char *name); +void arch_apei_nmi_oops_begin(void); #endif #endif