From patchwork Fri Oct 30 22:31:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Stone X-Patchwork-Id: 55861 Delivered-To: patches@linaro.org Received: by 10.112.61.134 with SMTP id p6csp114344lbr; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) X-Received: by 10.68.68.132 with SMTP id w4mr8364815pbt.137.1446244324823; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) Return-Path: Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com. [2607:f8b0:400e:c03::231]) by mx.google.com with ESMTPS id dl2si4209083pbc.134.2015.10.30.15.32.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2015 15:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of al.stone@linaro.org designates 2607:f8b0:400e:c03::231 as permitted sender) client-ip=2607:f8b0:400e:c03::231; Authentication-Results: mx.google.com; spf=pass (google.com: domain of al.stone@linaro.org designates 2607:f8b0:400e:c03::231 as permitted sender) smtp.mailfrom=al.stone@linaro.org; dkim=pass header.i=@linaro_org.20150623.gappssmtp.com Received: by pacfv9 with SMTP id fv9so89493943pac.3 for ; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=PwT5q5mNFzKBthyVCuvDhV1AzbvRRK4b5E077DfysAs=; b=oxebTCZgQL3Gn1wxtdftfhq7noGH++aYv4cCZe6QGopoKEx8ZfLhlcTWoXC4HRGsDb Z+P9AeH3UhpZydzPvscVXnra7WyY6tTdwLPeVlXbbrFzar0A39pGoG9kwzMMbzMmK+4z wGI5un3cPauZf2O+wwxOA/ziUHrn1G7P8LEa6mTQFhMztu3rvmGQ38PtrMeEi6wGJMtK i2IZK/5Ac2Vp4RTZCstwAYYfStnEJRlnToSjaKoZj/t+N0cc59cFUZHOE/WjW/0Levv0 bOBd3ORtETkmZifcZ73CW+dYqeKJKXvrFMgVI/UKNloHgxkHY9N2GAyH4I31H81XAzmp 4LWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PwT5q5mNFzKBthyVCuvDhV1AzbvRRK4b5E077DfysAs=; b=g5unI4LrmNHJmCAUgGaQY3fL0ffuxevXLRT1TE/cQRzbFV1851qCqEAExtljvE7fXW NhZ30AND6gpwThh+RA7xT5CJma9bV2I3RcZTauYuKvP9NCGBqzZIe/MjDhxgF9UGuikl oYLKUleZbnAExtnm9B5Nq3uDzVmDei2B+RdLypiecdtpMV//+ER1LEG92QAaUJL0tjqx HG4Z9L7LJTNjT5gGh2qXnK4FXaqv6r9EWbkstdMlgttjt8QuD1X04SwQGbNRYIV8aNUy HEv1YkbnW5EuhAHtuEPm4oCSVoCsozLyEe/mHYOuc7n/IZ0rM0ZDjczo82VKFg+701k+ IUWQ== X-Gm-Message-State: ALoCoQmrR18ecFRG2yTRBPASQu58idPwvE1+UrWJeiumlXigOoZshuTuKK8jkHqEv2XzEqWWuUbU X-Received: by 10.68.143.98 with SMTP id sd2mr11399822pbb.70.1446244324466; Fri, 30 Oct 2015 15:32:04 -0700 (PDT) Return-Path: Received: from fidelio.ahs3.com (c-50-134-239-249.hsd1.co.comcast.net. [50.134.239.249]) by smtp.googlemail.com with ESMTPSA id hl2sm10069778pbb.58.2015.10.30.15.32.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2015 15:32:02 -0700 (PDT) From: Al Stone To: fwts-devel@lists.ubuntu.com Cc: linaro-acpi@lists.linaro.org, patches@linaro.org, Al Stone Subject: [PATCH] ACPI: MADT: update GICC flag checks for ACPI 6.0 Date: Fri, 30 Oct 2015 16:31:54 -0600 Message-Id: <1446244314-2317-1-git-send-email-al.stone@linaro.org> X-Mailer: git-send-email 2.4.3 In the ACPI 6.0 spec, the flags field of the MADT GICC subtable uses three bits, not two. Correct the flag mask to do the test properly. Signed-off-by: Al Stone --- src/acpi/madt/madt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.4.3 diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c index f776745..1f19848 100644 --- a/src/acpi/madt/madt.c +++ b/src/acpi/madt/madt.c @@ -226,7 +226,7 @@ static int madt_test1(fwts_framework *fw) "MADT GIC C Structure reserved field should be zero, " "instead got 0x%" PRIx32 ".", gic->reserved); } - if (gic->flags & 0xfffffffc) { + if (gic->flags & 0xfffffff8) { passed = false; fwts_failed(fw, LOG_LEVEL_MEDIUM, "MADTGICFLags",