From patchwork Wed Mar 20 18:49:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suzuki K Poulose X-Patchwork-Id: 160702 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp625516jan; Wed, 20 Mar 2019 11:50:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZpuZAPjRkruYkmX3PYlSQThxrKKP0T3KQx1PWKYxuL0v4Jm4WtJ8WGXomdN6lSr58kD6Y X-Received: by 2002:aa7:8589:: with SMTP id w9mr9276297pfn.97.1553107812272; Wed, 20 Mar 2019 11:50:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553107812; cv=none; d=google.com; s=arc-20160816; b=GjxYtLWw5aj6FphEhGXbjlskt3zcDVfuVn4mgoXPTXfGlEC2O2LdtUXeYCLIn5f3uH P6V9JeC8kNpi9t2puWkxO/u8vSQz0UXf5Zoh28MHo2IZESBjCwx6AJ4Uit1cCmEm32si +x4ulbMm7BXB/fpPhCRKe8hiTOdc0yaKlX4E5/5HghW2Mewczn5P1cPoonSDw62PAg9R ndAC/iUW8KTVfF2ULM/O1RkHZGmjjE/cCptRXqERMvdiUlFtr+jGJ+kexEumpDhPsYeW 7Quk4rH0N5htTR9DJS5PTwCbaDxU49ZlDETV5sLm7oJQtdIYREcxfeh2gkkZPGce+Ui+ bXHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=zwPwAtrUh/RwYbuXGwlZcoyoc4vZNB1FhYv85F/wIBs=; b=CzCb2/UkYJpty9kt+rmMhB83V3AKpzde/XWqLNS+8pHu3MetdL2APOjd5bB+U0Lp7Q l07LrF5T0LF87dyIEdGHh2+MPLB8RQ4M09vFPtEul1tuvQvtvr922YevCDpfu6MIXH9A Ib1aB4T3QSu2QKsHldTAhjOf05BuxRGnZNbb0/EaNbuwMc3DOR0IRvsVtt2G2e/D4Wpt +G/AruKEmzguGH8uPkewdsQm1GlargsFfdzonxIU4zU1fDC3JbTWgh5NfLBclklNZoWK 4GYJrMbuf5mp3FdZNaG0IIHGNKdVboDvUuXxRt5JIEltH2gwHe4t1QonunYj5Jadxtle 2u6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-acpi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 102si2570781plb.247.2019.03.20.11.50.12; Wed, 20 Mar 2019 11:50:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-acpi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-acpi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbfCTSuL (ORCPT + 9 others); Wed, 20 Mar 2019 14:50:11 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44780 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfCTSuL (ORCPT ); Wed, 20 Mar 2019 14:50:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3514A78; Wed, 20 Mar 2019 11:50:10 -0700 (PDT) Received: from en101.cambridge.arm.com (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4E1113F59C; Wed, 20 Mar 2019 11:50:09 -0700 (PDT) From: Suzuki K Poulose To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, robert.walker@arm.com, Suzuki K Poulose , Mathieu Poirier Subject: [PATCH 01/25] coresight: tmc: Report DMA setup failures Date: Wed, 20 Mar 2019 18:49:18 +0000 Message-Id: <1553107783-3340-2-git-send-email-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org If we failed to setup the DMA mask for TMC-ETR, report the error before failing the probe. Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-tmc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index 2a02da3..647b6aa 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -340,6 +340,8 @@ static inline bool tmc_etr_can_use_sg(struct tmc_drvdata *drvdata) static int tmc_etr_setup_caps(struct tmc_drvdata *drvdata, u32 devid, void *dev_caps) { + int rc; + u32 dma_mask = 0; /* Set the unadvertised capabilities */ @@ -369,7 +371,10 @@ static int tmc_etr_setup_caps(struct tmc_drvdata *drvdata, dma_mask = 40; } - return dma_set_mask_and_coherent(drvdata->dev, DMA_BIT_MASK(dma_mask)); + rc = dma_set_mask_and_coherent(drvdata->dev, DMA_BIT_MASK(dma_mask)); + if (rc) + dev_err(drvdata->dev, "Failed to setup DMA mask: %d\n", rc); + return rc; } static int tmc_probe(struct amba_device *adev, const struct amba_id *id)