From patchwork Wed Aug 31 13:57:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 601468 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905F3ECAAD1 for ; Wed, 31 Aug 2022 13:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbiHaN5m (ORCPT ); Wed, 31 Aug 2022 09:57:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiHaN5k (ORCPT ); Wed, 31 Aug 2022 09:57:40 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EB90D5EAD; Wed, 31 Aug 2022 06:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661954259; x=1693490259; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=dtL+8Cys9Oexa2+abpB8VdNGZHy6gFiiShpIowTcEGw=; b=V0V0LK8SS/I5/3znce7CCRCSZKnVpae2CWsNsoUOlpA1sRaXNY8FMwwf SCey28JGP+b6kq7YfIRAfnBgwHDDLoaFZMWb+gDUfiHo2R6XaM2zXbQKv +RnsA2cH4G7X9ifNLAzUqjbZBgBQ+qzp5zjBFhLTAjk8VTsZVUQ2y9oMp 6BV8PAVtRQMRBEWDsUtuL3u/+zzSYjTVSyo5w6CnBBe+OxXEHKMjqB5cK H1TDzt092ay+PiM0VbWil0hgdSrxOU2+XIzFvHROfP9slxF4Okj/QjQ7q G+DMalPG4HN3/FnquOqvslW1GC3s+1hfBQ2VgepyBjtXamqGRshA9MxSL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="381748176" X-IronPort-AV: E=Sophos;i="5.93,278,1654585200"; d="scan'208";a="381748176" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 06:57:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,278,1654585200"; d="scan'208";a="940441946" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 31 Aug 2022 06:57:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DEFB1174; Wed, 31 Aug 2022 16:57:50 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg , Hans de Goede Subject: [PATCH v3 1/3] ACPI: PMIC: Use sizeof() instead of hard coded value Date: Wed, 31 Aug 2022 16:57:47 +0300 Message-Id: <20220831135749.78743-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org It's better to use sizeof() of a given buffer than spreading a hard coded value. Signed-off-by: Andy Shevchenko Reviewed-by: Mika Westerberg --- v3: added tag (Mika) drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 2 +- drivers/acpi/pmic/intel_pmic_xpower.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c index 418eec523025..6c2a6da430ed 100644 --- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c +++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c @@ -87,7 +87,7 @@ static int chtdc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg) { u8 buf[2]; - if (regmap_bulk_read(regmap, reg, buf, 2)) + if (regmap_bulk_read(regmap, reg, buf, sizeof(buf))) return -EIO; /* stored in big-endian */ diff --git a/drivers/acpi/pmic/intel_pmic_xpower.c b/drivers/acpi/pmic/intel_pmic_xpower.c index 61bbe4c24d87..33c5e85294cd 100644 --- a/drivers/acpi/pmic/intel_pmic_xpower.c +++ b/drivers/acpi/pmic/intel_pmic_xpower.c @@ -255,7 +255,7 @@ static int intel_xpower_pmic_get_raw_temp(struct regmap *regmap, int reg) if (ret) return ret; - ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, 2); + ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, sizeof(buf)); if (ret == 0) ret = (buf[0] << 4) + ((buf[1] >> 4) & 0x0f);