From patchwork Mon Oct 24 13:32:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 618174 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BDBFA373F for ; Mon, 24 Oct 2022 17:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbiJXRqb (ORCPT ); Mon, 24 Oct 2022 13:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbiJXRqI (ORCPT ); Mon, 24 Oct 2022 13:46:08 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91371402B; Mon, 24 Oct 2022 09:21:47 -0700 (PDT) Received: from dimapc.. (109-252-112-196.nat.spd-mgts.ru [109.252.112.196]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id B44C26602392; Mon, 24 Oct 2022 14:32:41 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666618362; bh=u87ew5WStQa1OcE49Cx4+qk9li4JUF1ysNYDmcXZvW8=; h=From:To:Cc:Subject:Date:From; b=Gfl5BW51TJWaPipe7us0VY0nkPs169wp2yrEQ6roCLJ9fciK0Cl35mQK2rQEAMIm7 g53nXlsVVwWLTuSjdY4Jxc6Q7tA0VcG1c+3tctEyit+jKgZ8tkbo7ZdQ1DFoMTMk5R nUDnk6LNdv0ZmsXrJFaDs9TC0kgR8h1kHQmxl33GJQqcfY6//V+pk2YKhGVQFaDjWH 85TeW2MQvl6zLyGJltO5TiHMyQV2Ni3cJWrvYBKSWRLH5Vvt5AXE2OxE7lz02IAp9y EyZrzyV4UWmkk7rY17smLOy1DO++qHTd7QgoaT4rapJohI/YIT+4h6WDQDJ2UTJngg W3traQREgX7Rw== From: Dmitry Osipenko To: "Rafael J. Wysocki" , Len Brown , Hans de Goede , Akihiko Odaki Cc: kernel@collabora.com, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] ACPI: video: Fix missing native backlight on Chromebooks Date: Mon, 24 Oct 2022 16:32:01 +0300 Message-Id: <20221024133201.43753-1-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found. Suggested-by: Hans de Goede Fixes: b1d36e73cc1c ("drm/i915: Don't register backlight when another backlight should be used (v2)") Signed-off-by: Dmitry Osipenko --- drivers/acpi/video_detect.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 0d9064a9804c..8ed5021de6fb 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present(void) +{ + return acpi_dev_found("GOOG0004"); +} + /* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,9 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) return acpi_backlight_video; } + if (google_cros_ec_present()) + return acpi_backlight_native; + /* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }