From patchwork Mon Nov 21 06:40:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 627558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648F6C4332F for ; Mon, 21 Nov 2022 06:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbiKUGmq (ORCPT ); Mon, 21 Nov 2022 01:42:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiKUGmo (ORCPT ); Mon, 21 Nov 2022 01:42:44 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A0A10BA; Sun, 20 Nov 2022 22:42:33 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NFyVP0QgDzRpPK; Mon, 21 Nov 2022 14:42:05 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 14:42:31 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 14:42:31 +0800 From: Yang Yingliang To: , CC: , , , , , Subject: [PATCH] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint() Date: Mon, 21 Nov 2022 14:40:49 +0800 Message-ID: <20221121064049.1173345-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The 'parent' returned by fwnode_graph_get_port_parent() with refcount incremented when prev is not null, it needs be put when finish using it. Fixes: b5b41ab6b0c1 ("device property: Check fwnode->secondary in fwnode_graph_get_next_endpoint()") Signed-off-by: Yang Yingliang --- drivers/base/property.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index 2a5a37fcd998..022d4ff366be 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -1005,10 +1005,16 @@ fwnode_graph_get_next_endpoint(const struct fwnode_handle *fwnode, return NULL; ep = fwnode_call_ptr_op(parent, graph_get_next_endpoint, prev); - if (ep) + if (ep) { + if (prev) + fwnode_handle_put((struct fwnode_handle *)parent); return ep; + } - return fwnode_graph_get_next_endpoint(parent->secondary, NULL); + ep = fwnode_graph_get_next_endpoint(parent->secondary, NULL); + if (prev) + fwnode_handle_put((struct fwnode_handle *)parent); + return ep; } EXPORT_SYMBOL_GPL(fwnode_graph_get_next_endpoint);