From patchwork Sat Sep 16 13:03:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 723989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766BFCD37BD for ; Sat, 16 Sep 2023 13:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239294AbjIPNDx (ORCPT ); Sat, 16 Sep 2023 09:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235850AbjIPNDn (ORCPT ); Sat, 16 Sep 2023 09:03:43 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D85161B5; Sat, 16 Sep 2023 06:03:36 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R561e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046059; MF=xueshuai@linux.alibaba.com; NM=1; PH=DS; RN=22; SR=0; TI=SMTPD_---0VsA36x0_1694869411; Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VsA36x0_1694869411) by smtp.aliyun-inc.com; Sat, 16 Sep 2023 21:03:32 +0800 From: Shuai Xue To: keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, robert.moore@intel.com Cc: linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, xueshuai@linux.alibaba.com, baolin.wang@linux.alibaba.com Subject: [RFC PATCH 8/9] ACPI: APEI: ESRT: print AER to report serialized PCIe errors Date: Sat, 16 Sep 2023 21:03:15 +0800 Message-Id: <20230916130316.65815-9-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230916130316.65815-1-xueshuai@linux.alibaba.com> References: <20230916130316.65815-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Introduce a new pstore_record type, PSTORE_TYPE_CPER_PCIE, so that serialized PCIe errors can be restrived and saved as a file in pstore file system. While the serialized PCIe errors is retrieved from ERST backend, print AER information. Signed-off-by: Shuai Xue --- drivers/acpi/apei/erst.c | 15 +++++++++++++++ fs/pstore/platform.c | 1 + include/linux/pstore.h | 1 + 3 files changed, 17 insertions(+) diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 665b8f93dab3..4f000cb1433a 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c @@ -27,6 +27,8 @@ #include /* kvfree() */ #include #include +#include +#include /* only define CREATE_TRACE_POINTS once */ #include @@ -1073,6 +1075,19 @@ static ssize_t erst_reader(struct pstore_record *record) record->type = PSTORE_TYPE_CPER_MEM; arch_apei_report_mem_error(0x2, (struct cper_sec_mem_err *)rcd->data); atomic_notifier_call_chain(&ghes_report_chain, 0x2, rcd->data); + } else if (guid_equal(&rcd->sec_hdr.section_type, &CPER_SEC_PCIE)) { + + struct cper_sec_pcie *pcie_err = (struct cper_sec_pcie *)rcd->data; + unsigned int devfn = PCI_DEVFN(pcie_err->device_id.device, + pcie_err->device_id.function); + struct pci_dev *pdev = pci_get_domain_bus_and_slot( + pcie_err->device_id.segment, pcie_err->device_id.bus, + devfn); + + record->type = PSTORE_TYPE_CPER_PCIE; + cper_print_aer( + pdev, AER_FATAL, + (struct aer_capability_regs *)pcie_err->aer_info); } else record->type = PSTORE_TYPE_MAX; diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 4e63ac8be755..40a062546fe4 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -52,6 +52,7 @@ static const char * const pstore_type_names[] = { "pmsg", "powerpc-opal", "cper-mem", + "cper-pcie", }; static int pstore_new_entry; diff --git a/include/linux/pstore.h b/include/linux/pstore.h index d18ecaacd1b5..e63f51e9c22e 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h @@ -42,6 +42,7 @@ enum pstore_type_id { /* APEI section */ PSTORE_TYPE_CPER_MEM = 9, + PSTORE_TYPE_CPER_PCIE = 10, /* End of the list */ PSTORE_TYPE_MAX