From patchwork Sun Jun 30 21:08:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 809157 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD6D42AE68 for ; Sun, 30 Jun 2024 21:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719781698; cv=none; b=dFMIqp2eM+IOPyOAnJwAty6g0g7qYgyWgOD4DQr7bxRecFmuZCy0QhMyan3DJwVDAQIstsWEGJdCscwoXQbMpNGb+5dNk13V8rUP6z4FBrCO+AyY7123R3tqJ7D1ehha+M27oJW9y7sPaoCVzW4gYenoX2eM+v8bRrnMWD0qe7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719781698; c=relaxed/simple; bh=gW6wjF5GOLahrzuOysh1WJhPgwoMMR9hDIpX5WU8BEQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RDQ/6t2hSpu3C9djGpWXF4c62ZVdczLOg31KRgFNh095kn3nOTl116j/uEtlnsIAs0olsfTd4K9aIOkxpc3+7vMch1sUmC+v7ELUDfXYaVl7TJfiEKmtLQm4JWE6vKu0UfUeicYgKnU/3+sAvl7zbAfQTu93uxyVv8PZvLRZF2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NHMiPA88; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NHMiPA88" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2c7aafe3094so461894a91.0 for ; Sun, 30 Jun 2024 14:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719781696; x=1720386496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Qsf4cNEXFIzXVY/Vaf+nuaEFn++A84g+B4+21rN0Vs=; b=NHMiPA8850S7o0F4/K2glEUQzxmrFGKnBJYoaVWL44wDyykdVhRsMhY4whD50I7/BU GUJjoHrEXLn9yrywAZe0az+SVEYXOjD0FgsEU5O2Z62vrrQB/Yka1JM4+bU+VMg1VOPB hxBxixJR2mamomrXqzypIrDV8v8CGy3OciYKBcFf0PDHMolGdVP6zslrqy6wjIj14fCQ AhqCDSY5Cr+Oh8Gb63dYaHIY0hOmmgXHPtuT61UyilZIW2dH7O+VzHuCvilhhpIY9jCq alRxXBYRk4itWEM4IYS+4FAJ/6vAIdnP5FsKHGq+6NZCdVLs1qO4bqvwLr13velbZz11 qeIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719781696; x=1720386496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Qsf4cNEXFIzXVY/Vaf+nuaEFn++A84g+B4+21rN0Vs=; b=ifMppDmHXIv/m5IhPpUqbXvoA09RFOzxMheUKQ6q8RUxvQltV8+jgRX3zDhImnJMz+ 9qs33cAP2NBWYkfq43pF8n3rVGpjFnJ0zxLt33q9o26nrBJInnLQnOfaZTWSB+Y3gqof sQ/RtSORDg1yzRWwvh9RDDrox5wBGdKITG+7Ga1c3CoeEwM1kSFAERnDGWYR5YLKJNyE mSCyGcuELzeeRpZFh0Z/+WYZT53j7OeaI2kz7MMiJUgSsaeTsiTLVK0cfhthNbM2ekxf sbhLo18Mkn63/eBIyovOn9e2id7AYLo1C0Av6O/7yg4Xarcq9YFBfy7GOWBnmNru7AXI 3eeA== X-Forwarded-Encrypted: i=1; AJvYcCWvZCd93LiCyigUswlsfZVT/sRh2m52AW1YxyYOBO/YqAmqPEgVB2NfTwEoQBRxQoZRuhv9o2iFR17BgmAWDhZM9q5/B06QyV+qsw== X-Gm-Message-State: AOJu0YyaRnGTWfz/23GuafvbexK6Zl9rZ9zVEEyAO4KJg3aBAV30I3yT qV01QlxQ3k15Y//BWhVHouXgQOtmgKR9yFwDOvSPA3jQuxZJeJGUbuYNZw== X-Google-Smtp-Source: AGHT+IHjBYp4uSX/3uoBSi3ABmPv0+VJCt6NLbnG/jpShcdoCDMhbXjGAwQewuZvLkKnyxHyUoNwTw== X-Received: by 2002:a05:6a20:da8a:b0:1be:e53c:7f87 with SMTP id adf61e73a8af0-1bef626b560mr6400422637.3.1719781695895; Sun, 30 Jun 2024 14:08:15 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6c7f72a7sm3972046a12.63.2024.06.30.14.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 14:08:15 -0700 (PDT) From: Kuan-Wei Chiu To: rafael@kernel.org Cc: lenb@kernel.org, mario.limonciello@amd.com, akpm@linux-foundation.org, jserv@ccns.ncku.edu.tw, alexdeucher@gmail.com, belegdol@gmail.com, linux-acpi@vger.kernel.org, regressions@lists.linux.dev, regressions@leemhuis.info, Kuan-Wei Chiu Subject: [PATCH] ACPI: processor_idle: Fix invalid comparison with insertion sort for latency Date: Mon, 1 Jul 2024 05:08:09 +0800 Message-Id: <20240630210809.37550-1-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The acpi_cst_latency_cmp comparison function currently used for sorting C-state latencies does not satisfy transitivity, causing incorrect sorting results. Specifically, if there are two valid acpi_processor_cx elements A and B and one invalid element C, it may occur that A < B, A = C, and B = C. Sorting algorithms assume that if A < B and A = C, then C < B, leading to incorrect ordering. Given the small size of the array (<=8), we replace the library sort function with a simple insertion sort that properly ignores invalid elements and sorts valid ones based on latency. This change ensures correct ordering of the C-state latencies. Fixes: 65ea8f2c6e23 ("ACPI: processor idle: Fix up C-state latency if not ordered") Reported-by: Julian Sikorski Closes: https://lore.kernel.org/lkml/70674dc7-5586-4183-8953-8095567e73df@gmail.com/ Signed-off-by: Kuan-Wei Chiu --- I do not have the appropriate AMD hardware to reproduce this issue and test the patch. However, if the aforementioned reason is indeed the source of the problem, I believe this patch might help. drivers/acpi/processor_idle.c | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index bd6a7857ce05..d58a7c64d80b 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -386,25 +386,19 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr, acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, 1); } -static int acpi_cst_latency_cmp(const void *a, const void *b) +static void acpi_cst_latency_sort(struct acpi_processor_cx *arr, size_t length) { - const struct acpi_processor_cx *x = a, *y = b; + int i, j, k; - if (!(x->valid && y->valid)) - return 0; - if (x->latency > y->latency) - return 1; - if (x->latency < y->latency) - return -1; - return 0; -} -static void acpi_cst_latency_swap(void *a, void *b, int n) -{ - struct acpi_processor_cx *x = a, *y = b; - - if (!(x->valid && y->valid)) - return; - swap(x->latency, y->latency); + for (i = 1; i < length; i++) { + for (j = i - 1, k = i; j >= 0; j--) { + if (!arr[j].valid) + continue; + if (arr[j].latency > arr[k].latency) + swap(arr[j].latency, arr[k].latency); + k = j; + } + } } static int acpi_processor_power_verify(struct acpi_processor *pr) @@ -449,10 +443,7 @@ static int acpi_processor_power_verify(struct acpi_processor *pr) if (buggy_latency) { pr_notice("FW issue: working around C-state latencies out of order\n"); - sort(&pr->power.states[1], max_cstate, - sizeof(struct acpi_processor_cx), - acpi_cst_latency_cmp, - acpi_cst_latency_swap); + acpi_cst_latency_sort(&pr->power.states[1], max_cstate); } lapic_timer_propagate_broadcast(pr);