| Message ID | 20240825132322.6776-1-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 4be50f9918507bb3392726777f483c59e41a1e28 |
| Headers | show |
| Series | [1/2] ACPI: video: Make Lenovo Yoga Tab 3 X90F DMI match less strict | expand |
On Sun, Aug 25, 2024 at 3:23 PM Hans de Goede <hdegoede@redhat.com> wrote: > > There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it > turns out that the 2G version has a DMI product name of > "CHERRYVIEW D1 PLATFORM" where as the 4G version has > "CHERRYVIEW C0 PLATFORM". The sys-vendor + product-version check are > unique enough that the product-name check is not necessary. > > Drop the product-name check so that the existing DMI match for the 4G > RAM version also matches the 2G RAM version. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/acpi/video_detect.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 674b9db7a1ef..e33ab5a2f489 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -896,7 +896,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > /* Lenovo Yoga Tab 3 Pro YT3-X90F */ > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), > - DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"), > DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"), > }, > }, > -- Applied as 6.12 material along with the [2/2], thanks!
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 674b9db7a1ef..e33ab5a2f489 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -896,7 +896,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = { /* Lenovo Yoga Tab 3 Pro YT3-X90F */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), - DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"), DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"), }, },
There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it turns out that the 2G version has a DMI product name of "CHERRYVIEW D1 PLATFORM" where as the 4G version has "CHERRYVIEW C0 PLATFORM". The sys-vendor + product-version check are unique enough that the product-name check is not necessary. Drop the product-name check so that the existing DMI match for the 4G RAM version also matches the 2G RAM version. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/acpi/video_detect.c | 1 - 1 file changed, 1 deletion(-)