From patchwork Tue Jul 16 07:34:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 18373 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 13AEE25E13 for ; Tue, 16 Jul 2013 07:34:29 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id w10sf612148lbi.8 for ; Tue, 16 Jul 2013 00:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding:content-language; bh=SxUejouuP1vNTdl6erDUQ2RD3bOrp+TrQwRodOUtqW8=; b=eHlpK21KVq3qJZV4KdxGrsmExd38s51oSXRAFF3Huzo6/FY12s4RnNnBNCtPvaTbNs 6n58lYWiCENn9nAGt+kEjepx9H4Rr4X3+oaFp4somSK2/QUZXB8UlqMv8xmdGvMF/w1s 2jlY9CEBXw/pplrOjEeCyr6k7W/i4GmuejITKlBjdBFnmQyGqm8AJtBtKz71vfUe5Ggx SLgp5HlPmhYUHektGnm5XEu9+3OGD19xPkiqjvXwRoVTFOmD5xzDrKx3z7v2h70s6j9A u3fyHmhZ62/aQoJQ9BBc+XRkIOEyDmriDoviVtsKYAOzqNHeeQfnki9VO4CmHlqThFAN WlTA== X-Received: by 10.180.37.229 with SMTP id b5mr8888597wik.4.1373960068767; Tue, 16 Jul 2013 00:34:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.206.104 with SMTP id ln8ls271496wic.54.canary; Tue, 16 Jul 2013 00:34:28 -0700 (PDT) X-Received: by 10.194.2.79 with SMTP id 15mr152821wjs.42.1373960067999; Tue, 16 Jul 2013 00:34:27 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id w10si72839wjq.135.2013.07.16.00.34.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Jul 2013 00:34:27 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id d10so239007vea.38 for ; Tue, 16 Jul 2013 00:34:26 -0700 (PDT) X-Received: by 10.58.154.34 with SMTP id vl2mr66986veb.35.1373960066848; Tue, 16 Jul 2013 00:34:26 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.149.77 with SMTP id s13csp106418vcv; Tue, 16 Jul 2013 00:34:26 -0700 (PDT) X-Received: by 10.67.5.198 with SMTP id co6mr1273346pad.110.1373960065705; Tue, 16 Jul 2013 00:34:25 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by mx.google.com with ESMTP id aq4si143830pbd.206.2013.07.16.00.34.24 for ; Tue, 16 Jul 2013 00:34:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of kgene.kim@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQ000FKQQDBA6C0@mailout2.samsung.com>; Tue, 16 Jul 2013 16:34:23 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 87.55.29708.F77F4E15; Tue, 16 Jul 2013 16:34:23 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-9c-51e4f77f3bbc Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A0.B8.03947.F77F4E15; Tue, 16 Jul 2013 16:34:23 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQ000E1HQDBP320@mmp2.samsung.com>; Tue, 16 Jul 2013 16:34:23 +0900 (KST) From: Kukjin Kim To: 'Sachin Kamat' , linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org, mturquette@linaro.org, patches@linaro.org References: <1373533334-5169-1-git-send-email-sachin.kamat@linaro.org> <1373533334-5169-2-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1373533334-5169-2-git-send-email-sachin.kamat@linaro.org> Subject: RE: [PATCH 1/6] clk: exynos4: Staticize local symbols Date: Tue, 16 Jul 2013 16:34:23 +0900 Message-id: <02d801ce81f6$e480fe80$ad82fb80$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac5+F5F0IOJRA+AIQfy/QsE9OIxF2wD3wGbg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t8zI936708CDR50GlhsenyN1WLG+X1M Fk8nXGSzmHL4C4vFyT+9jA6sHneu7WHz2Lyk3uPzJrkA5igum5TUnMyy1CJ9uwSujAfz1jEX vOWv2PVtL3MDYxNvFyMnh4SAiUTr5ElMELaYxIV769m6GLk4hASWMUocWNLKAlO0cu1KqMR0 RomeiX1Qzl9GicbTi8Da2QQ0JA6/f8YOYosIhEgcX7oMLM4sECAxd+EEZoiGZkaJZ9PeMIIk OAXcJfZd+w62QljATuLxwW3MIDaLgKrErQfzweK8ArYS6w9tZYWwBSV+TL7HAjFUS2L9zuNQ C+QlNq95C9TLAXSqusSjv7ogpoiAkcTlPheIChGJfS/eMYKcICFwil3i0ZOdTBCrBCS+TT7E AtEqK7HpADPEw5ISB1fcYJnAKDELyeJZSBbPQrJ4FpIVCxhZVjGKphYkFxQnpReZ6BUn5haX 5qXrJefnbmKEROWEHYz3DlgfYkwGWj+RWUo0OR8Y1Xkl8YbGZkYWpiamxkbmlmakCSuJ86q3 WAcKCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYNR7/FQrJj7C1uun3w623KOn94vzC/esSbrG ITk9xdIo3eP51yIRd5PO2MyVjAXrpYyF+21z7Dubeb8y77NNlixfsst3loVimJvK8j99Bccd Q584FX94OdVReH+MluTWPtlbt0QCp694ZzpF1LKnJybC6OXP47ahfO/eTopZdGvichv2xh5W JZbijERDLeai4kQAe/8iIeACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQd36708CDX781rbY9Pgaq8WM8/uY LJ5OuMhmMeXwFxaLk396GR1YPe5c28PmsXlJvcfnTXIBzFENjDYZqYkpqUUKqXnJ+SmZeem2 St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QCuVFMoSc0qBQgGJxcVK+naYJoSGuOla wDRG6PqGBMH1GBmggYR1jBkP5q1jLnjLX7Hr217mBsYm3i5GTg4JAROJlWtXskHYYhIX7q0H srk4hASmM0r0TOyDcv4ySjSeXsQEUsUmoCFx+P0zdhBbRCBE4vjSZWBxZoEAibkLJzBDNDQz Sjyb9oYRJMEp4C6x79p3FhBbWMBO4vHBbcwgNouAqsStB/PB4rwCthLrD21lhbAFJX5MvscC MVRLYv3O41AL5CU2r3kL1MsBdKq6xKO/uiCmiICRxOU+F4gKEYl9L94xTmAUmoVk0Cwkg2Yh GTQLScsCRpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMEx/0xqB+PKBotDjAIcjEo8vBI8 TwKFWBPLiitzDzFKcDArifAmbgIK8aYkVlalFuXHF5XmpBYfYkwG+nMis5Rocj4wHeWVxBsa m5gZWRqZWRiZmJuTJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsTB6dUA2P7+m0vHG2FvcMPu2zJ zEhnv2a9YpLnUelmAdePHyZMkO7zfff+5z0RT8E94jNnWiiJiB0y2iCbGOH04pIxn97FWdfe 6D5Piw35w52gKh8SvUTT9fWtiTaO02qK1rrOuFBodnWbpiGzxpIfq6M6XLb67btiYyh7dv3D F6zBERpr/4Y+ZNJ98FqJpTgj0VCLuag4EQAxQjusPQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Gm-Message-State: ALoCoQlSEvZAv/KICKLU+Z6oH9Mz6nuo0VgpulFXdqLUqO+IppyhwSbqK+xtz1Xo1iOIcTaBSt/Y X-Original-Sender: kgene.kim@samsung.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Sachin Kamat wrote: > > Symbols referenced only in this file are made static. > > Signed-off-by: Sachin Kamat > --- > drivers/clk/samsung/clk-exynos4.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk- > exynos4.c > index 1bdb882..18eadc4 100644 > --- a/drivers/clk/samsung/clk-exynos4.c > +++ b/drivers/clk/samsung/clk-exynos4.c [...] > @@ -975,7 +975,7 @@ static void __init > exynos4_clk_register_finpll(unsigned long xom) > * clock speed. > */ > void __init exynos4_clk_register_fixed_ext(unsigned long xxti_f, > - unsigned long xusbxti_f) > + unsigned long xusbxti_f) Why? > { > exynos4_fixed_rate_ext_clks[0].fixed_rate = xxti_f; > exynos4_fixed_rate_ext_clks[1].fixed_rate = xusbxti_f; > @@ -990,7 +990,9 @@ static __initdata struct of_device_id ext_clk_match[] > = { > }; > > /* register exynos4 clocks */ > -void __init exynos4_clk_init(struct device_node *np, enum exynos4_soc > exynos4_soc, void __iomem *reg_base, unsigned long xom) > +static void __init exynos4_clk_init(struct device_node *np, > + enum exynos4_soc exynos4_soc, > + void __iomem *reg_base, unsigned long xom) > { > struct clk *apll, *mpll, *epll, *vpll; > > -- > 1.7.9.5 And don't we need following? void exynos_firmware_init(void); - Kukjin diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 3e156bc..3a34f1e 100644 --- a/arch/arm/mach-exynos/common.h +++ b/arch/arm/mach-exynos/common.h @@ -26,7 +26,6 @@ void exynos5_restart(enum reboot_mode mode, const char *cmd); void exynos_init_late(void); /* ToDo: remove these after migrating legacy exynos4 platforms to dt */ -void exynos4_clk_init(struct device_node *np, int is_exynos4210, void __iomem *reg_base, unsigned long xom); void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);