From patchwork Fri Sep 23 17:22:25 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 4307 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id D341F23F58 for ; Fri, 23 Sep 2011 17:20:17 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id B83E1A18CBE for ; Fri, 23 Sep 2011 17:20:17 +0000 (UTC) Received: by fxe23 with SMTP id 23so5611662fxe.11 for ; Fri, 23 Sep 2011 10:20:17 -0700 (PDT) Received: by 10.223.94.134 with SMTP id z6mr5393042fam.8.1316798417367; Fri, 23 Sep 2011 10:20:17 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.18.198 with SMTP id y6cs221077lad; Fri, 23 Sep 2011 10:20:16 -0700 (PDT) Received: by 10.68.33.130 with SMTP id r2mr11202160pbi.71.1316798414011; Fri, 23 Sep 2011 10:20:14 -0700 (PDT) Received: from mail-pz0-f42.google.com (mail-pz0-f42.google.com [209.85.210.42]) by mx.google.com with ESMTPS id t3si13133908pbf.105.2011.09.23.10.20.13 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Sep 2011 10:20:14 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.42 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) client-ip=209.85.210.42; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.42 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) smtp.mail=shawn.guo@linaro.org Received: by pzk1 with SMTP id 1so7756731pzk.1 for ; Fri, 23 Sep 2011 10:20:13 -0700 (PDT) Received: by 10.68.27.199 with SMTP id v7mr11165326pbg.2.1316798412797; Fri, 23 Sep 2011 10:20:12 -0700 (PDT) Received: from localhost.localdomain ([117.82.33.48]) by mx.google.com with ESMTPS id q10sm40169018pbn.9.2011.09.23.10.20.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Sep 2011 10:20:11 -0700 (PDT) From: Shawn Guo To: Russell King Cc: linux-arm-kernel@lists.infradead.org, patches@linaro.org, Shawn Guo Subject: [PATCH] ARM: localtimer: add header linux/errno.h explicitly Date: Sat, 24 Sep 2011 01:22:25 +0800 Message-Id: <1316798545-21128-1-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 Per the text in Documentation/SubmitChecklist as below, we should explicitly have header linux/errno.h in localtimer.h for ENXIO reference. 1: If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use. Otherwise, we may run into some compiling error like the following one, if any file includes localtimer.h without CONFIG_LOCAL_TIMERS defined. arch/arm/include/asm/localtimer.h: In function ‘local_timer_setup’: arch/arm/include/asm/localtimer.h:53:10: error: ‘ENXIO’ undeclared (first use in this function) Signed-off-by: Shawn Guo --- arch/arm/include/asm/localtimer.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/asm/localtimer.h b/arch/arm/include/asm/localtimer.h index 080d74f..698ff73 100644 --- a/arch/arm/include/asm/localtimer.h +++ b/arch/arm/include/asm/localtimer.h @@ -48,6 +48,8 @@ int local_timer_setup(struct clock_event_device *); #else +#include + static inline int local_timer_setup(struct clock_event_device *evt) { return -ENXIO;