From patchwork Tue Jul 31 14:45:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 10426 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id AA3DB24027 for ; Tue, 31 Jul 2012 14:46:37 +0000 (UTC) Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by fiordland.canonical.com (Postfix) with ESMTP id A2C3AA18D20 for ; Tue, 31 Jul 2012 14:46:37 +0000 (UTC) Received: by wgbdq11 with SMTP id dq11so4745897wgb.17 for ; Tue, 31 Jul 2012 07:46:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Xt30TlBfLMgW+SlYwsmEXDyqwIPKCUEWSPIZwpUP0uk=; b=kmTzTQskhjJSfAAJJUB99NqBcC3dV6Y470PSbYp1qWVNzk3chrsIvBTaS6S0dQehe9 3tm+V+dIMqGYepOrUIkVyKr3BGKNavE51NXb+1xmh0qcTcyuPqkwEyQFmIO7rhSFZGWs IgdduBe+uBQ6JDCaOnToCfXjCHEnPMo2zT33o3yISiYtAG/+O1rrzLquAnKVG+4L6f14 K9IHqz6hreNW/CcmkAAZk1l57CfUst30mak96rMYNrdsQr9SCBSJy8FodV63ZHCND0iz quh61pI3rL1c3HfLZGEqCe/ZybWva+4/94aTsjPARV+ewF9zYL3JQbsp2BVNV7QBH9m2 rUWg== Received: by 10.50.94.166 with SMTP id dd6mr2265451igb.11.1343745996820; Tue, 31 Jul 2012 07:46:36 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp147929igz; Tue, 31 Jul 2012 07:46:10 -0700 (PDT) Received: by 10.205.132.6 with SMTP id hs6mr5325179bkc.26.1343745964839; Tue, 31 Jul 2012 07:46:04 -0700 (PDT) Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by mx.google.com with ESMTPS id b57si329250wef.89.2012.07.31.07.46.03 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 Jul 2012 07:46:04 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.42 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=74.125.82.42; Authentication-Results: mx.google.com; spf=neutral (google.com: 74.125.82.42 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Received: by wgbfm10 with SMTP id fm10so3407029wgb.1 for ; Tue, 31 Jul 2012 07:46:03 -0700 (PDT) Received: by 10.180.97.33 with SMTP id dx1mr7443562wib.18.1343745963773; Tue, 31 Jul 2012 07:46:03 -0700 (PDT) Received: from localhost.localdomain (cpc1-aztw13-0-0-cust473.18-1.cable.virginmedia.com. [77.102.241.218]) by mx.google.com with ESMTPS id j6sm695412wiy.4.2012.07.31.07.46.02 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 Jul 2012 07:46:03 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, Lee Jones Subject: [PATCH 2/5] ASoC: ab8500: Inform SoC Core that we have our own I/O arrangements Date: Tue, 31 Jul 2012 15:45:41 +0100 Message-Id: <1343745944-18418-3-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1343745944-18418-1-git-send-email-lee.jones@linaro.org> References: <1343745944-18418-1-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQk4BErg1O8TTv/rMsXrT7UN792q5q4RW1EXq0RZs6Ha1J2aZpL+ysGFRSkVN1VSY+W+ccDr If codec->control_data is not populated SoC Core assumes we want to use regmap, which fails catastrophically, as we don't have one: Unable to handle kernel NULL pointer dereference at virtual address 00000080 pgd = c0004000 [00000080] *pgd=00000000 Internal error: Oops: 17 [#1] PREEMPT SMP ARM Modules linked in: CPU: 1 Not tainted (3.5.0-rc6-00884-g0b2419e-dirty #130) PC is at regmap_read+0x10/0x5c LR is at hw_read+0x80/0x90 pc : [] lr : [] psr: 60000013 Signed-off-by: Lee Jones --- sound/soc/codecs/ab8500-codec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c index 3c79592..23b4018 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -2406,6 +2406,10 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec) /* Setup AB8500 according to board-settings */ pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent); + + /* Inform SoC Core that we have our own I/O arrangements. */ + codec->control_data = (void *)true; + status = ab8500_audio_setup_mics(codec, &pdata->codec->amics); if (status < 0) { pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);