From patchwork Wed Aug 8 21:27:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10609 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6568F23E57 for ; Wed, 8 Aug 2012 21:28:24 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 33F2DA184CA for ; Wed, 8 Aug 2012 21:28:24 +0000 (UTC) Received: by mail-gh0-f180.google.com with SMTP id g10so1334605ghb.11 for ; Wed, 08 Aug 2012 14:28:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=zg9DEGjVozw2wyUsoxMEtYI7znkpQSVASdNewtIIneY=; b=TLldmeVm7maNWa9GnkrDl2hijUtVaqZj4HisViI1QTM6xP/hNZS+SaOXel3z0qzaNG t6StmZZ9GLQDlVq1uVmka3Wr3JLlmZecIraOCX/waze3+dB/XzyIWy65Rph3ai3pqZk4 W3d8b9OkmLRoTNCEo3DBSi8q+zheSzscsTZVQIwt4tCfpBFbM7AYONn8gS+v2rNd8EwI HzWvENV9KC1Z4qDYujNrWhPBvbRLqf3ap3paNslzo13FXfxq5Z0qxkSQ4SnaJZUN+Xwv MkrVOkyGNbnCp13kPsErwXPie4U0jCAUudWNcH/On9Vr1SCxZ4ZcZP5tNSDZxAPqXbn2 1VMg== Received: by 10.42.53.132 with SMTP id n4mr15233407icg.32.1344461303774; Wed, 08 Aug 2012 14:28:23 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.200 with SMTP id ew8csp628857igc; Wed, 8 Aug 2012 14:28:22 -0700 (PDT) Received: by 10.216.135.147 with SMTP id u19mr10020728wei.12.1344461302124; Wed, 08 Aug 2012 14:28:22 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.10]) by mx.google.com with ESMTP id e21si31518467wec.7.2012.08.08.14.28.21; Wed, 08 Aug 2012 14:28:22 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.10 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.10; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.10 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0LkDV8-1TZvOL0zZS-00cN5b; Wed, 08 Aug 2012 23:28:11 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Russell King Subject: [PATCH 07/10] ARM: rpc: check device_register return code in ecard_probe Date: Wed, 8 Aug 2012 23:27:55 +0200 Message-Id: <1344461278-28245-8-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1344461278-28245-1-git-send-email-arnd@arndb.de> References: <1344461278-28245-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:E9fjT7aUzpuo9qEZjxj6x6irjR8/HAzod7dp9OIVp4H llmGJxbTQaXjRrBiwU8Y+nH6QAroUGOiRYhgETi6zGifW/M7WE 8JKWYJ3iqsuTxHBbe2YIj40k6m5/MIIkWLjrcz6qeaFnbOR9Ft cwCQ2sVvBIXnSHJmZqD3bkNruRtaktH0Bq5EVwl4N45HPfu64H okfz+1pEcybHDvhK/72yQGZgApRUdgxvtIm9+Uuv91zogwU8p7 clQo4HU6Um5wDP4EjdgJMsYpaiwTQ4fAnHAfCcLIqGwcbzOBN8 A93+mfArEO4sOv9v4/sgCKrXe6g/+Ym1YBQwteZksBN3gv0xL6 5jvpjNJUxZHq+gwcGuSNMrNW2CCXoceAj2oQPjtA5gf2JPOl6P 0VjTUPHcBI10A== X-Gm-Message-State: ALoCoQkIdeGanQfPl9Aset5JN1NlIYEtZW3WHadAOloyRgxnV9lbnWdrGnwxt45mIJsT7l2gDqvj device_register is marked __must_check, so we better propagate the error value by returning it from ecard_probe. Without this patch, building rpc_defconfig results in: arch/arm/mach-rpc/ecard.c: In function 'ecard_probe': arch/arm/mach-rpc/ecard.c:963:17: warning: ignoring return value of 'device_register', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Arnd Bergmann Cc: Russell King --- arch/arm/mach-rpc/ecard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c index b91bc87..fcb1d59 100644 --- a/arch/arm/mach-rpc/ecard.c +++ b/arch/arm/mach-rpc/ecard.c @@ -960,7 +960,9 @@ static int __init ecard_probe(int slot, unsigned irq, card_type_t type) *ecp = ec; slot_to_expcard[slot] = ec; - device_register(&ec->dev); + rc = device_register(&ec->dev); + if (rc) + goto nodev; return 0;