From patchwork Wed Aug 22 15:13:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10884 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 1790823E1B for ; Wed, 22 Aug 2012 15:13:39 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id D3899A18D8A for ; Wed, 22 Aug 2012 15:13:26 +0000 (UTC) Received: by iadj38 with SMTP id j38so924267iad.11 for ; Wed, 22 Aug 2012 08:13:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=8n7CVPTLLCf/Rkyvm0PK+XmjCq4sb3ElCzptmPDlxlo=; b=XUrDV/7HmuNIOzd2sig7F0+dkDZ6DjLbAkCJQxdcOI5fjKiDdQF61ek5sK56b7qQte TPaKRV3bCPbIlYlrSCugxmNJ7tbTlzh6aCx5OxlHYLk/0DmaYbBZgDLATxc+rY8u265P RHbUPlBMGp7Db8FyldYnYjiRJINA9LV61w8KffcwLbQNhobCQ9Bu0HCUrdspvjscXNlc Vyl/ftXF3a2P7HFt0sR7E71TBIDWQTA9/4at83ofQr3y+VxgYTr2OcDOij6TTmx7k07t sdmpsoLnlNHvy7gi4k17+9wKAZXxFYTt+GP9KmIXeyCOVn1AurqH1GK4mY3GPCbLYRX9 o8jw== Received: by 10.42.60.139 with SMTP id q11mr17235002ich.53.1345648417946; Wed, 22 Aug 2012 08:13:37 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp207631igc; Wed, 22 Aug 2012 08:13:37 -0700 (PDT) Received: by 10.216.116.73 with SMTP id f51mr11473939weh.50.1345648416484; Wed, 22 Aug 2012 08:13:36 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.126.187]) by mx.google.com with ESMTP id t4si48490158wiz.34.2012.08.22.08.13.36; Wed, 22 Aug 2012 08:13:36 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.126.187 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.187; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.126.187 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0M9XvL-1SxILG3B4Z-00Cyud; Wed, 22 Aug 2012 17:13:30 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Russell King , linux-kernel@vger.kernel.org, Arnd Bergmann , Linus Walleij , Lee Jones Subject: [PATCH 1/6] ARM: ux500: don't select LEDS_GPIO for snowball Date: Wed, 22 Aug 2012 17:13:05 +0200 Message-Id: <1345648390-4234-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1345648390-4234-1-git-send-email-arnd@arndb.de> References: <1345648390-4234-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:Y5kvlH3VNvcTPmjv21ZalAgS4o+wSe/DamZ0+PX/WB4 I8uz9CXEZ6TUt4hEMUwT6iU9BFzlts86KuZnP4hBgVmzDotK66 2z99jERAZJy49TDbW6YAiiSjnwCivrMoHTOTIYU7YslfAEEle1 JF6AmkF6HS36+KeNHm6rAPHZYgBgkqgTmt81BX3ZIpGSMSjHsE pag4Sb/D/jTQsp2mpEmderwvp/n/rrhlY3/SULJwLXVSZJMI9A inbx9n1uUoICgnQHqo3M9IBnJFWKAqgMcrFd+mvLd6i58VpMZR sfyPMSC6GMs1pFgWL+Ujk+wmArY2WFGe6lIyMuD5gKLGEbrSbh MjNJ6VN3SRY/fxjYdBXtTnxCyp9tQz/MJWvnV/vHHD7MlSCH6V +m7YBo0DTPEGg== X-Gm-Message-State: ALoCoQne7G0foerIfzFtF7WJl7lvS9V4ceuDS4RQWXnnTdor5BIdaDJek/FTZtbMRoN50QL9koih The gpio leds driver can only be built if the generic LED code is also enabled. Snowball selects LEDS_GPIO for an unknown reason but it does not select LEDS_CLASS and also does not really require the LED support at all, so we can just drop this dependency. Without this patch, building without LEDS_CLASS esults in: drivers/built-in.o: In function `create_gpio_led.part.2': governor_userspace.c:(.devinit.text+0x5a58): undefined reference to `led_classdev_register' drivers/built-in.o: In function `gpio_led_remove': governor_userspace.c:(.devexit.text+0x6b8): undefined reference to `led_classdev_unregister' This reverts 8733f53c6 "ARM: ux500: Kconfig: Compile in leds-gpio support for Snowball", which was not completely thought through. Signed-off-by: Arnd Bergmann Cc: Linus Walleij Cc: Lee Jones --- arch/arm/mach-ux500/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig index c013bbf..53d3d46 100644 --- a/arch/arm/mach-ux500/Kconfig +++ b/arch/arm/mach-ux500/Kconfig @@ -41,7 +41,6 @@ config MACH_HREFV60 config MACH_SNOWBALL bool "U8500 Snowball platform" select MACH_MOP500 - select LEDS_GPIO help Include support for the snowball development platform.