From patchwork Fri Oct 5 14:55:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12009 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 0C78723E57 for ; Fri, 5 Oct 2012 14:56:01 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 6BB96A190E4 for ; Fri, 5 Oct 2012 14:56:00 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so3893159iej.11 for ; Fri, 05 Oct 2012 07:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-provags-id:x-gm-message-state; bh=25JJYIiC/ETYTpwXwDKiHPC6TaycJJxmv4XuRoUI/hw=; b=Tme+kItBeLaluK56XKbw22KqumhDFFnoHUxE0QHYrsuG7/rcwQwc4pCSsI3TLNy6/L Agv+qjpwDwQVcpx0te7S+xUBdNcJVURp1/ZXzZY1uldhlz6zMqxE5tfGlEnEyj2Cpp9T vTVO10PBM5spcEZyTdM5Bqlm+5+wdkku0cHQgFVliKQWVPclhI2L+6L8qNOqHcG68yGx zSz3cE1aCl/hBfbTUSGjPharq8i2zzxAhbTz3/t9zviAuLyW100yc/Lvk6TfgzLfIcH6 NWmlgiHxNSJ/1CAqH/oosLvgOPgspp2rE3UGKDhWsdZYHDqr5MrlqpTaQiGMcxYCAPQS aiRQ== Received: by 10.42.110.130 with SMTP id q2mr7179876icp.53.1349448960059; Fri, 05 Oct 2012 07:56:00 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp130612igc; Fri, 5 Oct 2012 07:55:59 -0700 (PDT) Received: by 10.204.146.23 with SMTP id f23mr519881bkv.69.1349448958720; Fri, 05 Oct 2012 07:55:58 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.126.171]) by mx.google.com with ESMTPS id iv7si18935960bkc.49.2012.10.05.07.55.57 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 05 Oct 2012 07:55:58 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.126.171 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.171; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.126.171 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from klappe2.boeblingen.de.ibm.com (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0LvLnz-1TSR3W0lk3-010gqt; Fri, 05 Oct 2012 16:55:49 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Arnd Bergmann , Russell King , Mike Turquette , Kukjin Kim , Ben Dooks Subject: [PATCH 10/16] clk: don't mark clkdev_add_table as init Date: Fri, 5 Oct 2012 16:55:24 +0200 Message-Id: <1349448930-23976-11-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349448930-23976-1-git-send-email-arnd@arndb.de> References: <1349448930-23976-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:keJqiLIVbZgeXCb4z8+IWB0iNtgUhUxyttK28IlvaiG vh+p/68zlYRE4TsydZgIeiSRufH5wkmmj5pJb5tBYN4JhwUR1G NLMGMKUL2I6J4Fpdu0gwopehXVotxOUavjS9uTnSFHIkrCmHrw Ol0BtoMvR/Y1MAFn/FNoVv27DUfSdmUmvStfGW3+L97jA35AYS 2n3xQ9S12LWVtMMyM0e5f0K2Fa+jE4moFJhpUYlSlBY6PhK7Oc Zw4IduzPuH4/r8kruzX06rr59XBD4E0McLNBjcMb+Po8CTvhJ0 VaU6YSjqMNRRJVy4r3yqpFtpsVdT4vH1y0+ZcxVaSMiJwWYfZt gJvl4mfBSeK9VVoaiFPUxUWdbYzzBrDPsDIxbkRifLIAd1sMqd PE3QAVs1gJgtSCa0UUpZg/4rF16vkjTm3U= X-Gm-Message-State: ALoCoQm9oFUTZ83aISKAucEZ3rbOS4rufx2+YraornLyfkiib8Y1jd2q1ceSEFE961tnDZ6B2P58 s3c2440_clk_add is a subsys_interface method and calls clkdev_add_table, which means we might be calling it after the __init section is discarded. Without this patch, building mini2440_defconfig results in: WARNING: vmlinux.o(.text+0x9848): Section mismatch in reference from the function s3c2440_clk_add() to the function .init.text:clkdev_add_table() The function s3c2440_clk_add() references the function __init clkdev_add_table(). This is often because s3c2440_clk_add lacks a __init annotation or the annotation of clkdev_add_table is wrong. Signed-off-by: Arnd Bergmann Cc: Russell King Cc: Mike Turquette Cc: Kukjin Kim Cc: Ben Dooks --- drivers/clk/clkdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 442a313..6956857 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -179,7 +179,7 @@ void clkdev_add(struct clk_lookup *cl) } EXPORT_SYMBOL(clkdev_add); -void __init clkdev_add_table(struct clk_lookup *cl, size_t num) +void clkdev_add_table(struct clk_lookup *cl, size_t num) { mutex_lock(&clocks_mutex); while (num--) {