From patchwork Wed Nov 6 10:16:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 21371 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f71.google.com (mail-vb0-f71.google.com [209.85.212.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 474C020DB9 for ; Wed, 6 Nov 2013 10:17:03 +0000 (UTC) Received: by mail-vb0-f71.google.com with SMTP id i3sf8783135vbh.2 for ; Wed, 06 Nov 2013 02:17:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=jztQRdGI+wCUmxgaDye9xc2YKDHafJGnSsOv4Dm4RPo=; b=Wi+pTz8KJeZ64yArgjvWyJXIh7qzUKb4Saj2/VrFqhVRWCHyhC6vRiBOYigr9hlgSg NAgevfdsdMr/hGN9YgehqFiy8XMs/9rjw7w9TtGWSkNBrHMj8CAZ5POGzt7rss4ZPlwn WVvO1Fej6DqeAo+N3CLJSdJxQjKe9AANUXBNN9nKdP9RTi2v1Rf6UjfGWNhrxM9pf0xv S0NH8p/qHFMheRbYUs8Jo0FD26aPA23tjcYWlXNobDeSVpWbuUfwVdH/2ASw6m7lAoou F1PuZ4awBPNA+t5LQ8uXKFyP61y7jjG0wV0Fh9DgDS3OdSrMj4YAbMOgF75NFZxhIZbd 1etQ== X-Gm-Message-State: ALoCoQmUsVS+jayABmOw0AOCjQVTbk1R6L7wCxEuinZhkGFdsbbmycZ64h8c22dZhI4Bx3Futizi X-Received: by 10.52.94.80 with SMTP id da16mr1294684vdb.2.1383733023118; Wed, 06 Nov 2013 02:17:03 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.109.226 with SMTP id hv2ls585903qeb.22.gmail; Wed, 06 Nov 2013 02:17:03 -0800 (PST) X-Received: by 10.58.255.233 with SMTP id at9mr1769214ved.20.1383733023004; Wed, 06 Nov 2013 02:17:03 -0800 (PST) Received: from mail-vb0-f50.google.com (mail-vb0-f50.google.com [209.85.212.50]) by mx.google.com with ESMTPS id tq4si8162057vdc.12.2013.11.06.02.17.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Nov 2013 02:17:03 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.50 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.50; Received: by mail-vb0-f50.google.com with SMTP id x16so3201431vbf.23 for ; Wed, 06 Nov 2013 02:17:02 -0800 (PST) X-Received: by 10.52.119.228 with SMTP id kx4mr1473478vdb.12.1383733022915; Wed, 06 Nov 2013 02:17:02 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp273210vcz; Wed, 6 Nov 2013 02:17:02 -0800 (PST) X-Received: by 10.50.238.196 with SMTP id vm4mr19519167igc.43.1383733022187; Wed, 06 Nov 2013 02:17:02 -0800 (PST) Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by mx.google.com with ESMTPS id mz9si31492569icc.33.2013.11.06.02.17.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Nov 2013 02:17:02 -0800 (PST) Received-SPF: neutral (google.com: 209.85.223.173 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.223.173; Received: by mail-ie0-f173.google.com with SMTP id u16so17450871iet.32 for ; Wed, 06 Nov 2013 02:17:01 -0800 (PST) X-Received: by 10.50.55.65 with SMTP id q1mr19442359igp.4.1383733021537; Wed, 06 Nov 2013 02:17:01 -0800 (PST) Received: from localhost.localdomain (cpc15-aztw25-2-0-cust493.aztw.cable.virginm.net. [92.233.57.238]) by mx.google.com with ESMTPSA id ka1sm13308397igb.7.2013.11.06.02.16.59 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Nov 2013 02:17:01 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, Lee Jones , alsa-devel@alsa-project.org, Mark Brown Subject: [PATCH 08/13] ASoC: generic-dmaengine-pcm: Clear slave_config memory Date: Wed, 6 Nov 2013 10:16:20 +0000 Message-Id: <1383732985-18928-9-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1383732985-18928-1-git-send-email-lee.jones@linaro.org> References: <1383732985-18928-1-git-send-email-lee.jones@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.50 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We currently assume that the DMA Slave Config will be fully populated by the platform, however some DMA Engines make decisions based on zero (default) flags such as DMA_SLAVE_BUSWIDTH_UNDEFINED and as this is a static declaration we need to memset it to clear the data area. Cc: alsa-devel@alsa-project.org Cc: Mark Brown Signed-off-by: Lee Jones --- sound/soc/soc-generic-dmaengine-pcm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index ee07903..6ad4c7a 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -90,6 +90,8 @@ static int dmaengine_pcm_hw_params(struct snd_pcm_substream *substream, struct dma_slave_config slave_config; int ret; + memset(&slave_config, 0, sizeof(slave_config)); + if (!pcm->config) prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config; else