From patchwork Tue Feb 4 12:30:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 24096 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f198.google.com (mail-ob0-f198.google.com [209.85.214.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E429020445 for ; Tue, 4 Feb 2014 12:30:15 +0000 (UTC) Received: by mail-ob0-f198.google.com with SMTP id wp4sf33924804obc.9 for ; Tue, 04 Feb 2014 04:30:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe:content-type:content-transfer-encoding; bh=6UQ5yz4V1sYQsxpSBfTbyWv7uxVvGRPEFiLUG0DaKvY=; b=WdWl089GROKblRt1iqOP/80k4shSdFuu2eu+NaOTDIxjCgY0kT7JqupxHLgLaSfmNt t1X6NEv2vYEseZh+sI19GhyTOno7O420v4gmzOn7fNdTq5rLhBiyiVI1kljrZqol65lo ZYpwe0knaY+h7uC7+7xXTJ1vd55IuOFwpyow4IsjC9eTdL93uPMZtzekTjFaRA1kbmlq +dt6/j3qwGFq6U5NtxQs/xgeiqupLCbsW/zMPyKrE2Ghr9N2j9O7VOWFc4KlcEWXZsUN 0ILHq31YzqI17ke0jfn2Qa+9t4Oi1AQjI9pUcgGckFeZbuNBcsEfgrBFJfSynSCXT76Z Au7w== X-Gm-Message-State: ALoCoQl36UM7Cycwx85Vf8DbmvpebspEPEgTS1jLjVF5RfTLZ+INmPorsjsTYyHhrTuFrItKzC1l X-Received: by 10.42.53.135 with SMTP id n7mr14689470icg.11.1391517015009; Tue, 04 Feb 2014 04:30:15 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.175 with SMTP id j44ls2415942qgd.44.gmail; Tue, 04 Feb 2014 04:30:14 -0800 (PST) X-Received: by 10.53.13.44 with SMTP id ev12mr27554339vdd.17.1391517014927; Tue, 04 Feb 2014 04:30:14 -0800 (PST) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id xw5si8051581vec.122.2014.02.04.04.30.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 04:30:14 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id oz11so6011664veb.32 for ; Tue, 04 Feb 2014 04:30:14 -0800 (PST) X-Received: by 10.220.124.65 with SMTP id t1mr5830299vcr.26.1391517014862; Tue, 04 Feb 2014 04:30:14 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp230598vcz; Tue, 4 Feb 2014 04:30:14 -0800 (PST) X-Received: by 10.180.188.66 with SMTP id fy2mr9880232wic.45.1391517013938; Tue, 04 Feb 2014 04:30:13 -0800 (PST) Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by mx.google.com with ESMTPS id q12si1224911wiw.48.2014.02.04.04.30.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 04:30:13 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.49 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=74.125.82.49; Received: by mail-wg0-f49.google.com with SMTP id a1so13013318wgh.16 for ; Tue, 04 Feb 2014 04:30:13 -0800 (PST) X-Received: by 10.180.101.40 with SMTP id fd8mr7517926wib.1.1391517013506; Tue, 04 Feb 2014 04:30:13 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id h9sm35912097wjz.16.2014.02.04.04.30.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2014 04:30:11 -0800 (PST) From: Linus Walleij To: arm@kernel.org Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij Subject: [PATCH] ARM: pxa: fix compilation problem on AM300EPD board Date: Tue, 4 Feb 2014 13:30:05 +0100 Message-Id: <1391517005-12004-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.5.3 MIME-Version: 1.0 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This board fails compilation like this: arch/arm/mach-pxa/am300epd.c: In function ‘am300_cleanup’: arch/arm/mach-pxa/am300epd.c:179:2: error: implicit declaration of function ‘PXA_GPIO_TO_IRQ’ [-Werror=implicit-function-declaration] free_irq(PXA_GPIO_TO_IRQ(RDY_GPIO_PIN), par); This was caused by commit 88f718e3fa4d67f3a8dbe79a2f97d722323e4051 "ARM: pxa: delete the custom GPIO header" This is because it was previously getting the macro PXA_GPIO_TO_IRQ implicitly from which in turn implicitly included which in turn included . Add the missing include so that the board compiles again. Reported-by: Arnd Bergmann Signed-off-by: Linus Walleij --- Hi ARM SoC folks: please apply this patch directly to the ARM SoC tree fixes branch if you are happy with it. --- arch/arm/mach-pxa/am300epd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-pxa/am300epd.c b/arch/arm/mach-pxa/am300epd.c index c9f309ae88c5..8b90c4f2d430 100644 --- a/arch/arm/mach-pxa/am300epd.c +++ b/arch/arm/mach-pxa/am300epd.c @@ -30,6 +30,7 @@ #include #include +#include #include #include "generic.h"