From patchwork Fri Apr 11 10:39:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 28275 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3251420822 for ; Fri, 11 Apr 2014 10:41:08 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id bj1sf17531421pad.3 for ; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=3ApsEvJx/NeSk1HItoAPDCqjfc/CUgHuwRQuXuohc2E=; b=X5f68dpelvEFQ3aVcX5NrtCAOAepVC7SHc4A/aA3FOWgWu/qX56G0mr/3x7vWGkaXr eZUu/FZADNiJvU8ZjBlBQufxHq082Jm47hogd8djp1fOZ5Z2T78OOSG+AYT3Qom6Ouye 5irW35Cg5lL6IhDsUofOPFbq4n8WR62kW3wX5OSv84NbD0GFegaX2VmTk1k1oJeg6wtw C/rAp7ScJUtHgzQsDGJsPIyvMXUO1JZIsYXK0o0GoKgPY97dl6Mi+Qb4TqdHPNwgsojf U5gPPIppCdW1p9w2MBnUpF5gwcbp9dcG4ieStkP80Qk7n+ns7Ld72WgH2J0UmdJCsket 3Xww== X-Gm-Message-State: ALoCoQk1OiGiZYXhv2jyG4eiDbs9kOfkpY8I+WEO7oj40D2PKusWMBeWzLLUhMW4gmmcWwQzVilg X-Received: by 10.66.252.1 with SMTP id zo1mr11611256pac.40.1397212867422; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.68 with SMTP id f62ls1461089qge.8.gmail; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) X-Received: by 10.52.113.1 with SMTP id iu1mr330978vdb.35.1397212867297; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx.google.com with ESMTPS id h7si1229796vcv.84.2014.04.11.03.41.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Apr 2014 03:41:07 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.175; Received: by mail-ve0-f175.google.com with SMTP id oz11so4615592veb.34 for ; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) X-Received: by 10.58.123.71 with SMTP id ly7mr19306934veb.11.1397212867189; Fri, 11 Apr 2014 03:41:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp46181vcb; Fri, 11 Apr 2014 03:41:06 -0700 (PDT) X-Received: by 10.68.240.5 with SMTP id vw5mr26190884pbc.113.1397212866485; Fri, 11 Apr 2014 03:41:06 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ug9si3940450pab.458.2014.04.11.03.41.05; Fri, 11 Apr 2014 03:41:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750753AbaDKKlD (ORCPT + 8 others); Fri, 11 Apr 2014 06:41:03 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:58281 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933228AbaDKKkC (ORCPT ); Fri, 11 Apr 2014 06:40:02 -0400 Received: by mail-wg0-f43.google.com with SMTP id x13so5167600wgg.2 for ; Fri, 11 Apr 2014 03:40:00 -0700 (PDT) X-Received: by 10.194.59.226 with SMTP id c2mr20288109wjr.6.1397212800360; Fri, 11 Apr 2014 03:40:00 -0700 (PDT) Received: from localhost.localdomain (AToulouse-654-1-377-242.w86-199.abo.wanadoo.fr. [86.199.232.242]) by mx.google.com with ESMTPSA id eq8sm3683033wib.16.2014.04.11.03.39.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Apr 2014 03:39:59 -0700 (PDT) From: Daniel Lezcano To: kgene.kim@samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, t.figa@samsung.com, linaro-kernel@lists.linaro.org, rjw@rjwysocki.net Subject: [PATCH V5 03/20] ARM: exynos: cpuidle: Use cpuidle_register Date: Fri, 11 Apr 2014 12:39:58 +0200 Message-Id: <1397212815-16068-4-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1397212815-16068-1-git-send-email-daniel.lezcano@linaro.org> References: <1397212815-16068-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Use the cpuidle generic function 'cpuidle_register'. That saves us from some extra lines of code and unneeded variables. A side effect of this change is a bug fix where before the cpuidle driver was registered for each_online_cpu and now it is for each_possible_cpu. Signed-off-by: Daniel Lezcano Reviewed-by: Viresh Kumar Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Tomasz Figa --- arch/arm/mach-exynos/cpuidle.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 17df0d8..61e1481 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -40,8 +40,6 @@ #define S5P_CHECK_AFTR 0xFCBA0D10 -static DEFINE_PER_CPU(struct cpuidle_device, exynos4_cpuidle_device); - /* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */ static void exynos4_set_wakeupmask(void) { @@ -160,29 +158,17 @@ static struct cpuidle_driver exynos4_idle_driver = { static int exynos_cpuidle_probe(struct platform_device *pdev) { - int cpu_id, ret; - struct cpuidle_device *device; + int ret; if (soc_is_exynos5440()) exynos4_idle_driver.state_count = 1; - ret = cpuidle_register_driver(&exynos4_idle_driver); + ret = cpuidle_register(&exynos4_idle_driver, NULL); if (ret) { dev_err(&pdev->dev, "failed to register cpuidle driver\n"); return ret; } - for_each_online_cpu(cpu_id) { - device = &per_cpu(exynos4_cpuidle_device, cpu_id); - device->cpu = cpu_id; - - ret = cpuidle_register_device(device); - if (ret) { - dev_err(&pdev->dev, "failed to register cpuidle device\n"); - return ret; - } - } - return 0; }