From patchwork Thu Jun 19 10:38:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 32201 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f71.google.com (mail-pb0-f71.google.com [209.85.160.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 464C9203F4 for ; Thu, 19 Jun 2014 10:38:58 +0000 (UTC) Received: by mail-pb0-f71.google.com with SMTP id rq2sf7232554pbb.10 for ; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=4qCPhsrHLEZNCwD7lYkYxTGj7nbqrS7/grNff4pkOuE=; b=UiAE9xeiaeD0c+pnKg3YyTyqjlT1dyUGRRmTFux8z+pkQjaF8kWxp5fdlzFnJKykg9 700o8qfFamOPca/ZvyvLB4BrRhAhp0w9SKubQYj0h/nNZV2ulXeWn/0Cfc/Iz30JSDB9 +1WcJfsUeIHw6WX/+kgmmbMx8rNPTNag3xIoZyI8woi/TmRNpyMka5kxyviQxkSNWnYj LI7VYRubs0Pr7o/SumZPddwGeETPGh9RzdabRDB0H7AHQaUB8HFa+N/sWCVQFNmcwZWt PbPWWgu3mDGgSxmrjzpI9PagwKy+Fut8EsL//zLu5gOpqC9EXcO9oIxFLSWdarIyCydC U2Xg== X-Gm-Message-State: ALoCoQk8ilCXFvrTpwnTk3Mf/Gvcapb+btGMwZpS3NFiHESm1qhGC2vjTqLVzbXdpqwkMBH6Hlci X-Received: by 10.67.5.163 with SMTP id cn3mr13349pad.25.1403174337596; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.84.72 with SMTP id k66ls502778qgd.96.gmail; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) X-Received: by 10.58.30.1 with SMTP id o1mr374547veh.37.1403174337493; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id qp10si2177543vdb.7.2014.06.19.03.38.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 03:38:57 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.180 as permitted sender) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jw12so2073381veb.25 for ; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) X-Received: by 10.221.64.80 with SMTP id xh16mr1154321vcb.35.1403174337400; Thu, 19 Jun 2014 03:38:57 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp351988vcb; Thu, 19 Jun 2014 03:38:56 -0700 (PDT) X-Received: by 10.180.212.5 with SMTP id ng5mr5238007wic.33.1403174336584; Thu, 19 Jun 2014 03:38:56 -0700 (PDT) Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by mx.google.com with ESMTPS id x7si6659952wjw.138.2014.06.19.03.38.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 03:38:56 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.170 as permitted sender) client-ip=74.125.82.170; Received: by mail-we0-f170.google.com with SMTP id w61so2179204wes.1 for ; Thu, 19 Jun 2014 03:38:56 -0700 (PDT) X-Received: by 10.180.88.131 with SMTP id bg3mr4582728wib.57.1403174336056; Thu, 19 Jun 2014 03:38:56 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id hi2sm7881147wjb.29.2014.06.19.03.38.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jun 2014 03:38:55 -0700 (PDT) From: Daniel Thompson To: Jason Wessel Cc: Daniel Thompson , kgdb-bugreport@lists.sourceforge.net, patches@linaro.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, John Stultz , Anton Vorontsov , Colin Cross , Dirk Behme , kernel-team@android.com, Russell King , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , "David A. Long" , Nicolas Pitre , Catalin Marinas , Frederic Weisbecker , Linus Walleij , Christoffer Dall , kernel@stlinux.com, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Jason Cooper , Peter De Schrijver Subject: [PATCH v4 05/13] irqchip: gic: Remove spin locks from eoi_irq Date: Thu, 19 Jun 2014 11:38:15 +0100 Message-Id: <1403174303-25456-6-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1403174303-25456-1-git-send-email-daniel.thompson@linaro.org> References: <1401961994-18033-1-git-send-email-daniel.thompson@linaro.org> <1403174303-25456-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch is motivated by the comment it removes from gic_init_fiq, namely that the spin locks in eoi_irq preclude certain platforms from supporting FIQ. Currently there is only one upstream platform (tegra) that actually hooks gic_arch_extn.irq_eoi and it does not require these spin locks. Signed-off-by: Daniel Thompson Cc: Thomas Gleixner Cc: Jason Cooper Cc: Peter De Schrijver --- drivers/irqchip/irq-gic.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 0300c08..1cbff1d 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -191,11 +191,8 @@ static void gic_unmask_irq(struct irq_data *d) static void gic_eoi_irq(struct irq_data *d) { - if (gic_arch_extn.irq_eoi) { - raw_spin_lock(&irq_controller_lock); + if (gic_arch_extn.irq_eoi) gic_arch_extn.irq_eoi(d); - raw_spin_unlock(&irq_controller_lock); - } writel_relaxed(gic_irq(d), gic_cpu_base(d) + GIC_CPU_EOI); } @@ -426,13 +423,6 @@ static void __init gic_init_fiq(struct gic_chip_data *gic, unsigned int i; /* - * FIQ can only be supported on platforms without an extended irq_eoi - * method (otherwise we take a lock during eoi handling). - */ - if (gic_arch_extn.irq_eoi) - return; - - /* * If grouping is not available (not implemented or prohibited by * security mode) these registers a read-as-zero/write-ignored. * However as a precaution we restore the reset default regardless of