From patchwork Tue Jul 22 11:11:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 34078 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 818DA20540 for ; Tue, 22 Jul 2014 11:12:04 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id i7sf49268769oag.4 for ; Tue, 22 Jul 2014 04:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=jgOW3IGJSof9Exu99uSYF79+k1Db1+ichEwf1DfX4ew=; b=P1W0Kop6+Yk8GfuiGMhN9eWkRg3JoHGHQUAVJz5U5dnpJ2NlO6xmevcB6rOGb/3g2Z CQCO7JndZU/hpapHAuAz/ItzvPGAivB/fSlWQJ1JWfx1RqFBny+Jdrq93pv6zNq3QzSm 7mBBkXLRu9ey//WoWUmm978AO7xggnKmmJKvo8WHNwZKveWmc6xzdp4LNFGAG/ANrsSO 4GBdEOQOgG86OWLmBN3PAYuc+ucHIg6grHnoEzK5JAkkG2tqvuh3eflYHfgSVFXY0X7C ugyhkXItcck2g2p1TH6pMriu7PGIHs/sAlfGfEOQ59WMIa0kc+KU4iW+BPONDJulv26e cU/Q== X-Gm-Message-State: ALoCoQk/GBANeQSI6/N64o9lzWzRyDBV1IKxwPr1L5MwBnnIwtru62XXPiIWJynlhRfmYJW/cepw X-Received: by 10.182.111.170 with SMTP id ij10mr15151965obb.6.1406027524044; Tue, 22 Jul 2014 04:12:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.19.16 with SMTP id 16ls2452967qgg.57.gmail; Tue, 22 Jul 2014 04:12:03 -0700 (PDT) X-Received: by 10.220.160.67 with SMTP id m3mr19355915vcx.56.1406027523911; Tue, 22 Jul 2014 04:12:03 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id kh9si100049vdb.21.2014.07.22.04.12.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id im17so14738949vcb.17 for ; Tue, 22 Jul 2014 04:12:03 -0700 (PDT) X-Received: by 10.52.244.81 with SMTP id xe17mr32724815vdc.24.1406027523753; Tue, 22 Jul 2014 04:12:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp186651vcb; Tue, 22 Jul 2014 04:12:03 -0700 (PDT) X-Received: by 10.70.96.207 with SMTP id du15mr85994pdb.133.1406027522748; Tue, 22 Jul 2014 04:12:02 -0700 (PDT) Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by mx.google.com with ESMTPS id j15si1245877icg.10.2014.07.22.04.12.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of lee.jones@linaro.org designates 209.85.223.170 as permitted sender) client-ip=209.85.223.170; Received: by mail-ie0-f170.google.com with SMTP id rl12so7987813iec.15 for ; Tue, 22 Jul 2014 04:12:02 -0700 (PDT) X-Received: by 10.50.50.175 with SMTP id d15mr15138404igo.35.1406027522460; Tue, 22 Jul 2014 04:12:02 -0700 (PDT) Received: from localhost.localdomain (host109-148-232-149.range109-148.btcentralplus.com. [109.148.232.149]) by mx.google.com with ESMTPSA id lo3sm1302829igb.22.2014.07.22.04.12.00 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:02 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, Lee Jones Subject: [PATCH 14/19] mfd: twl6030-irq: Extinguish coding style warnings Date: Tue, 22 Jul 2014 12:11:20 +0100 Message-Id: <1406027485-15657-15-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> References: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This is part of an effort to clean-up the MFD subsystem. WARNING: please, no space before tabs +^IRSV_INTR_OFFSET, ^I/* Bit 12^IReserved^I^I*/$ WARNING: Missing a blank line after declarations + u8 unmask_value; + ret = twl_i2c_read_u8(TWL_MODULE_PIH, &unmask_value, WARNING: Missing a blank line after declarations + u8 mask_value; + ret = twl_i2c_read_u8(TWL_MODULE_PIH, &mask_value, total: 0 errors, 3 warnings, 484 lines checked Signed-off-by: Lee Jones --- drivers/mfd/twl6030-irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index a6bb17d..2807e1a 100644 --- a/drivers/mfd/twl6030-irq.c +++ b/drivers/mfd/twl6030-irq.c @@ -70,7 +70,7 @@ static int twl6030_interrupt_mapping[24] = { BATDETECT_INTR_OFFSET, /* Bit 9 BAT */ SIMDETECT_INTR_OFFSET, /* Bit 10 SIM */ MMCDETECT_INTR_OFFSET, /* Bit 11 MMC */ - RSV_INTR_OFFSET, /* Bit 12 Reserved */ + RSV_INTR_OFFSET, /* Bit 12 Reserved */ MADC_INTR_OFFSET, /* Bit 13 GPADC_RT_EOC */ MADC_INTR_OFFSET, /* Bit 14 GPADC_SW_EOC */ GASGAUGE_INTR_OFFSET, /* Bit 15 CC_AUTOCAL */ @@ -245,6 +245,7 @@ int twl6030_interrupt_unmask(u8 bit_mask, u8 offset) { int ret; u8 unmask_value; + ret = twl_i2c_read_u8(TWL_MODULE_PIH, &unmask_value, REG_INT_STS_A + offset); unmask_value &= (~(bit_mask)); @@ -258,6 +259,7 @@ int twl6030_interrupt_mask(u8 bit_mask, u8 offset) { int ret; u8 mask_value; + ret = twl_i2c_read_u8(TWL_MODULE_PIH, &mask_value, REG_INT_STS_A + offset); mask_value |= (bit_mask);