From patchwork Tue Jul 22 11:11:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 34080 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A84CE20540 for ; Tue, 22 Jul 2014 11:12:09 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id g18sf48804983oah.6 for ; Tue, 22 Jul 2014 04:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=8uG74xYEeLF8pqReSdTNp52AmFUtsDYYIbH7wlIJWOc=; b=eTjiwNCzW25YrWhfzM1wwcqRSaiVQvBBVKhUt3IpFZf3FYtyzC+HFrPQwKkAN+OoG4 MlhQFbRKF7Q69wSiQdxdr4PrmGjwh8SFTNuHTvlnjjd7fqpHFNtLr12pIuA0TWnepi6k PEYrI7fc6lBaFizLQvHLFYY7tcy9KUw6yLMf9Fc79xbKtYO+p5iptZQBT9DChGJl34Zb y477scEkCLKw7F+3ZknbVa1R676C5GjSBBrc4P4KfPHAT7B8H/0mPRvxEVHubIgu9uxZ VByifpbwcvUK+SG5tOCzhZXa+BVmpI/bC0KO9lShuMxRhpwXTWj8iZCFytSrqUmfriRZ CCVg== X-Gm-Message-State: ALoCoQmldwO2IViS2pALKhxXciqjyVUmx79OqjWiw36ifTCB+RsRh3qbS5Rnv28wrIvjxQbCmFmt X-Received: by 10.42.62.73 with SMTP id x9mr7081755ich.15.1406027529029; Tue, 22 Jul 2014 04:12:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.175 with SMTP id v44ls564005qgv.86.gmail; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) X-Received: by 10.52.113.37 with SMTP id iv5mr22547613vdb.51.1406027528819; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id dk1si74710vdb.95.2014.07.22.04.12.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id hq11so12845325vcb.24 for ; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) X-Received: by 10.52.244.138 with SMTP id xg10mr32883641vdc.40.1406027528754; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp186665vcb; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) X-Received: by 10.50.107.7 with SMTP id gy7mr15141367igb.15.1406027528162; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) by mx.google.com with ESMTPS id ro2si36476225igb.54.2014.07.22.04.12.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of lee.jones@linaro.org designates 209.85.223.177 as permitted sender) client-ip=209.85.223.177; Received: by mail-ie0-f177.google.com with SMTP id at20so7887660iec.36 for ; Tue, 22 Jul 2014 04:12:08 -0700 (PDT) X-Received: by 10.50.35.133 with SMTP id h5mr15303286igj.26.1406027527949; Tue, 22 Jul 2014 04:12:07 -0700 (PDT) Received: from localhost.localdomain (host109-148-232-149.range109-148.btcentralplus.com. [109.148.232.149]) by mx.google.com with ESMTPSA id lo3sm1302829igb.22.2014.07.22.04.12.06 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:07 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, Lee Jones Subject: [PATCH 17/19] mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch Date: Tue, 22 Jul 2014 12:11:23 +0100 Message-Id: <1406027485-15657-18-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> References: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This is part of an effort to clean-up the MFD subsystem. ERROR: space required before the open parenthesis '(' + if(!micro->msg) WARNING: unnecessary whitespace before a quoted newline + dev_dbg(micro->dev, "key message ignored, no handle \n"); WARNING: unnecessary whitespace before a quoted newline + dev_dbg(micro->dev, "touchscreen message ignored, no handle \n"); WARNING: space prohibited before semicolon + rx->id = (ch & 0xf0) >> 4 ; total: 1 errors, 3 warnings, 482 lines checked Signed-off-by: Lee Jones --- drivers/mfd/ipaq-micro.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index 7e50fe0..8df3266 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -115,7 +115,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) } else { dev_err(micro->dev, "out of band RX message 0x%02x\n", id); - if(!micro->msg) + if (!micro->msg) dev_info(micro->dev, "no message queued\n"); else dev_info(micro->dev, "expected message %02x\n", @@ -126,13 +126,13 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data) if (micro->key) micro->key(micro->key_data, len, data); else - dev_dbg(micro->dev, "key message ignored, no handle \n"); + dev_dbg(micro->dev, "key message ignored, no handle\n"); break; case MSG_TOUCHSCREEN: if (micro->ts) micro->ts(micro->ts_data, len, data); else - dev_dbg(micro->dev, "touchscreen message ignored, no handle \n"); + dev_dbg(micro->dev, "touchscreen message ignored, no handle\n"); break; default: dev_err(micro->dev, @@ -154,7 +154,7 @@ static void micro_process_char(struct ipaq_micro *micro, u8 ch) rx->state = STATE_ID; /* Next byte is the id and len */ break; case STATE_ID: /* Looking for id and len byte */ - rx->id = (ch & 0xf0) >> 4 ; + rx->id = (ch & 0xf0) >> 4; rx->len = (ch & 0x0f); rx->index = 0; rx->chksum = ch;