From patchwork Tue Jul 22 11:11:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 34083 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6C10B20540 for ; Tue, 22 Jul 2014 11:18:28 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id ft15sf59454821pdb.2 for ; Tue, 22 Jul 2014 04:18:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=TVMCsvnwaTZp6qnwiv6h8igwmbschtPiuvuDKe8o2Vw=; b=fvZC6HTRE6ghk1+RX8vVYQtb5zImbmn6mum8xxi0LzsfQjOE1EAOI37fi7QLMbv40P i4Ku33XWWASlv9SJA440hs5Bf+E4VqDkKBxy0fIuN1WVL82aO36dTqlc3baSXhN3keod Di733hGUY0RfR44an829kotVkdXepIueX2UqpyfXLLE9FmBhezaSee1Gj4C7eQ+iJXbs enKXp1/vDzlLRnBEo9GmbSvSxik9xwCHRzZwgrDk7W61QXUD0tacOA0SMFQDAvmts24j VSF4hrrYMVStUZqTFdGP5NyxekYZzF9ODIy7gws+k24Zp5jLUmyLa8Shzk3G9/UdcYwd rk/A== X-Gm-Message-State: ALoCoQmgFm5S5TErindLoYL38lxA5z63XDtP7sdFrjsLKCVp/7XR9WpbUlBCFz2VuRPphSl5wEXw X-Received: by 10.66.252.6 with SMTP id zo6mr9978203pac.40.1406027530731; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.37.6 with SMTP id q6ls489749qgq.49.gmail; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) X-Received: by 10.221.69.8 with SMTP id ya8mr38488066vcb.39.1406027530534; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id h4si86276vdi.70.2014.07.22.04.12.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id hq11so12845385vcb.24 for ; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) X-Received: by 10.52.120.38 with SMTP id kz6mr9779815vdb.86.1406027530460; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp186669vcb; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) X-Received: by 10.50.43.167 with SMTP id x7mr15651755igl.36.1406027530042; Tue, 22 Jul 2014 04:12:10 -0700 (PDT) Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) by mx.google.com with ESMTPS id h15si1229916igt.51.2014.07.22.04.12.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of lee.jones@linaro.org designates 209.85.223.177 as permitted sender) client-ip=209.85.223.177; Received: by mail-ie0-f177.google.com with SMTP id at20so7576030iec.8 for ; Tue, 22 Jul 2014 04:12:09 -0700 (PDT) X-Received: by 10.50.134.232 with SMTP id pn8mr15484216igb.11.1406027529832; Tue, 22 Jul 2014 04:12:09 -0700 (PDT) Received: from localhost.localdomain (host109-148-232-149.range109-148.btcentralplus.com. [109.148.232.149]) by mx.google.com with ESMTPSA id lo3sm1302829igb.22.2014.07.22.04.12.08 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Jul 2014 04:12:09 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: sameo@linux.intel.com, Lee Jones Subject: [PATCH 18/19] mfd: kempld-core: Correct a variety of checkpatch warnings Date: Tue, 22 Jul 2014 12:11:24 +0100 Message-Id: <1406027485-15657-19-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> References: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , WARNING: line over 80 characters +module_param_string(force_device_id, force_device_id, sizeof(force_device_id), 0); WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(1); WARNING: __initdata should be placed after kempld_dmi_table[] +static struct dmi_system_id __initdata kempld_dmi_table[] = { WARNING: line over 80 characters + for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++) total: 0 errors, 4 warnings, 771 lines checked This is part of an effort to clean-up the MFD subsystem. Signed-off-by: Lee Jones --- drivers/mfd/kempld-core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index f7ff018..bd26961 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -24,7 +24,8 @@ #define MAX_ID_LEN 4 static char force_device_id[MAX_ID_LEN + 1] = ""; -module_param_string(force_device_id, force_device_id, sizeof(force_device_id), 0); +module_param_string(force_device_id, force_device_id, + sizeof(force_device_id), 0); MODULE_PARM_DESC(force_device_id, "Override detected product"); /* @@ -36,7 +37,7 @@ static void kempld_get_hardware_mutex(struct kempld_device_data *pld) { /* The mutex bit will read 1 until access has been granted */ while (ioread8(pld->io_index) & KEMPLD_MUTEX_KEY) - msleep(1); + usleep_range(1000, 3000); } static void kempld_release_hardware_mutex(struct kempld_device_data *pld) @@ -499,7 +500,7 @@ static struct platform_driver kempld_driver = { .remove = kempld_remove, }; -static struct dmi_system_id __initdata kempld_dmi_table[] = { +static struct dmi_system_id kempld_dmi_table[] __initdata = { { .ident = "BHL6", .matches = { @@ -736,7 +737,8 @@ static int __init kempld_init(void) int ret; if (force_device_id[0]) { - for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++) + for (id = kempld_dmi_table; + id->matches[0].slot != DMI_NONE; id++) if (strstr(id->ident, force_device_id)) if (id->callback && id->callback(id)) break;