From patchwork Wed Jul 30 19:23:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 34560 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 42D9720792 for ; Wed, 30 Jul 2014 19:24:03 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id kx10sf10639482pab.8 for ; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:date :message-id:subject:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=geccGsAcmdjiP3KEvagLeMtB0nqrvYpM6FQO7UAr+yQ=; b=M+EQYyVGn/a8V924c4NdD5xaK8sP3NQ/LpIaKBYcUmNH4jMqdBbLOJYI/yMJu3onQ/ /x1ADu5qmT9hDC0wy3Dn02wmZRrEahRPr0z3W4R9IcXEigbpkbVhZxM9j/D7VpFs9G2s ICbHfO4H+WWgyiUZgxidK89cH3fboQmIUTIQF7fitUOnxLJOL25efcUK6OoKmT/BKZBw /DOqyp+eAz95Fo9hYwjI+6TqGt5ukB1xdzBM58Ws8rkxpbuYr5BdBK5O/OZNAlbm/LMb 0UiVaCafnm1YKNtotWAkuY5ixsBW6C18dAZL38mO11bhsGMXhoTS9E5+OqHNrWdg5TNp 0edQ== X-Gm-Message-State: ALoCoQkQl8Kre752E5pv7cPh9xKPV8S54muoSaI3rYtbVZu4XTuT3DBnoeuwOsY4tDTVUIR0K5xC X-Received: by 10.66.140.102 with SMTP id rf6mr2564968pab.17.1406748242501; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.50 with SMTP id i47ls679201qgd.38.gmail; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) X-Received: by 10.220.5.1 with SMTP id 1mr4443234vct.73.1406748242320; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id na9si2657853vcb.64.2014.07.30.12.24.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Jul 2014 12:24:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id le20so2554506vcb.14 for ; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) X-Received: by 10.52.37.81 with SMTP id w17mr3667839vdj.95.1406748242071; Wed, 30 Jul 2014 12:24:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp51047vcb; Wed, 30 Jul 2014 12:24:01 -0700 (PDT) X-Received: by 10.70.65.100 with SMTP id w4mr7096268pds.128.1406748241165; Wed, 30 Jul 2014 12:24:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fn2si3345175pab.164.2014.07.30.12.24.00 for ; Wed, 30 Jul 2014 12:24:01 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755945AbaG3TX7 (ORCPT + 26 others); Wed, 30 Jul 2014 15:23:59 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35652 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755499AbaG3TX5 (ORCPT ); Wed, 30 Jul 2014 15:23:57 -0400 Received: from cpc11-sgyl31-2-0-cust672.sgyl.cable.virginm.net ([94.175.94.161] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XCZT4-0006Za-Tr; Wed, 30 Jul 2014 19:23:23 +0000 Received: from broonie by debutante with local (Exim 4.83) (envelope-from ) id 1XCZT2-0005Ux-1q; Wed, 30 Jul 2014 20:23:16 +0100 From: Mark Brown To: Thomas Gleixner , Jason Cooper Cc: Geoff Levand , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Mark Brown Date: Wed, 30 Jul 2014 20:23:14 +0100 Message-Id: <1406748194-21094-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.0.1 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mezzanine.sirena.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Subject: [PATCH] irq: gic-v3: Tag all low level accessors __maybey_unused X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mark Brown This is only really needed for gic_write_sgi1r in the !SMP case since it is only referenced in the SMP initialisation code but it seems better to have these functions all next to each other and declared consistently. Signed-off-by: Mark Brown --- drivers/irqchip/irq-gic-v3.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 41b98ba7ffd1..f1ba38f11f7a 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -104,7 +104,7 @@ static void gic_redist_wait_for_rwp(void) } /* Low level accessors */ -static u64 gic_read_iar(void) +static u64 __maybe_unused gic_read_iar(void) { u64 irqstat; @@ -112,24 +112,24 @@ static u64 gic_read_iar(void) return irqstat; } -static void gic_write_pmr(u64 val) +static void __maybe_unused gic_write_pmr(u64 val) { asm volatile("msr_s " __stringify(ICC_PMR_EL1) ", %0" : : "r" (val)); } -static void gic_write_ctlr(u64 val) +static void __maybe_unused gic_write_ctlr(u64 val) { asm volatile("msr_s " __stringify(ICC_CTLR_EL1) ", %0" : : "r" (val)); isb(); } -static void gic_write_grpen1(u64 val) +static void __maybe_unused gic_write_grpen1(u64 val) { asm volatile("msr_s " __stringify(ICC_GRPEN1_EL1) ", %0" : : "r" (val)); isb(); } -static void gic_write_sgi1r(u64 val) +static void __maybe_unused gic_write_sgi1r(u64 val) { asm volatile("msr_s " __stringify(ICC_SGI1R_EL1) ", %0" : : "r" (val)); }