From patchwork Fri Aug 8 19:45:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murali Karicheri X-Patchwork-Id: 35167 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f198.google.com (mail-vc0-f198.google.com [209.85.220.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8443921457 for ; Fri, 8 Aug 2014 19:46:13 +0000 (UTC) Received: by mail-vc0-f198.google.com with SMTP id le20sf16908844vcb.1 for ; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=Kyq+Gua6tKn1ga1bvVpr5oD/2Tub9mekGNvVu7ly5oQ=; b=I8bKiC6XtSAHColL/b4RLLumXfFd+0D3mOFfKwh0Ofhkvn2o9w3TVDTFzxLyhB03dz 8P2Ezeos127fCs6ke+aaBfJKNUDQyNpZAf7tzmOJw1H4HEqWR1pisJu5fne+I4Ou68QC 7FI5jU4XPEIVObk3gbV2PZGzrtXRAyXyld4Ne6d+7qN/dDYITD2x8OJgbKz6SU/FjEys LlRUMCdptDXEJkevoG9kjZwCVuUD9e50LE3Q2K6Bz6krsX65h6sFGutu0V/rh+9kizHO 0dafSgW4fVJVkwz+3Db1DKIF8GVkVut2TZorL9/RZLeFaZCxE5KMpjnWNLMdCBbr1dhT /NMw== X-Gm-Message-State: ALoCoQmP4jUtMIEqLAfxwGWngm1XWUO0uH3k+GjM2djOOAzfRDt32sFk8TXSSd9LcTRwXDFOcizF X-Received: by 10.52.182.66 with SMTP id ec2mr5893895vdc.0.1407527173218; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.33.138 with SMTP id j10ls680228qgj.85.gmail; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) X-Received: by 10.52.26.173 with SMTP id m13mr40451vdg.69.1407527173110; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id c2si3222571vcn.74.2014.08.08.12.46.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Aug 2014 12:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id hq11so8782378vcb.24 for ; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) X-Received: by 10.220.79.68 with SMTP id o4mr23522564vck.38.1407527173009; Fri, 08 Aug 2014 12:46:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp149115vcb; Fri, 8 Aug 2014 12:46:12 -0700 (PDT) X-Received: by 10.68.190.229 with SMTP id gt5mr25925114pbc.15.1407527171903; Fri, 08 Aug 2014 12:46:11 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jc10si1085761pbd.185.2014.08.08.12.46.11 for ; Fri, 08 Aug 2014 12:46:11 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbaHHTp4 (ORCPT + 26 others); Fri, 8 Aug 2014 15:45:56 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:58498 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbaHHTpw (ORCPT ); Fri, 8 Aug 2014 15:45:52 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s78JjJ8S028273; Fri, 8 Aug 2014 14:45:20 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s78JjJKV017432; Fri, 8 Aug 2014 14:45:19 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Fri, 8 Aug 2014 14:45:19 -0500 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s78JjGJZ027471; Fri, 8 Aug 2014 14:45:17 -0500 From: Murali Karicheri To: , , , CC: , Murali Karicheri Subject: [PATCH v2] PCI: keystone: add a pci quirk to limit mrrs Date: Fri, 8 Aug 2014 15:45:32 -0400 Message-ID: <1407527132-3294-1-git-send-email-m-karicheri2@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m-karicheri2@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Keystone PCI controller has a limitation that memory read request size must not exceed 256 bytes. This is a hardware limitation and add a quirk to force this limit on all downstream devices by updating mrrs. Signed-off-by: Murali Karicheri --- -v2: made the quirk happens after tuning -v1: changed printk to indicate PCI bdf This applies on top of the Keystone PCI controller patch series at http://thread.gmane.org/gmane.linux.kernel.pci/33523 drivers/pci/host/pci-keystone.c | 40 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c index c1cfaef..a132622 100644 --- a/drivers/pci/host/pci-keystone.c +++ b/drivers/pci/host/pci-keystone.c @@ -42,8 +42,48 @@ /* DEV_STAT_CTRL */ #define PCIE_CAP_BASE 0x70 +/* PCIE controller device IDs */ +#define PCIE_RC_K2HK 0xb008 +#define PCIE_RC_K2E 0xb009 +#define PCIE_RC_K2L 0xb00a + #define to_keystone_pcie(x) container_of(x, struct keystone_pcie, pp) +static void quirk_limit_mrrs(struct pci_dev *dev) +{ + struct pci_bus *bus = dev->bus; + struct pci_dev *bridge = bus->self; + + if (pci_is_root_bus(bus)) + return; + + /* look for the host bridge */ + while (!pci_is_root_bus(bus)) { + bridge = bus->self; + bus = bus->parent; + } + + if (bridge) { + u16 id; + + /* + * Keystone PCI controller has a h/w limitation of + * 256 bytes maximum read request size. It can't handle + * anything higher than this. So force this limit on + * all downstream devices + */ + pci_read_config_word(bridge, PCI_DEVICE_ID, &id); + if ((id == PCIE_RC_K2HK) || (id == PCIE_RC_K2E) || + (id == PCIE_RC_K2L)) { + if (pcie_get_readrq(dev) > 256) { + dev_info(&dev->dev, "limiting mrrs to 256\n"); + pcie_set_readrq(dev, 256); + } + } + } +} +DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_limit_mrrs); + static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie) { struct pcie_port *pp = &ks_pcie->pp;