From patchwork Fri Aug 15 09:12:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 35426 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f198.google.com (mail-qc0-f198.google.com [209.85.216.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 74A90203C5 for ; Fri, 15 Aug 2014 09:12:45 +0000 (UTC) Received: by mail-qc0-f198.google.com with SMTP id r5sf6278553qcx.5 for ; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=rBBbhQRt0BhFDfGIJ3HaE5fkOrFy4od3Gaum1/aROuU=; b=hIyTjVnZYxO6+nZW69fnqsKFZ8O23zkNeiEGeWVbb21GSpbYgrTo26jaZ53zQOZoRK eYtHGnH58oYCDfBhQt5o2i5r/lVGTGmla4Ohfp+WxwofVSEhxbM9iZLbNGL/Ytie5AMN NameKATU40IqqxcRedPhEeFeJWN3G7Mzk3xJ4xMp2ih3Mpnzh/9eWxy8GGKUVAZ7j7Qx UaoC+ZvZMevcARBjpcVfMOKaRgDztNzhIVmkHLhD+VXD6y0kbrtBERCWankjTMNGC4hc KNJ2FWZHP65LBtGYBqUZZFpF96njyXY8FnjqwKeHT92IJt8/9ULOxNFxBVqK6vOI4viY vIYA== X-Gm-Message-State: ALoCoQkmdsbBHXa0jxAeSFV8OxmqKURH+I8zsD60+kGFC6OV7KYjdU518Rz/nF+CZ2Rd1MZr+ebs X-Received: by 10.236.39.165 with SMTP id d25mr5412998yhb.2.1408093965299; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.16.171 with SMTP id 40ls1333727qgb.10.gmail; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) X-Received: by 10.140.49.201 with SMTP id q67mr23916210qga.7.1408093965215; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id y11si11067451qay.12.2014.08.15.02.12.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 02:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id la4so2715162vcb.33 for ; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) X-Received: by 10.52.228.67 with SMTP id sg3mr12642636vdc.6.1408093965008; Fri, 15 Aug 2014 02:12:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp98213vcb; Fri, 15 Aug 2014 02:12:44 -0700 (PDT) X-Received: by 10.180.21.208 with SMTP id x16mr19294103wie.73.1408093964080; Fri, 15 Aug 2014 02:12:44 -0700 (PDT) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx.google.com with ESMTPS id v2si10650394wju.23.2014.08.15.02.12.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 02:12:44 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.griffin@linaro.org designates 209.85.212.178 as permitted sender) client-ip=209.85.212.178; Received: by mail-wi0-f178.google.com with SMTP id hi2so571726wib.5 for ; Fri, 15 Aug 2014 02:12:43 -0700 (PDT) X-Received: by 10.180.90.11 with SMTP id bs11mr47616320wib.47.1408093963633; Fri, 15 Aug 2014 02:12:43 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id ko8sm17484501wjc.11.2014.08.15.02.12.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 02:12:42 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chris@printf.net, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, zhangfei.gao@marvell.com, prakity@marvell.com, rmk+kernel@arm.linux.org.uk Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently Date: Fri, 15 Aug 2014 10:12:38 +0100 Message-Id: <1408093958-26058-1-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , .set_uhs_signaling field is currently initialised twice once to the arch specific callback pxav3_set_uhs_signaling, and also to the generic sdhci_set_uhs_signaling callback. This means that uhs is currently broken for this platform currently, as pxav3 has some special constriants which means it can't use the generic callback. This happened in commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function") commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")' Signed-off-by: Peter Griffin --- drivers/mmc/host/sdhci-pxav3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index 6f842fb..3f350ea 100644 --- a/drivers/mmc/host/sdhci-pxav3.c +++ b/drivers/mmc/host/sdhci-pxav3.c @@ -229,7 +229,6 @@ static const struct sdhci_ops pxav3_sdhci_ops = { .get_max_clock = sdhci_pltfm_clk_get_max_clock, .set_bus_width = sdhci_set_bus_width, .reset = pxav3_reset, - .set_uhs_signaling = sdhci_set_uhs_signaling, }; static struct sdhci_pltfm_data sdhci_pxav3_pdata = {