From patchwork Fri Aug 15 12:40:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 35457 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 92D6023917 for ; Fri, 15 Aug 2014 12:40:33 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id fp1sf17083628pdb.1 for ; Fri, 15 Aug 2014 05:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=cTK4XD79/qSARMLN/rcoYrZ5691unUddBcsFw7ooLvI=; b=kx9nmXw8g9DBOENWtFTjRuJaxFXSg90U3X4kZdiHTv6+l86e7qLdCTvxF0GZQ/Dnuu 0DCJzhJE2+ppImSFBGLVn2huVkLAT3+pTq2QEXCjSx8m7KRukdBstI4JV6vCsHM9MKS9 zzSHEfLuA9ntxD7TWH0899yBFfebi+H77t+/LtUJZQW1rUttWM7awEsQNV5kC1a6e8Sy IO2gLb+Z+Wq9uifY8zbD+1WGik7K6cjK5wo0cADlrNeOylZQDF09PyEynXCrbv7Hy+L7 iOxU+NquNuf34iwquSknf4OFhsrgtQhQa5gAtKvoKpEkoCpsZdfmqGrW03VRM09zTceV lAKg== X-Gm-Message-State: ALoCoQnlu/Fx3R6liChuAXNhbSRxMVgg0HjyxyZB8UH0ubRnfaIm836bCvQr5KtfXmIU6yzmPAOe X-Received: by 10.66.141.165 with SMTP id rp5mr42456pab.47.1408106431105; Fri, 15 Aug 2014 05:40:31 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.102.23 with SMTP id v23ls1358525qge.51.gmail; Fri, 15 Aug 2014 05:40:30 -0700 (PDT) X-Received: by 10.224.136.200 with SMTP id s8mr27631688qat.44.1408106430954; Fri, 15 Aug 2014 05:40:30 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id x8si11635133qas.81.2014.08.15.05.40.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id hy4so2812142vcb.22 for ; Fri, 15 Aug 2014 05:40:30 -0700 (PDT) X-Received: by 10.221.56.5 with SMTP id wa5mr10173480vcb.25.1408106430502; Fri, 15 Aug 2014 05:40:30 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp109568vcb; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) X-Received: by 10.180.39.172 with SMTP id q12mr20133378wik.55.1408106429559; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by mx.google.com with ESMTPS id cs5si2502590wib.14.2014.08.15.05.40.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:29 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.griffin@linaro.org designates 209.85.212.171 as permitted sender) client-ip=209.85.212.171; Received: by mail-wi0-f171.google.com with SMTP id hi2so773081wib.16 for ; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) X-Received: by 10.180.19.200 with SMTP id h8mr54624233wie.32.1408106429060; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:28 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 4/9] phy: phy-ti-pipe3: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:11 +0100 Message-Id: <1408106416-19044-5-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-ti-pipe3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c index b964aa9..9280ef8 100644 --- a/drivers/phy/phy-ti-pipe3.c +++ b/drivers/phy/phy-ti-pipe3.c @@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev) struct clk *clk; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n"); + if (!phy) return -ENOMEM; - } + phy->dev = &pdev->dev; if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {