From patchwork Mon Mar 30 14:39:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 46518 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f200.google.com (mail-qc0-f200.google.com [209.85.216.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 882A82159A for ; Mon, 30 Mar 2015 14:40:51 +0000 (UTC) Received: by qcbbn5 with SMTP id bn5sf99718610qcb.2 for ; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=UGYO93tBZJ2NmrFHBgvmzYZaTgFI5PY+9rpgarDEsaA=; b=XsgC7qJdCfJo6K7ih8Cmsrn0Q3xlro/uPHSZWEuEht9B8UHZxmZ53CHY6Q+WhdCQKW MP4xNIgPNt7LaulFKZYbuaMUQLWsVt1t2F96POr9kRJR9bGzG8ZYPB30VYMUZeyWcsvI Y4Dh7SIaET/IYhXnRib6hI0gsHjwTu1LKKj9nPkwuIfe5ZKGQkkPwF/mL+WpzbzCXMSP E/bamPJYYtrKDvwJKObg7ssg0oB/CDT2YbY7b4mkk48wG26OynIyHx4E/RVxh+Gp10vz XCNRhyZRZyUqEkaF3LTbdRmXrLUNcaiCyGmyyUUFbJ81vTtiA9timGeYAem4YI42lfWo yyBA== X-Gm-Message-State: ALoCoQmlD3w1Byi0xvU7y0bMkGOpeSaFfIXD3R8GmTdQp1E1rNNUfr4qAOsmZokNdJsFlVaXDBDB X-Received: by 10.236.63.230 with SMTP id a66mr40097141yhd.51.1427726451436; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.28.183 with SMTP id 52ls2281418qgz.49.gmail; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) X-Received: by 10.140.16.162 with SMTP id 31mr13377436qgb.31.1427726451325; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) Received: from mail-qc0-f180.google.com (mail-qc0-f180.google.com. [209.85.216.180]) by mx.google.com with ESMTPS id z1si671713qkz.48.2015.03.30.07.40.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 07:40:51 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.216.180 as permitted sender) client-ip=209.85.216.180; Received: by qcgx3 with SMTP id x3so15539626qcg.3 for ; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) X-Received: by 10.140.82.7 with SMTP id g7mr36742368qgd.42.1427726451165; Mon, 30 Mar 2015 07:40:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.96.155.231 with SMTP id vz7csp1519814qdb; Mon, 30 Mar 2015 07:40:50 -0700 (PDT) X-Received: by 10.66.171.199 with SMTP id aw7mr60511751pac.6.1427726448490; Mon, 30 Mar 2015 07:40:48 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cz8si15078826pdb.85.2015.03.30.07.40.46; Mon, 30 Mar 2015 07:40:48 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbbC3Oke (ORCPT + 27 others); Mon, 30 Mar 2015 10:40:34 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:33025 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbbC3OkW (ORCPT ); Mon, 30 Mar 2015 10:40:22 -0400 Received: by wgbgs4 with SMTP id gs4so86503421wgb.0 for ; Mon, 30 Mar 2015 07:40:21 -0700 (PDT) X-Received: by 10.194.19.197 with SMTP id h5mr63171567wje.109.1427726420984; Mon, 30 Mar 2015 07:40:20 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id cf12sm16037489wjb.10.2015.03.30.07.40.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Mar 2015 07:40:19 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, chris@printf.net, ulf.hansson@linaro.org Cc: peter.griffin@linaro.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, peppe.cavallaro@st.com Subject: [PATCH v3 6/9] mmc: sdhci-st: Update the quirks for this controller. Date: Mon, 30 Mar 2015 15:39:59 +0100 Message-Id: <1427726402-7513-7-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1427726402-7513-1-git-send-email-peter.griffin@linaro.org> References: <1427726402-7513-1-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.216.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Some additional quirks need to be enabled now we support UHS modes. This avoids some spurious warnings like "Got data interrupt 0x00000002 even though no data operation was in progress" Testing on stih410-b2120 board achieves the following speeds with HS200 eMMC card. max-frequency = 200Mhz /dev/mmcblk0p1: Timing buffered disk reads: 270 MB in 3.02 seconds = 89.54 MB/sec max-frequency = 100Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 210 MB in 3.00 seconds = 70.00 MB/sec max-frequency = 50Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 118 MB in 3.00 seconds = 39.28 MB/sec This is better than the 3.10 kernel which achieves 77.59 MB/sec at 200Mhz clock (same board/soc/eMMC). Signed-off-by: Peter Griffin Signed-off-by: Giuseppe Cavallaro Acked-by: Maxime Coquelin --- drivers/mmc/host/sdhci-st.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index fc9565f..28ac38a 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -340,7 +340,10 @@ static const struct sdhci_ops sdhci_st_ops = { static const struct sdhci_pltfm_data sdhci_st_pdata = { .ops = &sdhci_st_ops, .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC | - SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | + SDHCI_QUIRK_NO_HISPD_BIT, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, };