From patchwork Fri Apr 10 08:58:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 47004 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4867B21416 for ; Fri, 10 Apr 2015 09:01:00 +0000 (UTC) Received: by wgiv13 with SMTP id v13sf2575857wgi.3 for ; Fri, 10 Apr 2015 02:00:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=W9kXOT+iM8OHUeWBYo4MohoBBXfbxS0obgK0W4ttyBo=; b=Ysa9MdrXHjdueI/lPAXQGBR3xzRjDV7wzMktRizGqWe2xWm3jWWNVqTY6Jk8EEomI2 7Ph35JCP2yr5wTBC9/9rb/FUFJ21vjzgjDTqgmxs/36c63eo34kUqGlh9BWenUD20jQx GLwbWDbOlqsXb/pFjkkfHAytBiAAmpsk2tPcF9y0188TUbZahJo2n7ECo6pkdY/QocoF CcQma1WsjIAMxYdysd+FRKRCfKjMJH5qyjHlyUnjQ81KUHTuxyOf281oKXu5lY2v0LPK 6e0SVQW3JbPinxV/02Ph3v1OpkH1VvHoYNyy9QOEjHpyOYwfjrmQjj5jrJSaEkq4KlML 62Ig== X-Gm-Message-State: ALoCoQl22kIjHuMXI+vwNrFftoJltUbOG/HFxGa7SiVMcGMMZDsS8zfy6HGVeOiYYow3Dykhf5RL X-Received: by 10.194.221.65 with SMTP id qc1mr116713wjc.7.1428656459615; Fri, 10 Apr 2015 02:00:59 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.207.4 with SMTP id ls4ls424258lac.73.gmail; Fri, 10 Apr 2015 02:00:59 -0700 (PDT) X-Received: by 10.112.98.201 with SMTP id ek9mr509673lbb.68.1428656459330; Fri, 10 Apr 2015 02:00:59 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id k18si982216lbh.10.2015.04.10.02.00.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 02:00:59 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by laat2 with SMTP id t2so8575173laa.1 for ; Fri, 10 Apr 2015 02:00:59 -0700 (PDT) X-Received: by 10.112.16.196 with SMTP id i4mr499777lbd.72.1428656458715; Fri, 10 Apr 2015 02:00:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp959609lbt; Fri, 10 Apr 2015 02:00:57 -0700 (PDT) X-Received: by 10.70.41.81 with SMTP id d17mr1031161pdl.16.1428656456088; Fri, 10 Apr 2015 02:00:56 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id kv3si2047653pbc.61.2015.04.10.02.00.54; Fri, 10 Apr 2015 02:00:56 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbbDJJAn (ORCPT + 27 others); Fri, 10 Apr 2015 05:00:43 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37608 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754973AbbDJI66 (ORCPT ); Fri, 10 Apr 2015 04:58:58 -0400 Received: by wiaa2 with SMTP id a2so18521337wia.0 for ; Fri, 10 Apr 2015 01:58:57 -0700 (PDT) X-Received: by 10.194.61.244 with SMTP id t20mr999483wjr.83.1428656337206; Fri, 10 Apr 2015 01:58:57 -0700 (PDT) Received: from localhost.localdomain ([31.105.225.148]) by mx.google.com with ESMTPSA id ew5sm23844403wic.14.2015.04.10.01.58.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Apr 2015 01:58:56 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com Cc: peter.griffin@linaro.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, peppe.cavallaro@st.com Subject: [PATCH v4 6/9] mmc: sdhci-st: Update the quirks for this controller. Date: Fri, 10 Apr 2015 09:58:28 +0100 Message-Id: <1428656311-2605-7-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1428656311-2605-1-git-send-email-peter.griffin@linaro.org> References: <1428656311-2605-1-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Some additional quirks need to be enabled now we support UHS modes. This avoids some spurious warnings like "Got data interrupt 0x00000002 even though no data operation was in progress" Testing on stih410-b2120 board achieves the following speeds with HS200 eMMC card. max-frequency = 200Mhz /dev/mmcblk0p1: Timing buffered disk reads: 270 MB in 3.02 seconds = 89.54 MB/sec max-frequency = 100Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 210 MB in 3.00 seconds = 70.00 MB/sec max-frequency = 50Mhz root@debian-armhf:~# hdparm -t /dev/mmcblk0p1 /dev/mmcblk0p1: Timing buffered disk reads: 118 MB in 3.00 seconds = 39.28 MB/sec This is better than the 3.10 kernel which achieves 77.59 MB/sec at 200Mhz clock (same board/soc/eMMC). Signed-off-by: Peter Griffin Signed-off-by: Giuseppe Cavallaro Acked-by: Maxime Coquelin --- drivers/mmc/host/sdhci-st.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index 2ce842b..751452b 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -340,7 +340,10 @@ static const struct sdhci_ops sdhci_st_ops = { static const struct sdhci_pltfm_data sdhci_st_pdata = { .ops = &sdhci_st_ops, .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC | - SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, + SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | + SDHCI_QUIRK_NO_HISPD_BIT, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, };